blender/blender-addons
18
42
Fork 95
Code Issues 616 Pull Requests 29 Projects 1 Releases Wiki Activity

Rigify - saving pbone custom properties to metarig #104695

Merged
Alexander Gavrilov merged 6 commits from Andrej730/blender-addons:rigify_custom_props into main 2023-09-25 21:52:59 +02:00
Conversation 1 Commits 6 Files Changed 1 +5 -3
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit ca78100418 - Show all commits

8
rigify/utils/rig.py
View File

@ -440,10 +440,12 @@ def write_metarig(obj: ArmatureObject, layers=False, func_name="create",
if 'subtype' in props_data:
code.append(f" subtype={props_data['subtype']!r},")
Alexander Gavrilov commented 2023-09-05 12:40:57 +02:00
Outdated
Review
Copy Link

Rather than doing '{foo}', use {repr(foo)}. Manual quoting could be barely tolerated for property names, but for the description it is simply unacceptable.

Rather than doing `'{foo}'`, use `{repr(foo)}`. Manual quoting could be barely tolerated for property names, but for the description it is simply unacceptable.
Andrej commented 2023-09-09 19:01:15 +02:00
Outdated
Review
Copy Link

that's really neat thing about repr, didn't know it can be used that way!
resolved in e2b63e1a4b

that's really neat thing about `repr`, didn't know it can be used that way! resolved in e2b63e1a4b07ffa8ca59eef5b4b2be17189f49ff
if 'description' in props_data:
code.append(f" description={props_data['description']!r}")
code.append(f" )")
code.append(f" description={props_data['description']!r},")
if 'precision' in props_data:
code.append(f" pbone.id_properties_ui({custom_property!r}).update(precision={props_data['precision']})")
code.append(f" precision={props_data['precision']},")
if 'step' in props_data:
Alexander Gavrilov commented 2023-09-25 12:19:52 +02:00
Outdated
Review
Copy Link

This is still not using repr. Also, step and precision should now be supported directly by rna_idprop_ui_create, I fixed that recently.

This is still not using repr. Also, step and precision should now be supported directly by `rna_idprop_ui_create`, I fixed that recently.
Andrej commented 2023-09-25 19:59:55 +02:00
Outdated
Review
Copy Link

Resolved in ca78100418

Resolved in ca78100418069ed45b340504ffcb55a03327627e
code.append(f" step={props_data['step']},")
Alexander Gavrilov commented 2023-09-25 12:20:28 +02:00
Outdated
Review
Copy Link

If current_value is actually equal to default, this would be redundant.

If current_value is actually equal to default, this would be redundant.
Andrej commented 2023-09-25 19:44:35 +02:00
Outdated
Review
Copy Link

resolved in 076763507e

resolved in 076763507e82ff209f546aba4b2ab03061254d9d
code.append(f" )")
if props_data['default'] != current_value:
code.append(f" pbone[{custom_property!r}] = {current_value}")