blender/blender-addons
19
44
Fork 96
Code Issues 634 Pull Requests 28 Projects 1 Releases Wiki Activity

Rigify - saving pbone custom properties to metarig #104695

Merged
Alexander Gavrilov merged 6 commits from Andrej730/blender-addons:rigify_custom_props into main 2023-09-25 21:52:59 +02:00
Conversation 1 Commits 6 Files Changed 1 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit e2b63e1a4b - Show all commits

4
rigify/utils/rig.py
View File

@ -427,7 +427,7 @@ def write_metarig(obj: ArmatureObject, layers=False, func_name="create",
props_data = pbone.id_properties_ui(custom_property).as_dict()
code.append(f" rna_idprop_ui_create(")
code.append(f" pbone, ")
code.append(f" '{custom_property}', ")
code.append(f" {custom_property!r}, ")
code.append(f" default={props_data['default']}, ")
Alexander Gavrilov commented 2023-09-05 12:42:58 +02:00
Outdated
Review
Copy Link

What if the default isn't equal to the current value? This code doesn't preserve the value anywhere.

What if the default isn't equal to the current value? This code doesn't preserve the value anywhere.
Andrej commented 2023-09-09 19:00:05 +02:00
Outdated
Review
Copy Link

resolved in 3677cc4549

resolved in 3677cc454907e82731ac2360be5846d988e48e8c
Alexander Gavrilov commented 2023-09-25 12:18:35 +02:00
Outdated
Review
Copy Link

I'd quote default with repr too. Also, get rid of trailing spaces.

I'd quote default with repr too. Also, get rid of trailing spaces.
Andrej commented 2023-09-25 19:44:06 +02:00
Outdated
Review
Copy Link

resolved in 076763507e

resolved in 076763507e82ff209f546aba4b2ab03061254d9d
if 'min' in props_data:
code.append(f" min={props_data['min']}, ")
@ -438,7 +438,7 @@ def write_metarig(obj: ArmatureObject, layers=False, func_name="create",
if 'soft_max' in props_data:
code.append(f" soft_max={props_data['soft_max']}, ")
if 'description' in props_data:
code.append(f" description='{props_data['description']}'")
code.append(f" description={props_data['description']!r}")
Alexander Gavrilov commented 2023-09-05 12:40:57 +02:00
Outdated
Review
Copy Link

Rather than doing '{foo}', use {repr(foo)}. Manual quoting could be barely tolerated for property names, but for the description it is simply unacceptable.

Rather than doing `'{foo}'`, use `{repr(foo)}`. Manual quoting could be barely tolerated for property names, but for the description it is simply unacceptable.
Andrej commented 2023-09-09 19:01:15 +02:00
Outdated
Review
Copy Link

that's really neat thing about repr, didn't know it can be used that way!
resolved in e2b63e1a4b

that's really neat thing about `repr`, didn't know it can be used that way! resolved in e2b63e1a4b07ffa8ca59eef5b4b2be17189f49ff
code.append(f" )")
if 'precision' in props_data:
code.append(f" pbone.id_properties_ui('{custom_property}').update(precision={props_data['precision']})")