blender/blender-addons
19
43
Fork 96
Code Issues 630 Pull Requests 27 Projects 1 Releases Wiki Activity

Fix disparity of FBX custom properties import and export #104702

Merged
Bastien Montagne merged 1 commits from Mysteryem/blender-addons:fbx_custom_prop_parity_pr into blender-v3.6-release 2023-06-21 15:52:58 +02:00
Conversation 3 Commits 1 Files Changed 2 +40 -14
Thomas Barlow commented 2023-06-18 18:02:48 +02:00
Member
Copy Link

Light, camera, bone and pose bone properties are now imported to match
the exporter behaviour.

Image custom properties are now exported to match the importer
behaviour, except for Image custom properties that are rarely imported
from a Texture Node instead of a Video Node, which are always exported
to a Video Node.

This resolves one of the issues in #104677.

Light, camera, bone and pose bone properties are now imported to match the exporter behaviour. Image custom properties are now exported to match the importer behaviour, except for Image custom properties that are rarely imported from a Texture Node instead of a Video Node, which are always exported to a Video Node. This resolves one of the issues in #104677.
❤️ 3
Thomas Barlow added 7 commits 2023-06-18 18:02:50 +02:00 
Set use_smooth to false if smooth group is zero
Added alternatively parent_name chunk wich blender can use for hierachy
Add parent from parent_name chunk if not None
Removed unused code
Cleanup
Warning not needed anymore
Fixed constrain size calculation
Fixed object instancing
Light, camera, bone and pose bone properties are now imported to match
the exporter behaviour.

Image custom properties are now exported to match the importer
behaviour, except for Image custom properties that are rarely imported
from a Texture Node instead of a Video Node, which are always exported
to a Video Node.

This resolves one of the issues in #104677.
Thomas Barlow changed title from Fix disparity of FBX custom properties import and export to Fix disparity of FBX custom properties import and export 2023-06-18 18:03:05 +02:00
Thomas Barlow changed target branch from main to blender-v3.6-release 2023-06-18 18:03:05 +02:00
Thomas Barlow requested review from Bastien Montagne 2023-06-18 19:05:12 +02:00
Brad Clark commented 2023-06-19 22:53:04 +02:00
Member
Copy Link

This could help stop so much custom jumping through hoops, custom addons to export to .json and lost data for artists not realizing this is a problem. Thank you for working on this patch.

This could help stop so much custom jumping through hoops, custom addons to export to .json and lost data for artists not realizing this is a problem. Thank you for working on this patch.
🎉 1
Bastien Montagne approved these changes 2023-06-21 15:52:26 +02:00
Bastien Montagne merged commit 716702b97e into blender-v3.6-release 2023-06-21 15:52:58 +02:00
Bastien Montagne deleted branch fbx_custom_prop_parity_pr 2023-06-21 15:52:58 +02:00
Brad Clark commented 2023-06-23 06:26:12 +02:00
Member
Copy Link

Having a second patch to support animation would be good.

Here is an older addon that was to get around the lack of it in the exporter

https://mosthostla.com/gamedev/ue4curves/

this imports the animation and exports it on at least armature level custom properties

Having a second patch to support animation would be good. Here is an older addon that was to get around the lack of it in the exporter https://mosthostla.com/gamedev/ue4curves/ this imports the animation and exports it on at least armature level custom properties
👍 1
Quoia Shade commented 2023-07-12 01:38:16 +02:00
First-time contributor
Copy Link

Having a second patch to support animation would be good.

Seconded - I imagine it'd be a bit more work than the much appreciated import-export-parity patch, but it'd also make those now-better-supported properties substantially more useful (there's a LOT more you can do with animated properties than just static ones).

> Having a second patch to support animation would be good. Seconded - I imagine it'd be a bit more work than the much appreciated import-export-parity patch, but it'd also make those now-better-supported properties _substantially_ more useful (there's a LOT more you can do with animated properties than just static ones).
👍 1
Sign in to join this conversation.
Reviewers
No reviewers
Bastien Montagne
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#104702
No description provided.
Delete Branch "Mysteryem/blender-addons:fbx_custom_prop_parity_pr"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?