Fix disparity of FBX custom properties import and export #104702

Thomas Barlow · 2023-06-18T18:02:48+02:00

Thomas Barlow commented

2023-06-18 18:02:48 +02:00

Light, camera, bone and pose bone properties are now imported to match
the exporter behaviour.

Image custom properties are now exported to match the importer
behaviour, except for Image custom properties that are rarely imported
from a Texture Node instead of a Video Node, which are always exported
to a Video Node.

This resolves one of the issues in #104677.

Light, camera, bone and pose bone properties are now imported to match the exporter behaviour. Image custom properties are now exported to match the importer behaviour, except for Image custom properties that are rarely imported from a Texture Node instead of a Video Node, which are always exported to a Video Node. This resolves one of the issues in #104677.

❤️ 3

Thomas Barlow added 7 commits 2023-06-18 18:02:50 +02:00

6d410838ba Import_3ds: Fixed use_smooth boolean

Set use_smooth to false if smooth group is zero

7dc3c7426c Import_3ds: Added parent chunk

Added alternatively parent_name chunk wich blender can use for hierachy

9c6e3b9b0a Import_3ds: Added parent name chunk

Add parent from parent_name chunk if not None

ae747c9498 Import_3ds: Code cleanup

Removed unused code
Cleanup

a046bdcce1 Import_3ds: Removed warning in parenting

Warning not needed anymore

4940dbf439 Import_3ds: Fixed constrain size and object instances

Fixed constrain size calculation
Fixed object instancing

ced1d46fb0 Fix disparity of FBX custom properties import and export

Light, camera, bone and pose bone properties are now imported to match
the exporter behaviour.

Image custom properties are now exported to match the importer
behaviour, except for Image custom properties that are rarely imported
from a Texture Node instead of a Video Node, which are always exported
to a Video Node.

This resolves one of the issues in #104677.

Thomas Barlow changed title from ~~Fix disparity of FBX custom properties import and export~~ to Fix disparity of FBX custom properties import and export

2023-06-18 18:03:05 +02:00

Mysteryem changed target branch from main to blender-v3.6-release

2023-06-18 18:03:05 +02:00

Thomas Barlow requested review from Bastien Montagne 2023-06-18 19:05:12 +02:00

Brad Clark commented

2023-06-19 22:53:04 +02:00

This could help stop so much custom jumping through hoops, custom addons to export to .json and lost data for artists not realizing this is a problem. Thank you for working on this patch.

🎉 1

Bastien Montagne approved these changes 2023-06-21 15:52:26 +02:00

Bastien Montagne merged commit 716702b97e into blender-v3.6-release

2023-06-21 15:52:58 +02:00

Bastien Montagne deleted branch fbx_custom_prop_parity_pr

2023-06-21 15:52:58 +02:00

Bastien Montagne referenced this issue from a commit

2023-06-21 15:52:59 +02:00

Fix disparity of FBX custom properties import and export

Brad Clark commented

2023-06-23 06:26:12 +02:00

Having a second patch to support animation would be good.

Here is an older addon that was to get around the lack of it in the exporter

https://mosthostla.com/gamedev/ue4curves/

this imports the animation and exports it on at least armature level custom properties

Having a second patch to support animation would be good. Here is an older addon that was to get around the lack of it in the exporter https://mosthostla.com/gamedev/ue4curves/ this imports the animation and exports it on at least armature level custom properties

👍 1

Quoia Shade commented

2023-07-12 01:38:16 +02:00

First-time contributor

Having a second patch to support animation would be good.

Seconded - I imagine it'd be a bit more work than the much appreciated import-export-parity patch, but it'd also make those now-better-supported properties substantially more useful (there's a LOT more you can do with animated properties than just static ones).

> Having a second patch to support animation would be good. Seconded - I imagine it'd be a bit more work than the much appreciated import-export-parity patch, but it'd also make those now-better-supported properties _substantially_ more useful (there's a LOT more you can do with animated properties than just static ones).

👍 1

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix disparity of FBX custom properties import and export #104702