blender
/
blender-addons
17
34
Fork 93
Code Issues 522 Pull Requests 32 Projects 1 Releases Wiki Activity

Extra objects: Fix TypeError when torus knot added #104810

Merged
Pratik Borhade merged 1 commits from Patrick-White-4/blender-addons:patrick-white-4-patch-2 into main 2023-08-01 13:41:13 +02:00
Conversation 1 Commits 1 Files Changed 1 +1 -1
Patrick-White-4 commented 2023-08-01 06:29:05 +02:00
Contributor
Copy Link

TypeError is thrown when torus knot + object added with 7*6 preset.
torus_res is an IntProperty, and after python 3.10, implicit conversion
from float to int is not happening. To fix this, cast division value explicitly
to int

TypeError is thrown when `torus knot +` object added with `7*6` preset. `torus_res` is an IntProperty, and after python 3.10, implicit conversion from float to int is not happening. To fix this, cast division value explicitly to int
Patrick-White-4 added 1 commit 2023-08-01 06:29:08 +02:00
a7d6b1b194 Fix Torus Knots exceptions by using int 
torus_res is an IntProperty, as the exception so helpfully pointed out :)
To repro, enable the extra curves, add a torus, and pick 7x6.
Pratik Borhade changed title from Fix Torus Knots exceptions by using int to Extra objects: Fix TypeError when torus knot added 2023-08-01 13:38:04 +02:00
Pratik Borhade approved these changes 2023-08-01 13:38:33 +02:00
Pratik Borhade left a comment
Member
Copy Link

Thanks for the PR. Looks correct to me :D

Thanks for the PR. Looks correct to me :D
Pratik Borhade commented 2023-08-01 13:39:13 +02:00
Member
Copy Link

Edited the title and PR description to explain exact issue and fix

Edited the title and PR description to explain exact issue and fix
Pratik Borhade merged commit 08ec3386cd into main 2023-08-01 13:41:13 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Pratik Borhade
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#104810
No description provided.
Delete Branch "Patrick-White-4/blender-addons:patrick-white-4-patch-2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?