add filtering to window manager to only show folders and images since this is what the user wants to see when using this addon #104845

Daniel Grauer · 2023-08-22T18:57:35+02:00

Daniel Grauer commented

2023-08-22 18:57:35 +02:00

Filter for relevant files (Folders and Images) to show the user only what is relevant for this addon.

Filter for relevant files (Folders and Images) to show the user only what is relevant for this addon. ![image](/attachments/07d24e3b-4115-4384-ae81-c71b2ce636ea)

image.png

55 KiB

Daniel Grauer added the

Interest

Import and Export

label 2023-08-22 18:57:35 +02:00

Daniel Grauer force-pushed brushset-import-filter-files from f37dd3f1e2 to f3bd9e4d58

2023-09-17 15:02:49 +02:00

Compare

Germano Cavalcante commented

2023-09-18 16:19:43 +02:00

Sounds like a good idea, thanks for the work.

I noticed you're one of the authors of the add-on, so perhaps this PR doesn't require a thorough code review.

However, is the boolean "set_default_filters" becoming a new property of the exporter? If so, I believe you might be adding too much. It might be better to keep the filters as defaults without additional options.

Sounds like a good idea, thanks for the work. I noticed you're one of the authors of the add-on, so perhaps this PR doesn't require a thorough code review. However, is the boolean "set_default_filters" becoming a new property of the exporter? If so, I believe you might be adding too much. It might be better to keep the filters as defaults without additional options.

Daniel Grauer commented

2023-09-24 13:05:03 +02:00

Sounds like a good idea, thanks for the work.

I noticed you're one of the authors of the add-on, so perhaps this PR doesn't require a thorough code review.

However, is the boolean "set_default_filters" becoming a new property of the exporter? If so, I believe you might be adding too much. It might be better to keep the filters as defaults without additional options.

Thanks for the review, the reason for set_default_filters is that the users filters are not overwritten for all the other imports& exports.
Maybe there is a different way to do that?
Also i should probably add a bit of documentation to that part and think about a better name for the property.

> Sounds like a good idea, thanks for the work. > > I noticed you're one of the authors of the add-on, so perhaps this PR doesn't require a thorough code review. > > However, is the boolean "set_default_filters" becoming a new property of the exporter? If so, I believe you might be adding too much. It might be better to keep the filters as defaults without additional options. Thanks for the review, the reason for **set_default_filters** is that the users filters are not overwritten for all the other imports& exports. Maybe there is a different way to do that? Also i should probably add a bit of documentation to that part and think about a better name for the property.

Germano Cavalcante commented

2023-09-25 18:16:56 +02:00

Do you think it's worth bumping version to (1, 3, 1)?
(This way we can better track possible issues).

Do you think it's worth bumping version to (1, 3, 1)? (This way we can better track possible issues).

Daniel Grauer added 2 commits 2023-09-25 21:44:53 +02:00

9c768a042a increase brush set addon verison

5c82729445 Rename property and adding documentation to clarify what it is used for.

Daniel Grauer commented

2023-09-25 21:47:03 +02:00

Do you think it's worth bumping version to (1, 3, 1)?
(This way we can better track possible issues).

I increased the version , renamed the property and added a little documentation to indicate that this is a temporary filter.

> Do you think it's worth bumping version to (1, 3, 1)? > (This way we can better track possible issues). I increased the version , renamed the property and added a little documentation to indicate that this is a temporary filter.

Germano Cavalcante merged commit d4f1a5d7e1 into main

2023-09-25 22:06:29 +02:00

Germano Cavalcante referenced this issue from a commit

2023-09-25 22:06:30 +02:00

Import BrushSet: add filtering to only show folders and images

Sign in to join this conversation.

No reviewers