blender/blender-addons
19
43
Fork 96
Code Issues 634 Pull Requests 27 Projects 1 Releases Wiki Activity

Fix #104865: Adjust Node Wrangler for node socket interface API changes #104882

Merged
Jesse Yurkovich merged 1 commits from deadpin/blender-addons:fix104865-2 into main 2023-09-14 06:23:45 +02:00
Conversation 4 Commits 1 Files Changed 2 +43 -41
Jesse Yurkovich commented 2023-09-12 22:14:05 +02:00
Member
Copy Link

Fix #104865: Adjust Node Wrangler for node socket interface API changes

This uses the new node tree socket interface APIs as appropriate when
triggering the temporary viewer in both shader and geometry nodes.

Getting this to work when inside NodeGroups was particularly confusing due to the difference between a Node's sockets and a NodeTree's socket-interface definitions.

Things seem to work well in my testing but, honestly, the more I look at my patch the less I'm sure it's covering everything it needs to correctly.

Fix #104865: Adjust Node Wrangler for node socket interface API changes This uses the new node tree socket interface APIs as appropriate when triggering the temporary viewer in both shader and geometry nodes. ---- Getting this to work when inside NodeGroups was particularly confusing due to the difference between a Node's sockets and a NodeTree's socket-interface definitions. Things seem to work well in my testing but, honestly, the more I look at my patch the less I'm sure it's covering everything it needs to correctly.
Jesse Yurkovich added 1 commit 2023-09-12 22:14:08 +02:00
Jesse Yurkovich commented 2023-09-12 22:16:54 +02:00
Author
Member
Copy Link

@pioverfour @HooglyBoogly Here's the second Node Wrangler patch which should now complete the fix for 104865. It deals with the Temporary Viewer aspect in both shader and geometry nodes. Hans, feel free to add Lukas and bail if you think that's best.

@pioverfour @HooglyBoogly Here's the second Node Wrangler patch which should now complete the fix for 104865. It deals with the Temporary Viewer aspect in both shader and geometry nodes. Hans, feel free to add Lukas and bail if you think that's best.
Damien Picard commented 2023-09-13 12:02:51 +02:00
Member
Copy Link

Thanks!
I can’t look at the code just now, but I have a general question: I don’t see the API change mentioned in the release notes, does that mean the API is not yet stable, or the change simply hasn’t been documented yet? And should we wait a bit before fixing add-ons?

Thanks! I can’t look at the code just now, but I have a general question: I don’t see the API change mentioned in [the release notes](https://wiki.blender.org/wiki/Reference/Release_Notes/4.0/Python_API), does that mean the API is not yet stable, or the change simply hasn’t been documented yet? And should we wait a bit before fixing add-ons?
Hans Goudey approved these changes 2023-09-13 19:29:29 +02:00
Jesse Yurkovich commented 2023-09-13 20:43:13 +02:00
Author
Member
Copy Link

I can’t look at the code just now, but I have a general question: I don’t see the API change mentioned in the release notes, does that mean the API is not yet stable, or the change simply hasn’t been documented yet? And should we wait a bit before fixing add-ons?

I think it just hasn't been documented yet. Though if folks end up finding something egregious I would imagine the API could change to fix it but I don't know of any pending updates.

I'll hold off committing until you have a chance to take a look.

> I can’t look at the code just now, but I have a general question: I don’t see the API change mentioned in [the release notes](https://wiki.blender.org/wiki/Reference/Release_Notes/4.0/Python_API), does that mean the API is not yet stable, or the change simply hasn’t been documented yet? And should we wait a bit before fixing add-ons? I think it just hasn't been documented yet. Though if folks end up finding something egregious I would imagine the API could change to fix it but I don't know of any pending updates. I'll hold off committing until you have a chance to take a look.
👍 1
Damien Picard commented 2023-09-14 01:07:51 +02:00
Member
Copy Link

I had a look and tested a bit, I’m not very familiar with Node Wrangler’s code but I couldn’t find anything wrong with this. :)

I had a look and tested a bit, I’m not very familiar with Node Wrangler’s code but I couldn’t find anything wrong with this. :)
Jesse Yurkovich merged commit b022a26568 into main 2023-09-14 06:23:45 +02:00
Jesse Yurkovich deleted branch fix104865-2 2023-09-14 06:23:47 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Hans Goudey
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#104882
No description provided.
Delete Branch "deadpin/blender-addons:fix104865-2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?