blender/blender-addons
19
43
Fork 96
Code Issues 630 Pull Requests 27 Projects 1 Releases Wiki Activity

FBX IO: Fix Empty export type control also affecting armatures #104887

Merged
Thomas Barlow merged 3 commits from Mysteryem/blender-addons:fbx_fix_armature_data_export_type into main 2023-09-19 01:32:26 +02:00
Conversation 1 Commits 3 Files Changed 2 +10 -4
Thomas Barlow commented 2023-09-15 01:36:30 +02:00
Member
Copy Link

The exported type of the NodeAttribute for Empty Objects can be
controlled using a custom property called 'fbx_type' on the Object. This
feature was also being applied to Armature Objects because they use the
same function for exporting their NodeAttribute.

A check has now been added such that the exported type can only be
changed by the 'fbx_type' custom property when the Object is an Empty.

The exported type of the NodeAttribute for Empty Objects can be controlled using a custom property called 'fbx_type' on the Object. This feature was also being applied to Armature Objects because they use the same function for exporting their NodeAttribute. A check has now been added such that the exported type can only be changed by the 'fbx_type' custom property when the Object is an Empty.
Thomas Barlow added 1 commit 2023-09-15 01:36:33 +02:00 
The NodeAttribute for Empty Objects can be controlled using a custom
property called 'fbx_type' on the Object. This feature was also being
applied to Armature Objects because they use the same function for
exporting their NodeAttribute.

A check has now been added such that the exported type can only be
changed when the Object is an Empty.
Thomas Barlow commented 2023-09-15 04:56:02 +02:00
Author
Member
Copy Link

This was something I noticed while working on !104888.

I do wonder if we should also be setting the 'fbx_type' of each armature NodeAttribute to match the "Armature FBXNode Type". Currently this option only affects each armature Node.

I don't know enough about this area of FBX yet to make a reasonable guess without thoroughly testing it.
image

This was something I noticed while working on !104888. --- I do wonder if we should also be setting the 'fbx_type' of each armature NodeAttribute to match the "Armature FBXNode Type". Currently this option only affects each armature Node. I don't know enough about this area of FBX yet to make a reasonable guess without thoroughly testing it. ![image](/attachments/5945a142-235b-408b-a582-6fda653a46d0)
image.png
18 KiB
Thomas Barlow changed title from FBX IO: Fix custom property control of armature NodeAttribute export type to FBX IO: Fix Empty export type control also affecting armatures 2023-09-15 05:01:08 +02:00
Thomas Barlow requested review from Bastien Montagne 2023-09-15 05:05:22 +02:00
Bastien Montagne approved these changes 2023-09-18 12:08:54 +02:00
Bastien Montagne left a comment
Owner
Copy Link

I wonder if this (also using that setting for armature nodes) was not done on purpose... But I agree that this should not be the case anyway, better keep Empty and Armture cases clearly separated here.

I wonder if this (also using that setting for armature nodes) was not done on purpose... But I agree that this should not be the case anyway, better keep Empty and Armture cases clearly separated here.
Thomas Barlow added 2 commits 2023-09-19 01:29:08 +02:00
Thomas Barlow merged commit fbcdfa34b9 into main 2023-09-19 01:32:26 +02:00
Thomas Barlow deleted branch fbx_fix_armature_data_export_type 2023-09-19 01:32:26 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Bastien Montagne
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#104887
No description provided.
Delete Branch "Mysteryem/blender-addons:fbx_fix_armature_data_export_type"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?