blender/blender-addons
19
43
Fork 96
Code Issues 629 Pull Requests 27 Projects 1 Releases Wiki Activity

UI: Update Theme Presets for blender/blender#111431 #104912

Merged
Pablo Vazquez merged 6 commits from Gilberto.R/blender-addons:temp-thpresetsv3d into main 2024-01-17 16:27:35 +01:00
Conversation 9 Commits 6 Files Changed 6 +20 -9
Gilberto Rodrigues commented 2023-09-24 10:31:12 +02:00
Contributor
Copy Link

Update theme presets for the "improve edge highlight" PR ( blender/blender#111431 ).
To test the presets, drop the files to the build folder on \4.1\scripts\addons\presets\interface_theme .

Update theme presets for the "improve edge highlight" PR ( https://projects.blender.org/blender/blender/pulls/111431 ). To test the presets, drop the files to the build folder on \4.1\scripts\addons\presets\interface_theme .
interface_theme.rar
38 KiB
❤️ 1
Gilberto Rodrigues added 1 commit 2023-09-24 10:31:15 +02:00
Gilberto Rodrigues requested review from Pablo Vazquez 2023-09-24 10:35:00 +02:00
Gilberto Rodrigues requested review from Campbell Barton 2023-09-24 10:35:00 +02:00
Gilberto Rodrigues requested review from Julien Kaspar 2023-09-24 10:35:01 +02:00
Gilberto Rodrigues added 1 commit 2023-09-27 02:09:24 +02:00
Julien Kaspar requested changes 2023-10-11 11:25:46 +02:00
Julien Kaspar left a comment
Member
Copy Link

I had a look at the changed themes in comparison to the current ones.
Only a couple of issues.

The faces are using the darker theme from face mode on on vertex & edge mode. Previously this was only in face mode.
This is an issue with Minimal Dark, Modo and XSI. For XSI the faces are for some reason much stronger grey than before.

The vertex & edge mode in XSI doesn't use the same red hue as before.

I had a look at the changed themes in comparison to the current ones. Only a couple of issues. The faces are using the darker theme from face mode on on vertex & edge mode. Previously this was only in face mode. This is an issue with Minimal Dark, Modo and XSI. For XSI the faces are for some reason much stronger grey than before. The vertex & edge mode in XSI doesn't use the same red hue as before.
Gilberto Rodrigues added 1 commit 2023-10-12 23:10:06 +02:00
Gilberto Rodrigues commented 2023-10-13 00:51:11 +02:00
Author
Contributor
Copy Link

@JulienKaspar Thank you for taking a look.
I can't understand the first issue. Could you clarify it for me? I think it is a weaker gray on the updated because I lowered the alpha of "Face" color.

On the the XSI theme, the unselected edge color is yellow so the hue shift would make selected edges look unselected by shifting their red to yellow, and a hue shift the other way would be pink, which imo doesn't fit the XSI theme. So I tried to mostly to change the brightness instead, and left the original edge colors on edge mode and face mode, with the inactive looking more dull.

On the Minimal Dark theme, a hue shift from light blue to green would make it look too similar to the active color of that theme, and a shift to purple would not fit the theme. So I tried to do a more subtle color change which in my opinion looks good and fits the theme.

@JulienKaspar Thank you for taking a look. I can't understand the first issue. Could you clarify it for me? I think it is a weaker gray on the updated because I lowered the alpha of "Face" color. On the the XSI theme, the unselected edge color is yellow so the hue shift would make selected edges look unselected by shifting their red to yellow, and a hue shift the other way would be pink, which imo doesn't fit the XSI theme. So I tried to mostly to change the brightness instead, and left the original edge colors on edge mode and face mode, with the inactive looking more dull. On the Minimal Dark theme, a hue shift from light blue to green would make it look too similar to the active color of that theme, and a shift to purple would not fit the theme. So I tried to do a more subtle color change which in my opinion looks good and fits the theme.
Gilberto Rodrigues requested review from Julien Kaspar 2023-10-18 00:53:08 +02:00
Gilberto Rodrigues added 1 commit 2023-10-20 01:21:19 +02:00
Gilberto Rodrigues added 1 commit 2023-11-19 01:51:59 +01:00
Julien Kaspar commented 2023-11-27 13:09:11 +01:00
Member
Copy Link

SOrry for the wait. I made some comparative screenshots of all 3 selection modes across the themes that don't look right.
The Modo theme seems to be ok but the others are strikingly different.

The colors generally don't seem to match the old themes. Sometimes even just plain copying the default colors. Not sure if I'm doing something wrong?
The face colors are also generally very different between face selection mode and the others.

SOrry for the wait. I made some comparative screenshots of all 3 selection modes across the themes that don't look right. The Modo theme seems to be ok but the others are strikingly different. The colors generally don't seem to match the old themes. Sometimes even just plain copying the default colors. Not sure if I'm doing something wrong? The face colors are also generally very different between face selection mode and the others.
theme_minimal_old.png
267 KiB
theme_maya_new.png
312 KiB
theme_modo_old.png
262 KiB
theme_xsi_old.png
280 KiB
theme_maya_old.png
308 KiB
theme_xsi_new.png
299 KiB
theme_minimal_new.png
288 KiB
theme_modo_new.png
272 KiB
theme_minimal_old.png theme_maya_new.png theme_modo_old.png theme_xsi_old.png theme_maya_old.png theme_xsi_new.png theme_minimal_new.png theme_modo_new.png
Julien Kaspar commented 2023-11-27 13:13:22 +01:00
Member
Copy Link

Ok I see that the applied PR on my system are different from the themes in the description. But all are very different from the 3.6 themes ...

Ok I see that the applied PR on my system are different from the themes in the description. But all are very different from the 3.6 themes ...
Julien Kaspar commented 2023-11-28 10:08:25 +01:00
Member
Copy Link

A regression is that the face theme is only applied onto face selection mode and in all the others it's off.

The Minimal and XSI theme of the other themes seem to have been made to always use a strong face theme color in edit mode, which is no longer possible.

A regression is that the face theme is only applied onto face selection mode and in all the others it's off. The Minimal and XSI theme of the other themes seem to have been made to always use a strong face theme color in edit mode, which is no longer possible.
Julien Kaspar commented 2023-11-28 10:08:25 +01:00
Member
Copy Link

A regression is that the face theme is only applied onto face selection mode and in all the others it's off.

The Minimal and XSI theme of the other themes seem to have been made to always use a strong face theme color in edit mode, which is no longer possible.

A regression is that the face theme is only applied onto face selection mode and in all the others it's off. The Minimal and XSI theme of the other themes seem to have been made to always use a strong face theme color in edit mode, which is no longer possible.
Julien Kaspar commented 2023-11-28 10:08:25 +01:00
Member
Copy Link

A regression is that the face theme is only applied onto face selection mode and in all the others it's off.

The Minimal and XSI theme seem to have been made to always use a strong face theme color in edit mode, which is no longer possible.

A regression is that the face theme is only applied onto face selection mode and in all the others it's off. The Minimal and XSI theme seem to have been made to always use a strong face theme color in edit mode, which is no longer possible.
Gilberto Rodrigues commented 2023-11-29 05:19:06 +01:00
Author
Contributor
Copy Link

The functionality is already merged to main, but the updated theme presets aren't merged yet, so to test this you need to copy the updated theme presets to \4.1\scripts\addons\presets\interface_theme to replace the old theme presets, or it will load the default colors because those colors aren't set on the old presets. So, without the updated presets you will get the wrong face color.

Step by step to test the updated theme presets:

  • Download the latest 4.1 build on builder.blender.org ;
  • Download the updated theme presets from this task (interface_theme.rar);
  • Move and extract them to the build folder under \4.1\scripts\addons\presets\interface_theme ;
The functionality is already merged to main, but the updated theme presets aren't merged yet, so to test this you need to copy the updated theme presets to \4.1\scripts\addons\presets\interface_theme to replace the old theme presets, or it will load the default colors because those colors aren't set on the old presets. So, without the updated presets you will get the wrong face color. Step by step to test the updated theme presets: - Download the latest 4.1 build on builder.blender.org ; - Download the updated theme presets from this task (interface_theme.rar); - Move and extract them to the build folder under \4.1\scripts\addons\presets\interface_theme ;
interface_theme.rar
38 KiB
Gilberto Rodrigues commented 2023-11-29 05:51:17 +01:00
Author
Contributor
Copy Link

Here is how it should look

Here is how it should look
minimaldark-new.png
155 KiB
maya-new.png
382 KiB
minimaldark-new.png maya-new.png
❤️ 1
Julien Kaspar commented 2023-11-29 13:24:41 +01:00
Member
Copy Link

Ah I don't know why this didn't work on my end.
It's working now. Thanks!

Overall looks good. The Maya theme looks very different but tbh much closer to Maya.

Only one suggestion:
Change "Edge Selection" on XSI theme to #FFA000.
It will look much closer to XSI and how it was in 3.6. It also improves edge readability on face selection mode.

I still think the lacking face theme color in edge and vertex selection modes is a regression but I'm fine with looking at that seperately with Jonathan Lampel (especially because it affects the Minimal Dark theme)

Ah I don't know why this didn't work on my end. It's working now. Thanks! Overall looks good. The Maya theme looks very different but tbh much closer to Maya. Only one suggestion: Change "Edge Selection" on XSI theme to #FFA000. It will look much closer to XSI and how it was in 3.6. It also improves edge readability on face selection mode. I still think the lacking face theme color in edge and vertex selection modes is a regression but I'm fine with looking at that seperately with Jonathan Lampel (especially because it affects the Minimal Dark theme)
👍 1
Gilberto Rodrigues added 1 commit 2023-11-30 07:27:02 +01:00
Julien Kaspar approved these changes 2023-11-30 10:49:14 +01:00
Julien Kaspar left a comment
Member
Copy Link

Themes look good to me.

Themes look good to me.
❤️ 1
Gilberto Rodrigues changed title from Update theme presets for "improve edge highlight" PR to UI: Update Theme Presets for #111431 2023-12-04 14:33:14 +01:00
Gilberto Rodrigues changed title from UI: Update Theme Presets for #111431 to UI: Update Theme Presets for blender/blender#111431 2023-12-04 14:33:47 +01:00
Pablo Vazquez reviewed 2024-01-16 11:35:22 +01:00
presets/interface_theme/Maya.xml
@ -371,3 +371,3 @@
vertex_select="#ffea00"
vertex_active="#ffffff"
vertex_size="2"
vertex_size="4"
Pablo Vazquez commented 2024-01-16 11:35:22 +01:00
Member
Copy Link

Curious why setting this specific theme to vertex size 4? The default is 3 for all themes.

Curious why setting this specific theme to vertex size 4? The default is 3 for all themes.
pablovazquez marked this conversation as resolved
Pablo Vazquez merged commit e7d6a8f3a4 into main 2024-01-17 16:27:35 +01:00
Pablo Vazquez deleted branch temp-thpresetsv3d 2024-01-17 16:27:35 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Pablo Vazquez
Campbell Barton
Julien Kaspar
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#104912
No description provided.
Delete Branch "Gilberto.R/blender-addons:temp-thpresetsv3d"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?