Fix Add Camera Rigs after 4.0 API changes #104919

Wayne Dixon · 2023-09-27T09:20:17+02:00

Wayne Dixon commented

2023-09-27 09:20:17 +02:00

This pull request updates the 'add camera rigs' addon to use bone collections for the 4.0 release.
It also adjusts some of the naming convention to match the Rigify.

This pull request updates the 'add camera rigs' addon to use bone collections for the 4.0 release. It also adjusts some of the naming convention to match the Rigify.

Wayne Dixon added 1 commit 2023-09-27 09:20:21 +02:00

update to use bone collections, cleaned up the naming convention to match rigify 62fa4dbe2a

Signed-off-by: Wayne Dixon <thewaylow@gmail.com>

Wayne Dixon requested review from Damien Picard 2023-09-27 09:21:23 +02:00

Damien Picard commented

2023-09-27 12:03:43 +02:00

Hi Wayne, thanks!
This generally looks good to me, with two issues:

there is a crash when creating a crane rig. Here is a fix:

@@ -127,11 +127,11 @@ def create_crane_bones(rig):
     ctrl.parent = arm
     ctrl_offset.parent = ctrl
     ctrl.use_inherit_rotation = False
-    ctrl.use_inherit_scale = False
+    ctrl.inherit_scale = "NONE"
     ctrl.show_wire = True
 
     arm.parent = height
-    arm.use_inherit_scale = False
+    arm.inherit_scale = "NONE"
 
     height.parent = root
     ctrl_aim.parent = root

Of course it’s your call but I’m not too fond of the change of names to "_RIG", I find uppercase to be too strong and it’s not used elsewhere AFAIK.

Hi Wayne, thanks! This generally looks good to me, with two issues: 1. there is a crash when creating a crane rig. Here is a fix: ```diff @@ -127,11 +127,11 @@ def create_crane_bones(rig): ctrl.parent = arm ctrl_offset.parent = ctrl ctrl.use_inherit_rotation = False - ctrl.use_inherit_scale = False + ctrl.inherit_scale = "NONE" ctrl.show_wire = True arm.parent = height - arm.use_inherit_scale = False + arm.inherit_scale = "NONE" height.parent = root ctrl_aim.parent = root ``` 2. Of course it’s your call but I’m not too fond of the change of names to "_RIG", I find uppercase to be too strong and it’s not used elsewhere AFAIK.

Wayne Dixon added 1 commit 2023-09-27 12:39:46 +02:00

Fix inherit_scale on crane. Adjust naming "_Rig" 0a34f26338

Wayne Dixon commented

2023-09-27 12:45:54 +02:00

No Problem.
I think I fixed those two things and pushed to the same branch. The documentation says those changes will automatically be applied to this pull request. I hope that is correct.

I changed the name of the rig object to title case, ie "_Rig".

Let me know if these changes are correct.

No Problem. I think I fixed those two things and pushed to the same branch. The documentation says those changes will automatically be applied to this pull request. I hope that is correct. I changed the name of the rig object to title case, ie "_Rig". Let me know if these changes are correct.

Damien Picard commented

2023-09-27 12:58:03 +02:00

The documentation says those changes will automatically be applied to this pull request. I hope that is correct.

Exactly!

I changed the name of the rig object to title case, ie "_Rig".

Thanks :)

Let me know if these changes are correct.

Looks good to me.

About the pull request itself, it should be named to describe the changes, e. g. “Fix Add Camera Rigs after 4.0 API changes”.

AFAIK there is no need for a “Signed-off-by” line in the commits. If you want you can edit the description of the PR, and this will be used as a commit message when the PR is merged and all the commits are squashed into one.

Also, this can’t be merged into the main branch right now, because just today the next phase of development has started, so a 4.0 branch was created. This means you must change the destination branch to blender-v4.0-release by editing the PR (Edit button to the right of the title, at the top of the page)

> The documentation says those changes will automatically be applied to this pull request. I hope that is correct. Exactly! > I changed the name of the rig object to title case, ie "_Rig". Thanks :) > Let me know if these changes are correct. Looks good to me. About the pull request itself, it should be named to describe the changes, e. g. “Fix Add Camera Rigs after 4.0 API changes”. AFAIK there is no need for a “Signed-off-by” line in the commits. If you want you can edit the description of the PR, and this will be used as a commit message when the PR is merged and all the commits are squashed into one. Also, this can’t be merged into the `main` branch right now, because just today the next phase of development has started, so a 4.0 branch was created. This means you must change the destination branch to `blender-v4.0-release` by editing the PR (Edit button to the right of the title, at the top of the page)

Wayne Dixon changed title from ~~Update Add Camera Rigs Addon~~ to Fix Add Camera Rigs after 4.0 API changes

2023-09-27 13:00:35 +02:00

Wayne Dixon changed title from ~~Fix Add Camera Rigs after 4.0 API changes~~ to Fix Add Camera Rigs after 4.0 API changes

2023-09-27 13:01:22 +02:00

Wayne Dixon changed target branch from main to blender-v4.0-release

2023-09-27 13:01:23 +02:00

Wayne Dixon commented

2023-09-27 13:04:08 +02:00

I edited the title and description plus changed the merge target branch.

Thanks Damien.

I edited the title and description plus changed the merge target branch. Thanks Damien.

Damien Picard commented