FBX IO: Speed up cluster export: Remove unused sorting #104922

Thomas Barlow · 2023-09-29T19:36:56+02:00

Thomas Barlow commented

2023-09-29 19:36:56 +02:00

Sorting the weights and vertex group indices on each vertex was added in
a47e870349 as part of an option to limit the maximum number of exported
weights per vertex. This feature was later removed, but the extra code
that added the sorting was not.

This patch removes the sorting because it is not needed and is quite
expensive. Setting all the weights and indices into vgroups now runs
in about 40% of the original time.

The overall speedup from this patch depends very much on what data other
than the clusters needs exporting, but I get a reduction in total export
time between 7.5% and 15% for non-animated humanoid character models.

I think this should be ok going into 4.0 because it's only removing old code that should have been removed a long time ago.

Sorting the weights and vertex group indices on each vertex was added in a47e870349 as part of an option to limit the maximum number of exported weights per vertex. This feature was later removed, but the extra code that added the sorting was not. This patch removes the sorting because it is not needed and is quite expensive. Setting all the weights and indices into `vgroups` now runs in about 40% of the original time. The overall speedup from this patch depends very much on what data other than the clusters needs exporting, but I get a reduction in total export time between 7.5% and 15% for non-animated humanoid character models. --- I think this should be ok going into 4.0 because it's only removing old code that should have been removed a long time ago.

Thomas Barlow added 1 commit 2023-09-29 19:36:59 +02:00

cc166e3039 FBX IO: Speed up cluster export: Remove unused sorting

Sorting the weights and vertex group indices on each vertex was added in
a47e870349 as part of an option to limit the maximum number of exported
weights per vertex. This feature was later removed, but the extra code
that added the sorting was not.

This patch removes the sorting because it is not needed and is quite
expensive. Setting all the weights and indices into `vgroups` now runs
in about 40% of the original time.

The overall speedup from this patch depends very much on what data other
than the clusters needs exporting, but I get a reduction in total export
time between 7.5% and 15% for non-animated humanoid character models.

Thomas Barlow requested review from Bastien Montagne 2023-09-29 19:37:26 +02:00

Bastien Montagne approved these changes 2023-10-03 18:18:53 +02:00

Bastien Montagne left a comment

LGTM.

Thomas Barlow added 2 commits 2023-10-06 04:26:17 +02:00

62ae0da164 Merge branch 'blender-v4.0-release' into fbx_cluster_export_speedup

844b22d7f0 Increase FBX IO Version

Thomas Barlow merged commit 63d4898e1d into blender-v4.0-release

2023-10-06 04:41:47 +02:00

Thomas Barlow deleted branch fbx_cluster_export_speedup

2023-10-06 04:41:48 +02:00

Thomas Barlow referenced this issue from a commit

2023-10-06 04:41:49 +02:00

FBX IO: Speed up cluster export: Remove unused sorting

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

FBX IO: Speed up cluster export: Remove unused sorting #104922