Fix incorrect merged weights from ignored bones in FBX import #104928

Thomas Barlow · 2023-10-01T02:14:08+02:00

Thomas Barlow commented

2023-10-01 02:14:08 +02:00

Given a chain of bones A -> B -> C and a vertex weighted to all three
bones: When C is ignored and its weight is to be merged into its parent
B, the sum of the weights that are not A should remain the same as
before the merge. The current code is instead setting the B weight to
the average of the B and C weights, which does not maintain the sum of
the weights. The division that was creating the average has been
removed, so now the weights in C to be merged into B are added directly
to the B weight.

Because the maximum value a weight can be set to is 1.0, this poses a
problem when the weights to be added together exceed 1.0. Re-normalizing
all the weights on the vertex in this case sounds like it could work,
but unfortunately, we only have access to all the weights for one bone
at a time with the current implementation. Re-normalizing the weights
after adding all the weights to each vertex is too late because the
weights exceeding 1.0 would already have been clamped to 1.0. A comment
has been added to indicate that this is a known issue.

This weight merging feature is probably unlikely to have seen much use because the only ignored bones that could have their weights merged are the imported end bones when using the Armature>Ignore Leaf Bones option of the importer.

Examples showing one import with Armature>Ignore Leaf Bones enabled and one import with default settings. Then with the 'B' bone rotated:

Before	After

Given a chain of bones A -> B -> C and a vertex weighted to all three bones: When C is ignored and its weight is to be merged into its parent B, the sum of the weights that are not A should remain the same as before the merge. The current code is instead setting the B weight to the average of the B and C weights, which does not maintain the sum of the weights. The division that was creating the average has been removed, so now the weights in C to be merged into B are added directly to the B weight. Because the maximum value a weight can be set to is 1.0, this poses a problem when the weights to be added together exceed 1.0. Re-normalizing all the weights on the vertex in this case sounds like it could work, but unfortunately, we only have access to all the weights for one bone at a time with the current implementation. Re-normalizing the weights after adding all the weights to each vertex is too late because the weights exceeding 1.0 would already have been clamped to 1.0. A comment has been added to indicate that this is a known issue. --- This weight merging feature is probably unlikely to have seen much use because the only ignored bones that could have their weights merged are the imported end bones when using the `Armature`>`Ignore Leaf Bones` option of the importer. Examples showing one import with `Armature`>`Ignore Leaf Bones` enabled and one import with default settings. Then with the 'B' bone rotated: | Before | After | | -- | -- | | ![image](/attachments/c5597eb0-dd2b-4bed-a393-ed58f79dca24) | ![image](/attachments/4787a307-26cf-4910-a013-30e9cc243e6e) |

image.png

41 KiB

image.png

45 KiB

FBXMergeWeightsAverageBug.fbx

22 KiB

Thomas Barlow added 1 commit 2023-10-01 02:14:10 +02:00

a2e10e6a9c Fix incorrect merged weights from ignored bones in FBX import

Given a chain of bones A -> B -> C and a vertex weighted to all three
bones: When C is ignored and its weight is to be merged into its parent
B, the sum of the weights that are not A should remain the same as
before the merge. The current code is instead setting the B weight to
the average of the B and C weights, which does not maintain the sum of
the weights. The division that was creating the average has been
removed, so now the weights in C to be merged into B are added directly
to the B weight.

Because the maximum value a weight can be set to is 1.0, this poses a
problem when the weights to be added together exceed 1.0. Re-normalizing
all the weights on the vertex in this case sounds like it could work,
but unfortunately, we only have access to all the weights for one bone
at a time with the current implementation. Re-normalizing the weights
after adding all the weights to each vertex is too late because the
weights exceeding 1.0 would already have been clamped to 1.0. A comment
has been added to indicate that this is a known issue.

Thomas Barlow requested review from Bastien Montagne 2023-10-01 02:15:28 +02:00

Bastien Montagne approved these changes 2023-10-03 18:15:56 +02:00

Bastien Montagne left a comment

Thanks, think clamping to 1.0 is an acceptable solution for now indeed.

Thanks, think clamping to `1.0` is an acceptable solution for now indeed.

Thomas Barlow added 2 commits 2023-10-06 05:19:35 +02:00

7efdd8a0dc Merge branch 'blender-v4.0-release' into fbx_cluster_import_no_divide

451c665c94 Increase FBX IO Version

Thomas Barlow merged commit 25697d80c2 into blender-v4.0-release

2023-10-06 05:25:42 +02:00

Thomas Barlow deleted branch fbx_cluster_import_no_divide

2023-10-06 05:25:42 +02:00

Thomas Barlow referenced this issue from a commit

2023-10-06 05:25:43 +02:00

Fix incorrect merged weights from ignored bones in FBX import

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix incorrect merged weights from ignored bones in FBX import #104928