blender/blender-addons
19
43
Fork 96
Code Issues 630 Pull Requests 27 Projects 1 Releases Wiki Activity

Images as Planes: Improve option panels #104936

Closed
Sun Kim wants to merge 9 commits from persun/blender-addons:iap_options_ui into main
pull from: persun/blender-addons:iap_options_ui
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 7 Commits 9 Files Changed 1 +66 -65
Sun Kim commented 2023-10-04 10:08:57 +02:00
Contributor
Copy Link
Current PR
addons_import-export_images-as-planes_panel (1).png addons_import-export_images-as-planes_panel_new2.png
  • Layout changes
    • Make all enum options to dropdown menus
    • Rename the title of Position box to Transform
    • Remove sub-headers Plane dimentions, Orientation under Transform box
    • Move offset related options to the bottom. Importing a single plane would be more common use case
  • Rename several labels and option names. Since dropdown allows more space, make some option names verbose
  • Remove the warning 'Opaque' does not support alpha. It should be obvious from usual Blender usage, and doesn't need a special warning from the add-on
  • Disable Alpha Mode options instead of hiding it when use alpha is unchecked
  • Hide Track Camera option instead of disabling it when supported align modes are selected
  • Fix or rewrite several tooltips
| Current | PR | |-|-| | ![addons_import-export_images-as-planes_panel (1).png](/attachments/cb0a75d3-c4be-4149-b7ea-a03d4e9c8bc1) | ![addons_import-export_images-as-planes_panel_new2.png](/attachments/07bfd66c-26d1-4829-a950-8ef9e2cd242e) | - Layout changes - Make all enum options to dropdown menus - Rename the title of `Position` box to `Transform` - Remove sub-headers `Plane dimentions`, `Orientation` under Transform box - Move offset related options to the bottom. Importing a single plane would be more common use case - Rename several labels and option names. Since dropdown allows more space, make some option names verbose - Remove the warning `'Opaque' does not support alpha`. It should be obvious from usual Blender usage, and doesn't need a special warning from the add-on - Disable Alpha Mode options instead of hiding it when use alpha is unchecked - Hide Track Camera option instead of disabling it when supported align modes are selected - Fix or rewrite several tooltips
addons_import-export_images-as-planes_panel_new.png
41 KiB
addons_import-export_images-as-planes_panel (1).png
89 KiB
addons_import-export_images-as-planes_panel_new2.png
39 KiB
addons_import-export_images-as-planes_panel_new.png
❤️ 1
Sun Kim added 4 commits 2023-10-04 10:09:01 +02:00 
Update per new shader and nodes APIs so
Shadless and Emission types work again.
- Reorder groups: Size settings -> Align settings -> Offset settings (importing a single plane would be more commons use case)
- Remove header "Plane dimensions:"
- Remove header "Orientation:"
- Hide Track Camera if Align option is not Main Axis or Face Camera
Damien Picard commented 2023-11-07 11:38:44 +01:00
Member
Copy Link

That’s very nice! I’ve got a few suggestions.

  • Shouldn’t the Shadow Mode be moved just below the Blend Mode, same as in the material properties?

image

  • Could we use something like this for the alpha?

image

        col = box.column(align=False, heading="Alpha")
        row = col.row(align=True)
        row.prop(self, "use_transparency", text="")
        sub = row.row(align=True)
        sub.active = self.use_transparency
        sub.prop(self, "alpha_mode", text="")
  • Other UI panels have dropped the colons “:” after headers, I think this should use the same convention.
That’s very nice! I’ve got a few suggestions. - Shouldn’t the Shadow Mode be moved just below the Blend Mode, same as in the material properties? ![image](/attachments/956c5511-ddd3-4923-b746-f99d5c46b049) - Could we use something like this for the alpha? ![image](/attachments/88647272-b780-4c93-a6e1-51087efbd9c0) ```python col = box.column(align=False, heading="Alpha") row = col.row(align=True) row.prop(self, "use_transparency", text="") sub = row.row(align=True) sub.active = self.use_transparency sub.prop(self, "alpha_mode", text="") ``` - Other UI panels have dropped the colons “:” after headers, I think this should use the same convention.
image.png
22 KiB
image.png
13 KiB
Sun Kim added 5 commits 2023-11-08 09:34:37 +01:00
Sun Kim changed title from WIP: Images as Planes: Improve option panels to Images as Planes: Improve option panels 2023-11-08 09:35:14 +01:00
Sun Kim commented 2023-11-08 09:35:31 +01:00
Author
Contributor
Copy Link

@pioverfour Thanks for review and the suggestions!

Shouldn’t the Shadow Mode be moved just below the Blend Mode, same as in the material properties?

About this, do you think this patch still can land in 4.0? If this has to go 4.1 I think these settings (along with other bigger changes required) may have to change for EEVEE Next.

I still did the change per your suggestion, so you can just merge this in case it's acceptable for 4.0 and I'm not around the time closes.

@pioverfour Thanks for review and the suggestions! > Shouldn’t the Shadow Mode be moved just below the Blend Mode, same as in the material properties? About this, do you think this patch still can land in 4.0? If this has to go 4.1 I think these settings (along with other bigger changes required) may have to change for EEVEE Next. I still did the change per your suggestion, so you can just merge this in case it's acceptable for 4.0 and I'm not around the time closes.
Damien Picard commented 2023-11-08 14:34:06 +01:00
Member
Copy Link

do you think this patch still can land in 4.0?

I think they’re safe code-wise, but today is the last day before release candidate, and only bug fixes are supposed to go in. Also, merging now would mean that the new UI couldn’t be translated to other languages for 4.0.

If this has to go 4.1 I think these settings (along with other bigger changes required) may have to change for EEVEE Next.

It’s still an improvement over the current UI, and only the Material Settings section would change.

> do you think this patch still can land in 4.0? I think they’re safe code-wise, but today is the last day before release candidate, and only bug fixes are supposed to go in. Also, merging now would mean that the new UI couldn’t be translated to other languages for 4.0. > If this has to go 4.1 I think these settings (along with other bigger changes required) may have to change for EEVEE Next. It’s still an improvement over the current UI, and only the Material Settings section would change.
Damien Picard changed target branch from blender-v4.0-release to blender-v4.1-release 2024-02-19 13:05:33 +01:00
Damien Picard changed target branch from blender-v4.1-release to main 2024-04-09 21:54:40 +02:00
Damien Picard commented 2024-04-09 22:29:39 +02:00
Member
Copy Link

Hi, I still think this is important, and even more when drag-and-drop is supported.

I made further changes to make the UI slightly more compact by using columns everywhere:

Current This PR With new change
image image image

It makes the options barely fit on my screen!

Here is a patch for this to apply on top of the PR, let me know what you think.
iap.diff

Hi, I still think this is important, and even more when drag-and-drop is supported. I made further changes to make the UI slightly more compact by using columns everywhere: | Current | This PR | With new change | | -------- | -------- | -------- | | ![image](/attachments/5f89a880-54e3-46da-86af-fd60ee35e507) | ![image](/attachments/3adc6441-4aac-4e44-b630-4f2a21b176bc) | ![image](/attachments/be902cca-a088-43b8-9787-3688a8057a8f) | It makes the options barely fit on my screen! Here is a patch for this to apply on top of the PR, let me know what you think. [iap.diff](/attachments/2def3bcf-ac1e-479f-8aa5-17b08d69bff1)
image.png
101 KiB
image.png
86 KiB
iap.diff
4.6 KiB
image.png
90 KiB
Jesse Yurkovich commented 2024-04-09 22:36:55 +02:00
Member
Copy Link

Indeed the drag-and-drop popup dialog is not well suited to a long layout. How about using Panels, now that those are supported, instead of "boxes"? We could then collapse a few of these sections by default and it would allow the user to collapse sections themselves as they open other ones in case things still don't fit on screen.

Indeed the drag-and-drop popup dialog is not well suited to a long layout. How about using Panels, now that those are supported, instead of "boxes"? We could then collapse a few of these sections by default and it would allow the user to collapse sections themselves as they open other ones in case things still don't fit on screen.
Damien Picard commented 2024-04-09 23:27:42 +02:00
Member
Copy Link

How about using Panels, now that those are supported

Right, I forgot about those but it makes a lot of sense!

How about this, inspired by the FBX importer:

On drop Fully deployed File selector
image image image

Changes included:

  • Move compositing panel to the bottom
  • Rename "Animate Image Sequences" to "Detect Image Sequences".
> How about using Panels, now that those are supported Right, I forgot about those but it makes a lot of sense! How about this, inspired by the FBX importer: | On drop | Fully deployed | File selector | | -------- | -------- | -------- | | ![image](/attachments/19ab5a79-c90e-4e53-ad55-52d6992673b6) | ![image](/attachments/8dbde421-9f98-4bc4-a8d5-70eb12dd78c6) | ![image](/attachments/b22bf2c2-1c32-4afc-a212-1bef2bd9c6ff) | Changes included: - Move compositing panel to the bottom - Rename "Animate Image Sequences" to "Detect Image Sequences".
io_import_images_as_planes.py
47 KiB
image.png
100 KiB
image.png
88 KiB
image.png
72 KiB
Damien Picard referenced this issue from a commit 2024-05-22 00:42:23 +02:00
Improve option panels
Damien Picard commented 2024-05-29 19:09:24 +02:00
Member
Copy Link

Added to Blender core in blender/blender!122345.

Added to Blender core in blender/blender!122345.
Damien Picard closed this pull request 2024-05-29 19:09:25 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#104936
No description provided.
Delete Branch "persun/blender-addons:iap_options_ui"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?