Fix #113866: Import FBX When Recursive File List #104963

Harley Acheson · 2023-10-18T04:12:08+02:00

Harley Acheson commented

2023-10-18 04:12:08 +02:00

When File Browser is set to Recursive lists, importing FBX will fail
because both the filepath and file names contain the recursed path.
Therefore combining the two results in an invalid path. Instead combine
"directory" with file names.

The link in the title fails because that report is not a part of blender-addons repository. Working link: blender/blender#113866

Note that this PR isn't fixing an error in the importer, in that nothing was incorrect when it was written. It was during the addition of Assets to Blender that the values of these strings changed when using recursive listings.

When File Browser is set to Recursive lists, importing FBX will fail because both the filepath and file names contain the recursed path. Therefore combining the two results in an invalid path. Instead combine "directory" with file names. --- The link in the title fails because that report is not a part of blender-addons repository. Working link: https://projects.blender.org/blender/blender/issues/113866 Note that this PR isn't fixing an _error_ in the importer, in that nothing was incorrect when it was written. It was during the addition of Assets to Blender that the values of these strings changed when using recursive listings.

Harley Acheson added 1 commit 2023-10-18 04:12:10 +02:00

637442a64d Fix #113866 : Import FBX When Recursive File List

When File Browser is set to Recursive lists, importing FBX will fail
because both the filepath and file names contain the recursed path.
Therefore combining the two results in an invalid path. Instead combine
"directory" with file names.

Harley Acheson added this to the Import/Export project 2023-10-18 04:12:22 +02:00

Harley Acheson requested review from Campbell Barton 2023-10-18 04:12:29 +02:00

Thomas Barlow requested review from Thomas Barlow 2023-10-23 18:00:22 +02:00

Thomas Barlow requested changes 2023-10-23 18:07:48 +02:00

Thomas Barlow left a comment

Since blender/blender#113866 is not part of blender-addons repository, I think either:

the issue should be closed and re-opened in the blender-addons repository with the commit updated to the new issue number
or the issue number in the commit title should be removed and replaced with a full link to the issue in the commit description.

Personally, I would favour the first option.

I think this fix should go into 4.0 too.

Code change looks good to me though.

Since https://projects.blender.org/blender/blender/issues/113866 is not part of blender-addons repository, I think either: 1. the issue should be closed and re-opened in the blender-addons repository with the commit updated to the new issue number 2. or the issue number in the commit title should be removed and replaced with a full link to the issue in the commit description. Personally, I would favour the first option. I think this fix should go into 4.0 too. Code change looks good to me though.

Philipp Oeser referenced this pull request from blender/blender

2024-03-01 09:43:43 +01:00

Importing fbx files in subfolders when using the recursion feature results in a error message. #113866

Merge conflict checking is in progress. Try again in few moments.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u RecursiveFBX:Harley-RecursiveFBX

git checkout Harley-RecursiveFBX

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #113866: Import FBX When Recursive File List #104963

Checkout