Fix #104991: Node Wrangler Merge Nodes shadows other keymaps (Ctrl+,) #105003

Damien Picard · 2023-11-15T14:29:05+01:00

Damien Picard commented

2023-11-15 14:29:05 +01:00

Node Wrangler's Merge Nodes operator uses many shortcuts to merge
inputs in different ways. One of those shortcuts is Ctrl + , (comma)
which was not used by default until Blender 4.0. In this version it
was affected the Open Preferences Operator, resulting in a conflict.

In many cases, the operator will have no action, such as when no node
tree is active, or when no node is selected. In those cases, the
operator can simply return {'PASS_THROUGH'} and let the shortcut be
handled by another operator.

A cleaner solution to this issue would be to refactor the operator so
that the list of nodes to act on is gathered in the poll() method, and
not call the operator at all if there is nothing to do, but this
refactor would require deeper changes.

Node Wrangler's Merge Nodes operator uses many shortcuts to merge inputs in different ways. One of those shortcuts is Ctrl + , (comma) which was not used by default until Blender 4.0. In this version it was affected the Open Preferences Operator, resulting in a conflict. In many cases, the operator will have no action, such as when no node tree is active, or when no node is selected. In those cases, the operator can simply return {'PASS_THROUGH'} and let the shortcut be handled by another operator. A cleaner solution to this issue would be to refactor the operator so that the list of nodes to act on is gathered in the poll() method, and not call the operator at all if there is nothing to do, but this refactor would require deeper changes.

Damien Picard added the

Module

Add-ons (Community)

label 2023-11-15 14:29:05 +01:00

Damien Picard added 1 commit 2023-11-15 14:29:07 +01:00

c2b9ced6b3 Fix #104991 : Node Wrangler Merge Nodes shadows other keymaps (Ctrl+,)

Node Wrangler's Merge Nodes operator uses many shortcuts to merge
inputs in different ways. One of those shortcuts is Ctrl + , (comma)
which was not used by default until Blender 4.0. In this version it
was affected the Open Preferences Operator, resulting in a conflict.

In many cases, the operator will have no action, such as when no node
tree is active, or when no node is selected. In those cases, the
operator can simply return {'PASS_THROUGH'} and let the shortcut be
handled by another operator.

A cleaner solution to this issue would be to refactor the operator so
that the list of nodes to act on is gathered in the poll() method, and
not call the operator at all if there is nothing to do, but this
refactor would require deeper changes.

Damien Picard manually merged commit 3804000c2e into main

2023-12-19 18:29:27 +01:00

Damien Picard deleted branch dp_fix_104991

2023-12-19 18:29:38 +01:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #104991: Node Wrangler Merge Nodes shadows other keymaps (Ctrl+,) #105003