FBX IO: Fix import of shape key animations without any keyframes #105030

Thomas Barlow · 2023-11-27T16:05:56+01:00

Thomas Barlow commented

2023-11-27 16:05:56 +01:00

Attempting to import a shape key animation without any animation curves
or with only empty animation curves would result in attempting to get
the min/max of an empty list or array.

The animation curve values array is now checked for being non-empty
before attempting to get its minimum and maximum values.

The list of animated shape key deform values is now only created when
there are values to add to it, thus ensuring it is never empty.

This is a backport of 2c32cc163f with the merge conflicts in bl_info resolved.

Attempting to import a shape key animation without any animation curves or with only empty animation curves would result in attempting to get the min/max of an empty list or array. The animation curve values array is now checked for being non-empty before attempting to get its minimum and maximum values. The list of animated shape key deform values is now only created when there are values to add to it, thus ensuring it is never empty. --- This is a backport of 2c32cc163f with the merge conflicts in `bl_info` resolved.

Thomas Barlow added 1 commit 2023-11-27 16:05:59 +01:00

714e42ffcf FBX IO: Fix import of shape key animations without any keyframes

Attempting to import a shape key animation without any animation curves
or with only empty animation curves would result in attempting to get
the min/max of an empty list or array.

The animation curve values array is now checked for being non-empty
before attempting to get its minimum and maximum values.

The list of animated shape key deform values is now only created when
there are values to add to it, thus ensuring it is never empty.

Thomas Barlow referenced this pull request from blender/blender

2023-11-27 16:08:49 +01:00

4.0: Candidates for corrective releases #114706

~~Bastien Montagne referenced this pull request from blender/blender 2023-11-27 16:50:58 +01:00~~

4.0: Candidates for corrective releases #114706

Bastien Montagne approved these changes 2023-11-29 12:53:51 +01:00

Bastien Montagne merged commit db7a31b51f into blender-v4.0-release

2023-11-29 12:54:08 +01:00

Bastien Montagne referenced this issue from a commit

2023-11-29 12:54:08 +01:00

FBX IO: Fix import of shape key animations without any keyframes

Bastien Montagne deleted branch backport_fix_fbx_shape_anim_no_frames