blender/blender-addons
19
43
Fork 96
Code Issues 634 Pull Requests 27 Projects 1 Releases Wiki Activity

Fix: Add Mesh Extra Objects: Inverted normals of solids when vertex positions are inverted #105123

Merged
Thomas Barlow merged 3 commits from Mysteryem/blender-addons:fix_mesh_extra_objects_solid_inverted_normals into main 2024-01-16 21:38:19 +01:00
Conversation 0 Commits 3 Files Changed 2 +18 -4
Thomas Barlow commented 2024-01-15 03:14:12 +01:00
Member
Copy Link

A number of cases of add_mesh_solid.createSolid invert the vertex
positions, but this turns the solid inside-out, causing the normals to
be flipped.

This is fixed by also flipping the normals of the faces in these cases,
which is done by reversing the order of the vertices of each face.

An alternative to !105117, following discussion in that PR.

A number of cases of `add_mesh_solid.createSolid` invert the vertex positions, but this turns the solid inside-out, causing the normals to be flipped. This is fixed by also flipping the normals of the faces in these cases, which is done by reversing the order of the vertices of each face. --- An alternative to !105117, following discussion in that PR.
Thomas Barlow added 2 commits 2024-01-15 03:14:14 +01:00 
A number of cases of `add_mesh_solid.createSolid` invert the vertex
positions, but this turns the solid inside-out, causing the normals to
be flipped.

This is fixed by also reversing the order of the vertices of each face
in these cases, which results in their normals being flipped.
Damien Picard approved these changes 2024-01-15 10:37:04 +01:00
Damien Picard left a comment
Member
Copy Link

Looks good to me!

Looks good to me!
Thomas Barlow added 1 commit 2024-01-16 21:37:34 +01:00
Thomas Barlow merged commit 5cc25e238e into main 2024-01-16 21:38:19 +01:00
Thomas Barlow deleted branch fix_mesh_extra_objects_solid_inverted_normals 2024-01-16 21:38:19 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Damien Picard
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#105123
No description provided.
Delete Branch "Mysteryem/blender-addons:fix_mesh_extra_objects_solid_inverted_normals"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?