Fix #105088: FBX Camera Focus Distance is interpreted as millimeters #105124

Thomas Barlow · 2024-01-15T03:24:08+01:00

Thomas Barlow commented

2024-01-15 03:24:08 +01:00

FBX IO has been converting the Camera FocusDistance property from
millimeters on import and to millimeters on export, however, this
appears to have been incorrect because FocusDistance appears to be
in meters instead.

The FBX SDK used to have deprecated SetSpecificDistance() and
GetSpecificDistance() functions that were documented as accessing
Camera Focus Distance in millimeters.

The documentation of these functions appears to have been incorrectly
attributed to the Camera Focus Distance property itself, which could be
accessed directly without the deprecated functions, and appears to be
stored in meters.

The original discussion where the code was changed to use millimeters can be found at https://archive.blender.org/developer/D6666

FBX IO has been converting the Camera `FocusDistance` property from millimeters on import and to millimeters on export, however, this appears to have been incorrect because `FocusDistance` appears to be in meters instead. The FBX SDK used to have deprecated `SetSpecificDistance()` and `GetSpecificDistance()` functions that were documented as accessing Camera Focus Distance in millimeters. The documentation of these functions appears to have been incorrectly attributed to the Camera Focus Distance property itself, which could be accessed directly without the deprecated functions, and appears to be stored in meters. --- The original discussion where the code was changed to use millimeters can be found at https://archive.blender.org/developer/D6666

Thomas Barlow added 1 commit 2024-01-15 03:24:09 +01:00

6d8622ecd0 Fix #105088 : FBX Camera Focus Distance is interpreted as millimeters

FBX IO has been converting the Camera `FocusDistance` property from
millimeters on import and to millimeters on export, however, this
appears to have been incorrect because `FocusDistance` appears to be
in meters instead.

The FBX SDK used to have deprecated `SetSpecificDistance()` and
`GetSpecificDistance()` functions that were documented as accessing
Camera Focus Distance in millimeters.

The documentation of these functions appears to have been incorrectly
attributed to the Camera Focus Distance property itself, which could be
accessed directly without the deprecated functions, and appears to be
stored in meters.

Thomas Barlow requested review from Bastien Montagne 2024-01-15 05:44:01 +01:00

Bastien Montagne approved these changes 2024-01-15 12:27:22 +01:00

Thomas Barlow added 1 commit 2024-01-16 21:43:08 +01:00

88271db446 Increase FBX IO version

Thomas Barlow added 2 commits 2024-01-16 21:47:11 +01:00

24cb20a61f Merge branch 'main' into fix_105088_fbx_camera_focus_distance_mm