blender
/
blender-addons
17
34
Fork 93
Code Issues 528 Pull Requests 32 Projects 1 Releases Wiki Activity

Node Wrangler: add back exposure compensation for Preview Node #105136

Open
Damien Picard wants to merge 4 commits from pioverfour/blender-addons:dp_nw_exposure_compensation into main
pull from: pioverfour/blender-addons:dp_nw_exposure_compensation
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 4 Commits 4 Files Changed 3 +63 -2
Damien Picard commented 2024-01-17 18:14:16 +01:00
Member
Copy Link

Exposure compensation was a useful feature for better previewing
colors when scene exposure was not neutral. It was removed in
4bf15a06f3 - D15350
after any socket could be connected to the shader output.

This commit reintroduce this feature, but makes it disabled by default
as this workflow is not always wanted. In the case of an NPR scene
where every material is emissive so there are no actual lighting
calculations, the user may want to use the preview feature to quickly
select a texture without having it exposure-compensated.

Fixes #105065

@JacquesLucke, @GregZaal

Not sure whether to enable the feature by default or not. I know it’s been annoying for me on some projects, but nice on others.

Note: this has no effect if the exposure settings are at default values.

Exposure compensation was a useful feature for better previewing colors when scene exposure was not neutral. It was removed in 4bf15a06f3 - [D15350](https://archive.blender.org/developer/D15350) after any socket could be connected to the shader output. This commit reintroduce this feature, but makes it disabled by default as this workflow is not always wanted. In the case of an NPR scene where every material is emissive so there are no actual lighting calculations, the user may want to use the preview feature to quickly select a texture without having it exposure-compensated. Fixes #105065 ----- @JacquesLucke, @GregZaal Not sure whether to enable the feature by default or not. I know it’s been annoying for me on some projects, but nice on others. Note: this has no effect if the exposure settings are at default values.
❤️ 1
Damien Picard added 1 commit 2024-01-17 18:14:18 +01:00
ff9e38f1e8 Fix #105065: NW: add back exposure compensation for Preview Node 
Exposure compensation was a useful feature for better previewing
colors when scene exposure was not neutral. It was removed in
4bf15a06f3 - [D15350](https://archive.blender.org/developer/D15350)
after any socket could be connected to the shader output.

This commit reintroduce this feature, but makes it disabled by default
as this workflow is not always wanted. In the case of an NPR scene
where every material is emissive so there are no actual lighting
calculations, the user may want to use the preview feature to quickly
select a texture without having it exposure-compensated.
Damien Picard added 1 commit 2024-01-17 18:22:16 +01:00
Damien Picard added 1 commit 2024-01-17 18:42:44 +01:00
Damien Picard changed title from Fix #105065: NW: add back exposure compensation for Preview Node to Node Wrangler: add back exposure compensation for Preview Node 2024-01-17 18:48:02 +01:00
Jacques Lucke commented 2024-01-18 10:55:13 +01:00
Member
Copy Link

Since I'm not using this myself, it would be useful if you could get one or two users to comment here that this is working as expected with your patch.

Since I'm not using this myself, it would be useful if you could get one or two users to comment here that this is working as expected with your patch.
Damien Picard commented 2024-01-18 15:19:27 +01:00
Author
Member
Copy Link

@GregZaal Since you wrote the original code, I think you’d be in the best position to know if it behaves properly!

@GregZaal Since you wrote the original code, I think you’d be in the best position to know if it behaves properly!
Damien Picard added 1 commit 2024-02-03 15:43:40 +01:00
Jacques Lucke commented 2024-02-04 14:22:22 +01:00
Member
Copy Link

@blender-bot package

@blender-bot package
Blender Bot commented 2024-02-04 14:22:25 +01:00
Member
Copy Link

Can only build blender/blender and blender/blender-manual. See documentation for details.

Can only build blender/blender and blender/blender-manual. See [documentation](https://projects.blender.org/infrastructure/blender-bot/src/branch/main/README.md) for details.
pioverfour changed target branch from main to blender-v4.1-release 2024-02-12 11:21:30 +01:00
pioverfour changed target branch from blender-v4.1-release to main 2024-03-20 11:50:20 +01:00
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u dp_nw_exposure_compensation:pioverfour-dp_nw_exposure_compensation
git checkout pioverfour-dp_nw_exposure_compensation
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#105136
No description provided.
Delete Branch "pioverfour/blender-addons:dp_nw_exposure_compensation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?