tissue updated to v0.3.70 #105180

Alessandro Zomparelli · 2024-02-14T00:17:54+01:00

Alessandro Zomparelli commented

2024-02-14 00:17:54 +01:00

Updating Tissue add-on to the latest version. Updated features and improved compatibility with Blender 4

Alessandro Zomparelli added 1 commit 2024-02-14 00:17:56 +01:00

tissue updated to v0.3.70 6a961a9688

Alessandro Zomparelli requested review from Owners 2024-02-15 08:52:36 +01:00

Thomas Dinges removed review request for Owners 2024-02-15 08:53:11 +01:00

Alessandro Zomparelli requested review from Sybren A. Stüvel 2024-02-15 09:01:38 +01:00

Alessandro Zomparelli requested review from Francesco Siddi 2024-02-15 09:01:45 +01:00

Brecht Van Lommel commented

2024-02-15 10:16:43 +01:00

@AlessandroZomparelli, for security reasons, we periodically remove commit access from accounts that have not been active for a while. I've restored commit access to the Blender add-ons repository for you now.

If you specifically want code to be reviewed that's fine too, but I'm guessing it's because of this reason you opened a pull request.

@AlessandroZomparelli, for security reasons, we periodically remove commit access from accounts that have not been active for a while. I've restored commit access to the Blender add-ons repository for you now. If you specifically want code to be reviewed that's fine too, but I'm guessing it's because of this reason you opened a pull request.

Thomas Barlow commented

2024-02-15 18:09:19 +01:00

It may be a good idea to get this, or just the 4.0 fixes (ebbc44b30c) and any other bug fixes since then, into 4.1 as well as Main.

It may be a good idea to get this, or just the 4.0 fixes (https://github.com/alessandro-zomparelli/tissue/commit/ebbc44b30cc64a9d93a13ce3ad1dfe97498c5586) and any other bug fixes since then, into 4.1 as well as Main.

Alessandro Zomparelli commented

2024-02-15 19:17:22 +01:00

@AlessandroZomparelli, for security reasons, we periodically remove commit access from accounts that have not been active for a while. I've restored commit access to the Blender add-ons repository for you now.

If you specifically want code to be reviewed that's fine too, but I'm guessing it's because of this reason you opened a pull request.

Hi @brecht yes, that's correct. I don't need a proper review. I just wanted to update the addon to the last version.
I'm not sure about the best practice in this case though. Is it correct to open a Pull Request? After that should I "Create squash commit"? Or should I do procede differently?

Thanks

> @AlessandroZomparelli, for security reasons, we periodically remove commit access from accounts that have not been active for a while. I've restored commit access to the Blender add-ons repository for you now. > > If you specifically want code to be reviewed that's fine too, but I'm guessing it's because of this reason you opened a pull request. Hi @brecht yes, that's correct. I don't need a proper review. I just wanted to update the addon to the last version. I'm not sure about the best practice in this case though. Is it correct to open a Pull Request? After that should I "Create squash commit"? Or should I do procede differently? Thanks

Alessandro Zomparelli commented

2024-02-15 19:19:52 +01:00

It may be a good idea to get this, or just the 4.0 fixes (ebbc44b30c) and any other bug fixes since then, into 4.1 as well as Main.

@Mysteryem I'm constantly fixing some small bugs and adding some extra features, I would use the current last version of the addon. Also, since it's a constantly evolving addon, I would merge more updates in the future.

> It may be a good idea to get this, or just the 4.0 fixes (https://github.com/alessandro-zomparelli/tissue/commit/ebbc44b30cc64a9d93a13ce3ad1dfe97498c5586) and any other bug fixes since then, into 4.1 as well as Main. @Mysteryem I'm constantly fixing some small bugs and adding some extra features, I would use the current last version of the addon. Also, since it's a constantly evolving addon, I would merge more updates in the future.

Brecht Van Lommel commented

2024-02-15 19:30:42 +01:00

@AlessandroZomparelli if want a code review you can create a pull request. If not you can push directly to the repository as before.

If you have not done so already, you need to point to the new repository location on projects.blender.org, as well as set up the SSH key again.

cd scripts/addons
git remote set-url origin git@projects.blender.org:blender/blender-addons.git

We are currently in the bug fixing phase for 4.1, but if things are broken now it makes sense to update the 4.1 branch as well with the latest version. You'd need to commit the changes to the blender-v4.1-release branch, and then merge that branch into main.
https://developer.blender.org/docs/handbook/release_process/release_branch/

@AlessandroZomparelli if want a code review you can create a pull request. If not you can push directly to the repository as before. If you have not done so already, you need to point to the new repository location on projects.blender.org, as well as set up the SSH key again. ``` cd scripts/addons git remote set-url origin git@projects.blender.org:blender/blender-addons.git ``` We are currently in the bug fixing phase for 4.1, but if things are broken now it makes sense to update the 4.1 branch as well with the latest version. You'd need to commit the changes to the `blender-v4.1-release` branch, and then merge that branch into `main`. https://developer.blender.org/docs/handbook/release_process/release_branch/

Alessandro Zomparelli commented

2024-02-15 20:34:28 +01:00

@AlessandroZomparelli if want a code review you can create a pull request. If not you can push directly to the repository as before.

If you have not done so already, you need to point to the new repository location on projects.blender.org, as well as set up the SSH key again.
cd scripts/addons
git remote set-url origin git@projects.blender.org:blender/blender-addons.git
We are currently in the bug fixing phase for 4.1, but if things are broken now it makes sense to update the 4.1 branch as well with the latest version. You'd need to commit the changes to the blender-v4.1-release branch, and then merge that branch into main.
https://developer.blender.org/docs/handbook/release_process/release_branch/

Thanks @brecht for the explanation. I merged it, I hope that I did everything right...

> @AlessandroZomparelli if want a code review you can create a pull request. If not you can push directly to the repository as before. > > If you have not done so already, you need to point to the new repository location on projects.blender.org, as well as set up the SSH key again. > ``` > cd scripts/addons > git remote set-url origin git@projects.blender.org:blender/blender-addons.git > ``` > > We are currently in the bug fixing phase for 4.1, but if things are broken now it makes sense to update the 4.1 branch as well with the latest version. You'd need to commit the changes to the `blender-v4.1-release` branch, and then merge that branch into `main`. > https://developer.blender.org/docs/handbook/release_process/release_branch/ Thanks @brecht for the explanation. I merged it, I hope that I did everything right...

Brecht Van Lommel commented

2024-02-15 20:39:00 +01:00

Looks good to me.

👍 1

Brecht Van Lommel closed this pull request

2024-02-15 20:39:00 +01:00

Brecht Van Lommel commented

2024-03-07 15:42:17 +01:00

@AlessandroZomparelli we have conventions for license and copyright headers, which were applied to your add-on in:
dc8d1d8a5a

But this is not ideal, it would be good if in the upstream repository you could add missing copyright with your name to files that don't have them, and use the shorter SPDX form.

@AlessandroZomparelli we have conventions for license and copyright headers, which were applied to your add-on in: dc8d1d8a5a4d14491f8fad80293fa150f692331f But this is not ideal, it would be good if in the upstream repository you could add missing copyright with your name to files that don't have them, and use the shorter SPDX form.

Alessandro Zomparelli commented

2024-03-25 23:09:24 +01:00

@AlessandroZomparelli we have conventions for license and copyright headers, which were applied to your add-on in:
dc8d1d8a5a

But this is not ideal, it would be good if in the upstream repository you could add missing copyright with your name to files that don't have them, and use the shorter SPDX form.

Hi @brecht thanks for addressign that. It makes a lot of sense. Good to know.
Thanks

Alessandro

> @AlessandroZomparelli we have conventions for license and copyright headers, which were applied to your add-on in: > dc8d1d8a5a4d14491f8fad80293fa150f692331f > > But this is not ideal, it would be good if in the upstream repository you could add missing copyright with your name to files that don't have them, and use the shorter SPDX form. Hi @brecht thanks for addressign that. It makes a lot of sense. Good to know. Thanks Alessandro