IO: Importing multiple 3DS files at once #105227

Merged
Sebastian Sille merged 2 commits from :roblop-patch-1 into main 2024-03-08 19:21:52 +01:00
Contributor

Only the first file is imported even if multiple files are selected. In order to import many 3DS files, we have to manually import them one by one (difficult to do with hundreds of files).

These changes allow all selected files (in the file dialog) to be imported in a single operation.

Limitation : the settings are applied to all imported files.

Only the first file is imported even if multiple files are selected. In order to import many 3DS files, we have to manually import them one by one (difficult to do with hundreds of files). These changes allow all selected files (in the file dialog) to be imported in a single operation. Limitation : the settings are applied to all imported files.
RobLop added 2 commits 2024-03-08 11:06:48 +01:00
RobLop requested review from Sebastian Sille 2024-03-08 11:08:10 +01:00
Sebastian Sille reviewed 2024-03-08 13:47:09 +01:00
Sebastian Sille left a comment
Member

I tested this but was not able to import multiple files at once, how do you select multiple files in the file browser? It seems to me it always imports the one shown on the bottom cell

I tested this but was not able to import multiple files at once, how do you select multiple files in the file browser? It seems to me it always imports the one shown on the bottom cell
Author
Contributor

@NRGSille to select several files, you must press the SHIFT or CTRL key.
Moreover, this patch works very well on Blender 4.1 beta but doesn’t on the last Blender 4.2 alpha (the last build) because the there is an issue with the Blender 4.2 alpha addon : I can’t import any 3DS even if I test the addon without this patch.

@NRGSille to select several files, you must press the SHIFT or CTRL key. Moreover, this patch works very well on Blender 4.1 beta but doesn’t on the last Blender 4.2 alpha (the last build) because the there is an issue with the Blender 4.2 alpha addon : I can’t import any 3DS even if I test the addon without this patch.
RobLop closed this pull request 2024-03-08 14:23:09 +01:00

@RobLop I am researching the error in version 4.2, that one is another issue. Importing multiple files at once is a good idea but even if I select multiple files and then click import only one file gets imported. If I use ctrl the last selected object gets imported and with shift the first selected file gets imported. This has to be checked, if it works I will give it a go^^

@RobLop I am researching the error in version 4.2, that one is another issue. Importing multiple files at once is a good idea but even if I select multiple files and then click import only one file gets imported. If I use ctrl the last selected object gets imported and with shift the first selected file gets imported. This has to be checked, if it works I will give it a go^^

@RobLop I removed the matrix transformation in the import script wich caused the error in 4.2.

Here is the commit: 39f3ea4ab0

@RobLop I removed the matrix transformation in the import script wich caused the error in 4.2. Here is the commit: 39f3ea4ab0
Author
Contributor

@NRGSille Thanks for your commit. I tried another time my commit in 4.2 with your patch and it works as expected (import multiple 3ds files at once). I don't understand why this doesn't work for you.

@NRGSille Thanks for your commit. I tried another time my commit in 4.2 with your patch and it works as expected (import multiple 3ds files at once). I don't understand why this doesn't work for you.
RobLop reopened this pull request 2024-03-08 18:00:10 +01:00

@RobLop I tested again - now it seems to work, We can merge this

I will also add this to the release notes

@RobLop I tested again - now it seems to work, We can merge this I will also add this to the release notes
Sebastian Sille merged commit 14ab4e7422 into main 2024-03-08 19:21:52 +01:00
RobLop deleted branch roblop-patch-1 2024-03-08 23:13:16 +01:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#105227
No description provided.