Fix: Node Wrangler: non-color bump and normal in principled setup #105236

Damien Picard · 2024-03-14T15:20:27+01:00

Damien Picard commented

2024-03-14 15:20:27 +01:00

Commit d50d3f2734 allowed the use of both bump and normal maps when
using Node Wrangler's Principled Setup. However it made those textures
use the default color space instead of Non-Color, which should be used
for data maps.

The bug was introduced because bump and normal maps were handled as
part of regular textures, for which the Non-Color space is assigned
based on name. The change led to them being extracted to their own
block, but the color space assignment was omitted.

Commit d50d3f2734 allowed the use of both bump and normal maps when using Node Wrangler's Principled Setup. However it made those textures use the default color space instead of Non-Color, which should be used for data maps. The bug was introduced because bump and normal maps were handled as part of regular textures, for which the Non-Color space is assigned based on name. The change led to them being extracted to their own block, but the color space assignment was omitted.

Damien Picard added 1 commit 2024-03-14 15:20:29 +01:00

Fix: Node Wrangler: non-color bump and normal in principled setup 71b19ea0b2

Commit d50d3f2734 allowed the use of both bump and normal maps when
using Node Wrangler's Principled Setup. However it made those textures
use the default color space instead of Non-Color, which should be used
for data maps.

The bug was introduced because bump and normal maps were handled as
part of regular textures, for which the Non-Color space is assigned
based on name. The change led to them being extracted to their own
block, but the color space assignment was omitted.

Damien Picard changed target branch from main to blender-v4.1-release

2024-03-14 15:20:42 +01:00

Thomas Dinges commented

2024-03-14 15:23:30 +01:00

Change looks good to me.

❤️ 1

Thomas Dinges approved these changes 2024-03-14 15:23:39 +01:00

Damien Picard merged commit bed1754543 into blender-v4.1-release

2024-03-14 15:25:03 +01:00

Damien Picard deleted branch dp_fix_nw_normal_colorspace

2024-03-14 15:25:04 +01:00

Damien Picard referenced this issue from a commit