blender
/
blender-addons
17
34
Fork 93
Code Issues 526 Pull Requests 32 Projects 1 Releases Wiki Activity

WIP: Compositor Viewer shortcuts prototype #105268

Draft
Habib Gahbiche wants to merge 1 commits from zazizizou/blender-addons:com-wrangler-viewer-shortcuts into main
pull from: zazizizou/blender-addons:com-wrangler-viewer-shortcuts
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 4 Commits 1 Files Changed 2 +139
Habib Gahbiche commented 2024-04-06 17:25:23 +02:00
Member
Copy Link

This is a prototype to be used for user validation.

Press Ctrl+1 to view selected node and set to favorites
Press 1 to view favorite node

Same goes for pressing 2, 3, 4 and 5

This is a prototype to be used for user validation. Press Ctrl+1 to view selected node and set to favorites Press 1 to view favorite node Same goes for pressing 2, 3, 4 and 5
Habib Gahbiche added 1 commit 2024-04-06 17:25:25 +02:00
7be7b70e3c Compositor Viewer shortcuts prototype 
Press Ctrl+1 to view selected node and set to favorites
Press 1 to view favorite node

Same goes for pressing 2, 3, 4 and 5
Habib Gahbiche commented 2024-04-06 17:25:45 +02:00
Author
Member
Copy Link

@blender-bot package

@blender-bot package
Blender Bot commented 2024-04-06 17:25:47 +02:00
Member
Copy Link

Can only build blender/blender and blender/blender-manual. See documentation for details.

Can only build blender/blender and blender/blender-manual. See [documentation](https://projects.blender.org/infrastructure/blender-bot/src/branch/main/README.md) for details.
Damien Picard reviewed 2024-04-06 19:14:30 +02:00
Damien Picard left a comment
Member
Copy Link

This looks very useful! RTS-style :D

This looks very useful! RTS-style :D
node_wrangler/operators.py
@ -489,0 +493,4 @@
bl_description = "Preview favorite nodes by pressing 1, 2, 3, 4 and 5"
bl_options = {'REGISTER', 'UNDO'}
# Workaround: simulating a dict with json.loads() and json.dumps()
Damien Picard commented 2024-04-06 18:54:21 +02:00
Member
Copy Link

You can store the dict directly here, I don’t think you need to bother serializing to a property.

You can store the dict directly here, I don’t think you need to bother serializing to a property.
node_wrangler/operators.py
@ -489,0 +518,4 @@
temp_dict[self.viewer_index] = n1.name
self.node_preview_map = json.dumps(temp_dict)
bpy.ops.node.link_viewer()
Damien Picard commented 2024-04-06 19:04:01 +02:00
Member
Copy Link

With a slight modification of NWPreviewNode, you could use this to make it work in shader trees as well:

                if context.space_data.tree_type in {'CompositorNodeTree', 'GeometryNodeTree'}:
                    bpy.ops.node.link_viewer()
                elif context.space_data.tree_type == 'ShaderNodeTree':
                    bpy.ops.node.nw_preview_node()

@@ -764,6 +764,8 @@ class NWPreviewNode(Operator, NWBase):
         if 'FINISHED' not in select_node:  # only run if mouse click is on a node
             return {'CANCELLED'}
 
+    def execute(self, context):
+        space = context.space_data
         base_node_tree = space.node_tree
         active_tree = context.space_data.edit_tree
         path = context.space_data.path
With a slight modification of `NWPreviewNode`, you could use this to make it work in shader trees as well: ```python if context.space_data.tree_type in {'CompositorNodeTree', 'GeometryNodeTree'}: bpy.ops.node.link_viewer() elif context.space_data.tree_type == 'ShaderNodeTree': bpy.ops.node.nw_preview_node() ``` --- ```diff @@ -764,6 +764,8 @@ class NWPreviewNode(Operator, NWBase): if 'FINISHED' not in select_node: # only run if mouse click is on a node return {'CANCELLED'} + def execute(self, context): + space = context.space_data base_node_tree = space.node_tree active_tree = context.space_data.edit_tree path = context.space_data.path ```
node_wrangler/operators.py
@ -2592,6 +2641,63 @@ class NWAddMultipleImages(Operator, NWBase, ImportHelper):
return {'FINISHED'}
class NWViewerFocus(bpy.types.Operator):
Damien Picard commented 2024-04-06 19:11:06 +02:00
Member
Copy Link

I think this was added back by mistake?

I think this was added back by mistake?
Habib Gahbiche commented 2024-04-07 18:34:50 +02:00
Author
Member
Copy Link

@pioverfour thanks for looking into this! I was hoping I could create an installer directly with this patchset, but I will create a general devtalk thread with some other proposals and then address your comments, if we decide to move on with the solution as an add-on

@pioverfour thanks for looking into this! I was hoping I could create an installer directly with this patchset, but I will create a general devtalk thread with some other proposals and then address your comments, if we decide to move on with the solution as an add-on
Damien Picard commented 2024-04-07 21:02:35 +02:00
Member
Copy Link

@pioverfour thanks for looking into this! I was hoping I could create an installer directly with this patchset, but I will create a general devtalk thread with some other proposals and then address your comments, if we decide to move on with the solution as an add-on

No problem! I hadn’t understood it was too early for review.

> @pioverfour thanks for looking into this! I was hoping I could create an installer directly with this patchset, but I will create a general devtalk thread with some other proposals and then address your comments, if we decide to move on with the solution as an add-on No problem! I hadn’t understood it was too early for review.
Habib Gahbiche changed title from Compositor Viewer shortcuts prototype to WIP: Compositor Viewer shortcuts prototype 2024-04-09 18:55:13 +02:00
This pull request is marked as a work in progress.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u com-wrangler-viewer-shortcuts:zazizizou-com-wrangler-viewer-shortcuts
git checkout zazizizou-com-wrangler-viewer-shortcuts
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#105268
No description provided.
Delete Branch "zazizizou/blender-addons:com-wrangler-viewer-shortcuts"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?