WIP: Compositor Viewer shortcuts prototype #105268

Habib Gahbiche · 2024-04-06T17:25:23+02:00

Habib Gahbiche commented

2024-04-06 17:25:23 +02:00

This is a prototype to be used for user validation.

Press Ctrl+1 to view selected node and set to favorites
Press 1 to view favorite node

Same goes for pressing 2, 3, 4 and 5

This is a prototype to be used for user validation. Press Ctrl+1 to view selected node and set to favorites Press 1 to view favorite node Same goes for pressing 2, 3, 4 and 5

👍 1 👀 1 ❤️ 2 🎉 1 🚀 1

Habib Gahbiche added 1 commit 2024-04-06 17:25:25 +02:00

Compositor Viewer shortcuts prototype 7be7b70e3c

Press Ctrl+1 to view selected node and set to favorites
Press 1 to view favorite node

Same goes for pressing 2, 3, 4 and 5

Habib Gahbiche commented

2024-04-06 17:25:45 +02:00

@blender-bot package

Blender Bot commented

2024-04-06 17:25:47 +02:00

Can only build blender/blender and blender/blender-manual. See documentation for details.

Can only build blender/blender and blender/blender-manual. See [documentation](https://projects.blender.org/infrastructure/blender-bot/src/branch/main/README.md) for details.

Damien Picard reviewed 2024-04-06 19:14:30 +02:00

Damien Picard left a comment

This looks very useful! RTS-style :D

node_wrangler/operators.py

						
				@ -489,0 +493,4 @@

				    bl_description = "Preview favorite nodes by pressing 1, 2, 3, 4 and 5"

				    bl_options = {'REGISTER', 'UNDO'}

				    # Workaround: simulating a dict with json.loads() and json.dumps()

Damien Picard commented

2024-04-06 18:54:21 +02:00

You can store the dict directly here, I don’t think you need to bother serializing to a property.

Habib Gahbiche commented

2024-06-23 22:59:03 +02:00

That didn't seem to work. I think it has to be a property for it to be persistent throughout the lifetime of the operator.

node_wrangler/operators.py

						
				@ -489,0 +518,4 @@

				                temp_dict[self.viewer_index] = n1.name

				                self.node_preview_map = json.dumps(temp_dict)

				                bpy.ops.node.link_viewer()

Damien Picard commented

2024-04-06 19:04:01 +02:00

With a slight modification of NWPreviewNode, you could use this to make it work in shader trees as well:

                if context.space_data.tree_type in {'CompositorNodeTree', 'GeometryNodeTree'}:
                    bpy.ops.node.link_viewer()
                elif context.space_data.tree_type == 'ShaderNodeTree':
                    bpy.ops.node.nw_preview_node()

@@ -764,6 +764,8 @@ class NWPreviewNode(Operator, NWBase):
         if 'FINISHED' not in select_node:  # only run if mouse click is on a node
             return {'CANCELLED'}
 
+    def execute(self, context):
+        space = context.space_data
         base_node_tree = space.node_tree
         active_tree = context.space_data.edit_tree
         path = context.space_data.path

With a slight modification of `NWPreviewNode`, you could use this to make it work in shader trees as well: ```python if context.space_data.tree_type in {'CompositorNodeTree', 'GeometryNodeTree'}: bpy.ops.node.link_viewer() elif context.space_data.tree_type == 'ShaderNodeTree': bpy.ops.node.nw_preview_node() ``` --- ```diff @@ -764,6 +764,8 @@ class NWPreviewNode(Operator, NWBase): if 'FINISHED' not in select_node: # only run if mouse click is on a node return {'CANCELLED'} + def execute(self, context): + space = context.space_data base_node_tree = space.node_tree active_tree = context.space_data.edit_tree path = context.space_data.path ```

node_wrangler/operators.py

						
				@ -2592,6 +2641,63 @@ class NWAddMultipleImages(Operator, NWBase, ImportHelper):

				        return {'FINISHED'}

				class NWViewerFocus(bpy.types.Operator):

Damien Picard commented

2024-04-06 19:11:06 +02:00

I think this was added back by mistake?

Habib Gahbiche commented

2024-04-07 18:34:50 +02:00

@pioverfour thanks for looking into this! I was hoping I could create an installer directly with this patchset, but I will create a general devtalk thread with some other proposals and then address your comments, if we decide to move on with the solution as an add-on

Damien Picard commented

2024-04-07 21:02:35 +02:00

@pioverfour thanks for looking into this! I was hoping I could create an installer directly with this patchset, but I will create a general devtalk thread with some other proposals and then address your comments, if we decide to move on with the solution as an add-on

No problem! I hadn’t understood it was too early for review.

> @pioverfour thanks for looking into this! I was hoping I could create an installer directly with this patchset, but I will create a general devtalk thread with some other proposals and then address your comments, if we decide to move on with the solution as an add-on No problem! I hadn’t understood it was too early for review.

Habib Gahbiche changed title from ~~Compositor Viewer shortcuts prototype~~ to WIP: Compositor Viewer shortcuts prototype

2024-04-09 18:55:13 +02:00

Habib Gahbiche commented

2024-06-23 23:00:14 +02:00

Node wrangler moved to core so I'm closing this issue. Followup is blender/blender#123641. Still WIP and still planning to move it to C/C++ if feedback is good.

Node wrangler moved to core so I'm closing this issue. Followup is https://projects.blender.org/blender/blender/pulls/123641. Still WIP and still planning to move it to C/C++ if feedback is good.

Habib Gahbiche closed this pull request

2024-06-23 23:00:15 +02:00