Add camera rigs: workaround for the 2D rig dependency cycle #105293

Damien Picard · 2024-04-24T21:41:39+02:00

Damien Picard commented

2024-04-24 21:41:39 +02:00

A dependency cycle occurs currently because the camera's properties
depend on both the armature and itself, through the lens property.
As far as I can tell this cycle does not cause any lag, but it's
better to fix it anyway.

This commit works around this cycle by introducing an intermediate
lens property on the rig itself, and this is used to drive the actual
camera lens.

Reported and fixed by Beorn Leonard.

This PR also includes the upstream improvement to expose 2D rig
properties in the UI.

A dependency cycle occurs currently because the camera's properties depend on both the armature and itself, through the lens property. As far as I can tell this cycle does not cause any lag, but it's better to fix it anyway. This commit works around this cycle by introducing an intermediate lens property on the rig itself, and this is used to drive the actual camera lens. Reported and fixed by Beorn Leonard. This PR also includes the upstream improvement to expose 2D rig properties in the UI.

Damien Picard added 3 commits 2024-04-24 21:41:41 +02:00

d55bd19cc6 Add camera rigs: workaround dependency cycles on the 2D rig

A dependency cycle occurs currently because the camera's properties
depend on both the armature and itself, through the lens property.
As far as I can tell this cycle does not cause any lag, but it's
better to fix it anyway.

This commit works around this cycle by introducing an intermediate
lens property on the rig itself, and this is used to drive the actual
camera lens.

Reported and fixed by Beorn Leonard.

194b35b55e Add camera rigs: expose custom properties in ui (2d camera rig)

36ce06bd3a Add camera rigs: update version number

Damien Picard commented

2024-04-24 21:44:13 +02:00

@WayneDixon Hi, it looks like I can’t assign you as a reviewer, but here’s an alternative fix to the dependency cycle, based on Beorn’s solution.

Damien Picard force-pushed fix_cams from 36ce06bd3a to d811727a89

2024-04-24 21:51:03 +02:00

Compare

Merge conflict checking is in progress. Try again in few moments.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u fix_cams:pioverfour-fix_cams

git checkout pioverfour-fix_cams

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Add camera rigs: workaround for the 2D rig dependency cycle #105293

Checkout