blender/blender-addons
19
43
Fork 96
Code Issues 634 Pull Requests 27 Projects 1 Releases Wiki Activity

Add camera rigs: workaround for the 2D rig dependency cycle #105293

Closed
Damien Picard wants to merge 3 commits from pioverfour/blender-addons:fix_cams into main
pull from: pioverfour/blender-addons:fix_cams
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 2 Commits 3 Files Changed 3 +26 -11
Damien Picard commented 2024-04-24 21:41:39 +02:00
Member
Copy Link

A dependency cycle occurs currently because the camera's properties
depend on both the armature and itself, through the lens property.
As far as I can tell this cycle does not cause any lag, but it's
better to fix it anyway.

This commit works around this cycle by introducing an intermediate
lens property on the rig itself, and this is used to drive the actual
camera lens.

Reported and fixed by Beorn Leonard.

This PR also includes the upstream improvement to expose 2D rig
properties in the UI.

A dependency cycle occurs currently because the camera's properties depend on both the armature and itself, through the lens property. As far as I can tell this cycle does not cause any lag, but it's better to fix it anyway. This commit works around this cycle by introducing an intermediate lens property on the rig itself, and this is used to drive the actual camera lens. Reported and fixed by Beorn Leonard. This PR also includes the upstream improvement to expose 2D rig properties in the UI.
Damien Picard added 3 commits 2024-04-24 21:41:41 +02:00 
A dependency cycle occurs currently because the camera's properties
depend on both the armature and itself, through the lens property.
As far as I can tell this cycle does not cause any lag, but it's
better to fix it anyway.

This commit works around this cycle by introducing an intermediate
lens property on the rig itself, and this is used to drive the actual
camera lens.

Reported and fixed by Beorn Leonard.
Damien Picard commented 2024-04-24 21:44:13 +02:00
Author
Member
Copy Link

@WayneDixon Hi, it looks like I can’t assign you as a reviewer, but here’s an alternative fix to the dependency cycle, based on Beorn’s solution.

@WayneDixon Hi, it looks like I can’t assign you as a reviewer, but here’s an alternative fix to the dependency cycle, based on Beorn’s solution.
Damien Picard force-pushed fix_cams from 36ce06bd3a to d811727a89 2024-04-24 21:51:03 +02:00 Compare
Damien Picard commented 2024-06-09 21:18:40 +02:00
Author
Member
Copy Link

Closing because built-in add-ons are now hosted elsewhere.

Closing because built-in add-ons are now hosted [elsewhere](https://projects.blender.org/extensions/add_camera_rigs/).
Damien Picard closed this pull request 2024-06-09 21:18:41 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#105293
No description provided.
Delete Branch "pioverfour/blender-addons:fix_cams"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?