blender/blender-asset-tracer
2
5
Fork 5
Code Issues 4 Pull Requests 1 Projects Releases Wiki Activity

Add support for IES lighting #92883

Closed
Olivier C wants to merge 2 commits from oliverpool:ies_support into main
pull from: oliverpool:ies_support
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 4 Commits 2 Files Changed 1 +14
Olivier C commented 2023-10-13 08:32:40 +02:00
Contributor
Copy Link

Hi @dr.sybren

this PR adds support for IES lighting.

Since this is our first contribution, we would appreciate any feedback!

contribution on behalf of RANCH Computing

Hi @dr.sybren this PR adds support for IES lighting. Since this is our first contribution, we would appreciate any feedback! _contribution on behalf of [RANCH Computing](https://www.ranchcomputing.com/)_
Olivier C added 1 commit 2023-10-13 08:32:42 +02:00
Olivier C commented 2023-10-13 08:34:49 +02:00
Author
Contributor
Copy Link

Here is a sample scene to test this patch

Here is a sample scene to test this patch
ies_scene.zip
115 KiB
Olivier C added 1 commit 2023-10-13 08:38:05 +02:00
Sybren A. Stüvel approved these changes 2023-10-16 12:12:35 +02:00
Sybren A. Stüvel left a comment
Member
Copy Link

Thanks for the PR! I'll do the last little change when merging.

Thanks for the PR! I'll do the last little change when merging.
👍 1
blender_asset_tracer/trace/blocks2assets.py
@ -216,0 +224,4 @@
return
for node in iterators.listbase(block_ntree.get_pointer((b"nodes", b"first"))):
storage = node.get_pointer(b"storage")
if storage:
Sybren A. Stüvel commented 2023-10-13 15:00:33 +02:00
Member
Copy Link

Flip the condition & continue, so that the bulk of the code is non-conditional:

if not storage:
    continue
path, field = storage.get(b"filepath", return_field=True)
yield result.BlockUsage(block, path, path_full_field=field)
Flip the condition & `continue`, so that the bulk of the code is non-conditional: ```python if not storage: continue path, field = storage.get(b"filepath", return_field=True) yield result.BlockUsage(block, path, path_full_field=field) ```
Olivier C commented 2023-10-16 13:19:20 +02:00
Author
Contributor
Copy Link

Cherry-picked in 74b3df5f99

I can confirm it works fine on our automated testing.

Cherry-picked in https://projects.blender.org/blender/blender-asset-tracer/commit/74b3df5f99ceba7e13e55715146ee45714772b29 I can confirm it works fine on our automated testing.
Olivier C closed this pull request 2023-10-16 13:19:21 +02:00
Sybren A. Stüvel commented 2023-12-14 11:10:30 +01:00
Member
Copy Link

I can confirm it works fine on our automated testing.

Would you mind adding a unit test for BAT that tests this too? That way the project doesn't have to rely on your automated testing ;-)

The context: there's an issue with the code (studio/flamenco#104269) which is tricky to resolve properly due to the lack of unit tests in this PR.

> I can confirm it works fine on our automated testing. Would you mind adding a unit test for BAT that tests this too? That way the project doesn't have to rely on your automated testing ;-) The context: there's an issue with the code (https://projects.blender.org/studio/flamenco/issues/104269) which is tricky to resolve properly due to the lack of unit tests in this PR.
Olivier C commented 2023-12-15 11:12:06 +01:00
Author
Contributor
Copy Link

I added a test in #92886 for a relative Lamp inside and outside of the project (the test that was in our pipeline).

Feel free to add a testcase for your commit 61dc5b8a23 as well

I added a test in #92886 for a relative Lamp inside and outside of the project (the test that was in our pipeline). Feel free to add a testcase for your commit 61dc5b8a23 as well

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Sybren A. Stüvel
Labels
Clear labels   
legacy module
Platforms, Builds, Tests & Devices

  
legacy project
Blender Asset Tracer

  
legacy project
Platform: Windows

  
Priority::Normal

   
Status::Archived

   
Status::Confirmed

   
Status::Needs Triage

   
Status::Resolved

   
Type::Design

   
Type::Report

   
Type::To Do
No Label
legacy module
Platforms, Builds, Tests & Devices
legacy project
Blender Asset Tracer
legacy project
Platform: Windows
Priority::Normal
Status::Archived
Status::Confirmed
Status::Needs Triage
Status::Resolved
Type::Design
Type::Report
Type::To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-asset-tracer#92883
No description provided.
Delete Branch "oliverpool:ies_support"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?