blender/blender-asset-tracer
2
5
Fork 5
Code Issues 4 Pull Requests 1 Projects Releases Wiki Activity

Add support for IES lighting #92883

Closed
Olivier C wants to merge 2 commits from oliverpool:ies_support into main
pull from: oliverpool:ies_support
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 4 Commits 2 Files Changed 1 +7 -6
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 90da2be4f9 - Show all commits

13
blender_asset_tracer/trace/blocks2assets.py
View File

@ -220,9 +220,10 @@ def vector_font(block: blendfile.BlendFileBlock) -> typing.Iterator[result.Block
def lamp(block: blendfile.BlendFileBlock) -> typing.Iterator[result.BlockUsage]:
"""Lamp data blocks."""
block_ntree = block.get_pointer(b"nodetree", None)
if block_ntree is not None:
for node in iterators.listbase(block_ntree.get_pointer((b"nodes", b"first"))):
storage = node.get_pointer(b"storage")
if storage:
path, field = storage.get(b"filepath", return_field=True)
yield result.BlockUsage(block, path, path_full_field=field)
if block_ntree is None:
return
for node in iterators.listbase(block_ntree.get_pointer((b"nodes", b"first"))):
storage = node.get_pointer(b"storage")
if storage:
Sybren A. Stüvel commented 2023-10-13 15:00:33 +02:00
Review
Copy Link

Flip the condition & continue, so that the bulk of the code is non-conditional:

if not storage:
    continue
path, field = storage.get(b"filepath", return_field=True)
yield result.BlockUsage(block, path, path_full_field=field)
Flip the condition & `continue`, so that the bulk of the code is non-conditional: ```python if not storage: continue path, field = storage.get(b"filepath", return_field=True) yield result.BlockUsage(block, path, path_full_field=field) ```
path, field = storage.get(b"filepath", return_field=True)
yield result.BlockUsage(block, path, path_full_field=field)