blender/blender-asset-tracer
2
5
Fork 5
Code Issues 4 Pull Requests 1 Projects Releases Wiki Activity

Add Support for Dynamic Paint Modifier #92889

Merged
Sybren A. Stüvel merged 2 commits from JonasDichelle/blender-asset-tracer:dynamicpaint_support into main 2024-09-02 18:19:08 +02:00
Conversation 6 Commits 2 Files Changed 2 +35
Jonas Dichelle commented 2024-08-28 13:09:11 +02:00
Contributor
Copy Link

This PR adds support for the Dynamic Paint modifier point cache.
I added a walker to iterate through all surfaces on a canvas to get each surface's point cache.

This PR adds support for the Dynamic Paint modifier point cache. I added a walker to iterate through all surfaces on a canvas to get each surface's point cache.
👍 1
Jonas Dichelle added 1 commit 2024-08-28 13:09:12 +02:00
Demeter Dzadik requested review from Sybren A. Stüvel 2024-08-29 02:32:18 +02:00
Sybren A. Stüvel commented 2024-08-29 12:54:56 +02:00
Member
Copy Link

Can you attach a ZIP/blendfile that I can test with?

Can you attach a ZIP/blendfile that I can test with?
Sybren A. Stüvel requested changes 2024-08-29 12:57:01 +02:00
Dismissed
blender_asset_tracer/trace/modifier_walkers.py Outdated
@ -320,0 +338,4 @@
surfaces = canvas_settings.get_pointer((b"surfaces", b"first"))
for surface in blendfile.iterators.listbase(surfaces):
surface_block_name = block_name + b"%s.canvas_settings.surfaces[%d]"
Sybren A. Stüvel commented 2024-08-29 12:56:58 +02:00
Member
Copy Link

Does the block name really have %s and %d in it? If that is indeed the case, please add a comment to explain this.

Does the block name really have `%s` and `%d` in it? If that is indeed the case, please add a comment to explain this.
Jonas Dichelle commented 2024-08-29 17:22:31 +02:00
Author
Contributor
Copy Link

That's a mistake, fixed it in the new commit, sorry.

That's a mistake, fixed it in the new commit, sorry.
Jonas Dichelle added 1 commit 2024-08-29 17:21:35 +02:00
Jonas Dichelle commented 2024-08-29 17:25:18 +02:00
Author
Contributor
Copy Link

@dr.sybren here's a simple blend you can test with:

@dr.sybren here's a simple blend you can test with:
dynamicpaint_test.blend
1.1 MiB
Sybren A. Stüvel commented 2024-09-02 11:33:44 +02:00
Member
Copy Link

Thanks for the file. How do I test? Since there is no ZIP with external files BAT is supposed to report, I think I have to press some buttons to generate those locally? Which ones do I press?

Thanks for the file. How do I test? Since there is no ZIP with external files BAT is supposed to report, I think I have to press some buttons to generate those locally? Which ones do I press?
Jonas Dichelle commented 2024-09-02 17:19:18 +02:00
Author
Contributor
Copy Link

You would just have to bake the dynamic paint cache. But here's a zip that includes the cache

You would just have to bake the dynamic paint cache. But here's a zip that includes the cache
dynpaint_pr.zip
235 KiB
Sybren A. Stüvel commented 2024-09-02 18:14:20 +02:00
Member
Copy Link

It's not about whether it's a simple action to perform or not, it's about being confident that what I'm testing with is actually what your PR fixes. Thanks for the file, this helps.

It's not about whether it's a simple action to perform or not, it's about being confident that what I'm testing with is actually what your PR fixes. Thanks for the file, this helps.
Jonas Dichelle commented 2024-09-02 18:16:25 +02:00
Author
Contributor
Copy Link

Yes, I'm sorry for not including it earlier.

Yes, I'm sorry for not including it earlier.
Sybren A. Stüvel approved these changes 2024-09-02 18:18:36 +02:00
Sybren A. Stüvel left a comment
Member
Copy Link

Thanks!

Thanks!
🎉 1
Sybren A. Stüvel merged commit 16a092ddf1 into main 2024-09-02 18:19:08 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Sybren A. Stüvel
Labels
Clear labels   
legacy module
Platforms, Builds, Tests & Devices

  
legacy project
Blender Asset Tracer

  
legacy project
Platform: Windows

  
Priority::Normal

   
Status::Archived

   
Status::Confirmed

   
Status::Needs Triage

   
Status::Resolved

   
Type::Design

   
Type::Report

   
Type::To Do
No Label
legacy module
Platforms, Builds, Tests & Devices
legacy project
Blender Asset Tracer
legacy project
Platform: Windows
Priority::Normal
Status::Archived
Status::Confirmed
Status::Needs Triage
Status::Resolved
Type::Design
Type::Report
Type::To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-asset-tracer#92889
No description provided.
Delete Branch "JonasDichelle/blender-asset-tracer:dynamicpaint_support"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?