blender/blender-assets
0
1
Fork 4
Code Pull Requests 1 Activity

Fix: Correct polyline hide and polyline face set icons #6

Merged
Sean Kim merged 2 commits from Sean-Kim/blender-assets:fix-polyline-mask into main 2024-05-28 17:06:59 +02:00
Conversation 1 Commits 2 Files Changed 1 +2 -2
Sean Kim commented 2024-05-25 04:31:09 +02:00
Member
Copy Link

This PR makes the following changes:

  • Moves the ops.sculpt.polyline_hide origin to be centered with its geometry to ensure it gets rendered
  • Assigns the correct material to the middle face for ops.sculpt.polyline_face_set to ensure it is colored appropriately when rendered in blender
  • Changes the theme.sculpt.grab color from the default white to EAD28A to match the rendered color and make it more obvious when editing the toolbar.blend file.
Mask Face Set
polyline_mask_icon.png polylilne_face_set_icon.png
This PR makes the following changes: * Moves the `ops.sculpt.polyline_hide` origin to be centered with its geometry to ensure it gets rendered * Assigns the correct material to the middle face for `ops.sculpt.polyline_face_set` to ensure it is colored appropriately when rendered in blender * Changes the `theme.sculpt.grab` color from the default white to `EAD28A` to match the rendered color and make it more obvious when editing the `toolbar.blend` file. | Mask | Face Set | | ---- | -------- | | ![polyline_mask_icon.png](/attachments/d397a5da-1e4a-42ee-b726-6d54c6f59d69) | ![polylilne_face_set_icon.png](/attachments/7e4f3e6f-2d65-4dfb-abf2-338fb431e048) |
polyline_face_set_icon.png
31 KiB
polyline_mask_icon.png
34 KiB
Sean Kim added 1 commit 2024-05-25 04:31:11 +02:00
Sean Kim requested review from Pablo Vazquez 2024-05-25 04:31:23 +02:00
Sean Kim added 1 commit 2024-05-25 22:20:56 +02:00
Sean Kim changed title from Fix: Ensure Polyline Mask icon is visible after rendering to Fix: Correct polyline hide and polyline face set icons 2024-05-25 22:21:56 +02:00
Sean Kim commented 2024-05-25 22:30:38 +02:00
Author
Member
Copy Link

Updated to incorporate color fixes for ops.sculpt.polyline_face_set from @nickberckley

Updated to incorporate color fixes for `ops.sculpt.polyline_face_set` from @nickberckley
Sean Kim requested review from Hans Goudey 2024-05-28 16:26:02 +02:00
Hans Goudey approved these changes 2024-05-28 16:27:32 +02:00
Sean Kim merged commit 6864f1832e into main 2024-05-28 17:06:59 +02:00
Sean Kim deleted branch fix-polyline-mask 2024-05-28 17:07:00 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Pablo Vazquez
Hans Goudey
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-assets#6
No description provided.
Delete Branch "Sean-Kim/blender-assets:fix-polyline-mask"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?