Set color tag for node group assets #8
No reviewers
Labels
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender-assets#8
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "nickberckley/blender-assets:node-tags"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Color tags were added for node groups in 4.2 and it makes sense to add them to existing assets we bundle with Blender.
But there needs to be logic behind setting a tag, which is important not just for our assets, but also for people who make their own, because built-in assets act as example.
Geometry tag:
Nodes with geometry tag take geometry as main input and output it with some transformation done to them. It can be as simple as reordering points, but usually impact of those nodes are very easy to see visually.
Input tag:
Nodes with input tag simply provide fields, constants, or etc. which can't be used own their own, and instead are used for accessing parts of geometry, attributes and others. Built-in nodes like Spline Length, Normal, Curve Tangent are also using those tag, so makes sense following nodes do too:
Additionally, I set two nodes with different color tags. First one is shape_range which I set as Converter, which is not an asset, but is imported in project files, and is simple math node, similar to almost all other converter nodes.
And other is Create Guide Index Map, which I set as Attribute tag.
Even though this node also takes in geometry and outputs it, actual purpose of node is capturing attributes and storing named attribute
guide_curve_index
. And I define nodes under attribute tag like this: Node assets with main purpose of capturing, storing, restoring, or removing named or generic attributes.If we can agree on definitions for tags it would be good to document them in Human Interface Guidelines.
The way that it works right now, changes in this repo should be done initially in the
Working
directory and then pushed using the python script into thePublish
directory, rather than doing the changes directly in the publish. At least that's how I set this up initially for the hair assets. This workflow can be revised in the future, but for now it would be good to stick to it and not let these files get out of sync.The categories you assigned make sense to me though, I don't have any remarks on that aspect 👍
d382b65757
to6f22e5af7d
@SimonThommes had to force push but I believe everything should be correct. There was no publish file in smooth_by_angle blend file, so I appended one, changed the destination and saved it for future use.
Looked at the files, looks good to me 👍