Fixing typo and rephrasing the Island Index section of the Mesh Island node #104481

Arthur Blaquart · 2023-06-07T20:20:00+02:00

Arthur Blaquart commented

2023-06-07 20:20:00 +02:00

First-time contributor

From:
The index of the each vertex’s island. Indices are decided based on the lowest vertex index contained in each island

To:
Each island index is based on it's lowest vertex index.

Hopefully it's clearer. It's my first commit to the documentation, hopefully I'm not screwing it up!

From: The index of the each vertex’s island. Indices are decided based on the lowest vertex index contained in each island To: Each island index is based on it's lowest vertex index. Hopefully it's clearer. It's my first commit to the documentation, hopefully I'm not screwing it up!

Arthur Blaquart added 1 commit 2023-06-07 20:20:02 +02:00

b54177fec4 Fixing typo and rephrasing the Island Index section of the Mesh Island node

From:
The index of the each vertex’s island. Indices are decided based on the lowest vertex index contained in each island

To:
Each island index is based on it's lowest vertex index.

Hopefully it's clearer. It's my first commit to the documentation, hopefully I'm not screwing it up!

Iliya Katushenock requested review from Hans Goudey 2023-06-07 20:31:29 +02:00

Hans Goudey commented

2023-06-07 20:45:49 +02:00

Thanks for the fix! I'd just remove the extra "the" though (index of the each -> index of each). As it is, some information is removed from the description.

Thanks for the fix! I'd just remove the extra "the" though (`index of the each` -> `index of each`). As it is, some information is removed from the description.

Arthur Blaquart commented

2023-06-07 21:01:13 +02:00

First-time contributor

You are absolutely right, sorry, I'm not sure how I missed the importance of the first sentence in describing the output. I don't know how to edit the commit to make the proper change, I'll do some research.

In the meantime we agree on this then:

The index of each vertex’s island. Indices are decided based on the lowest vertex index contained in each island.

Thank you!

You are absolutely right, sorry, I'm not sure how I missed the importance of the first sentence in describing the output. I don't know how to edit the commit to make the proper change, I'll do some research. In the meantime we agree on this then: The index of each vertex’s island. Indices are decided based on the lowest vertex index contained in each island. Thank you!

👍 1

Aaron Carlisle commented

2023-06-11 05:04:22 +02:00

Yes that sounds like an appropriate description.

You can use the online editor here to make the appropriate change:

https://projects.blender.org/Human_Robot/blender-manual/src/branch/human_robot-patch-1/manual/modeling/geometry_nodes/mesh/read/mesh_island.rst

Yes that sounds like an appropriate description. You can use the online editor here to make the appropriate change: https://projects.blender.org/Human_Robot/blender-manual/src/branch/human_robot-patch-1/manual/modeling/geometry_nodes/mesh/read/mesh_island.rst

👀 1

Aaron Carlisle referenced this issue from a commit

2023-06-23 19:03:14 +02:00

Cleanup: Fix typo on Mesh Island Node page

Aaron Carlisle commented

2023-06-23 19:10:32 +02:00

Committed a fix here: c37b60f16d

Committed a fix here: https://projects.blender.org/blender/blender-manual/commit/c37b60f16d5bcf42903f835863e56deaffca4193

Aaron Carlisle closed this pull request

2023-06-23 19:10:32 +02:00