Parsing of all a make flags in loop #104541

Open
Iliya Katushenock wants to merge 3 commits from mod_moder/blender-manual:support_custom_port into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Main target of this refactoring - support of custom port.
This flag should be passed as another one optional argument
to the make. But to do this, all flags should be able to be parsed
individually. To support this, loop was added.
Functional changes:

  • Commands with the same level (check_syntax, check_spelling, ...)
    can be processed by the make at the same executing call.
  • New command port ... (set a port index).
  • New command sphinx ... (set a command file for Sphinx documentation).
  • New command lang ... (set a language).
    It was added just to be.

TODO:

  • Help.
  • Commented part of file.
Main target of this refactoring - support of custom port. This flag should be passed as another one optional argument to the make. But to do this, all flags should be able to be parsed individually. To support this, loop was added. Functional changes: - Commands with the same level (`check_syntax`, `check_spelling`, ...) can be processed by the make at the same executing call. - New command `port ...` (set a port index). - New command `sphinx ...` (set a command file for Sphinx documentation). - New command `lang ...` (set a language). It was added just to be. TODO: - [ ] Help. - [ ] Commented part of file.
Iliya Katushenock added 1 commit 2023-09-01 01:28:29 +02:00
Iliya Katushenock added 1 commit 2023-09-01 01:30:40 +02:00
Iliya Katushenock added 1 commit 2023-09-01 01:34:25 +02:00
Iliya Katushenock changed title from Refactoring: Parsing of all a make flags in loop to Parsing of all a make flags in loop 2023-09-01 03:19:27 +02:00
Member

Would it be simpler to be able to set the port through an environment variable?

This is rather advanced for most people so I am not sure it is worth the extra complexity.

Would it be simpler to be able to set the port through an environment variable? This is rather advanced for most people so I am not sure it is worth the extra complexity.
Aaron Carlisle requested review from Aaron Carlisle 2023-12-02 21:24:31 +01:00
Author
Member

Well, not all people need to change it's port, so not sure if that complexity will be affected on many users.
In another hand, to change port, just one optional flag need to be added (that should be just one line to type instead of changing path variables).
To support ports, feature to support any other flags was added too, hope this might simplify much more sides than make more complicated.

Well, not all people need to change it's port, so not sure if that complexity will be affected on many users. In another hand, to change port, just one optional flag need to be added (that should be just one line to type instead of changing path variables). To support ports, feature to support any other flags was added too, hope this might simplify much more sides than make more complicated.
This pull request has changes conflicting with the target branch.
  • make.bat

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u support_custom_port:mod_moder-support_custom_port
git checkout mod_moder-support_custom_port
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-manual#104541
No description provided.