Parsing of all a make flags in loop #104541

Iliya Katushenock · 2023-09-01T01:28:27+02:00

Iliya Katushenock commented

2023-09-01 01:28:27 +02:00

Main target of this refactoring - support of custom port.
This flag should be passed as another one optional argument
to the make. But to do this, all flags should be able to be parsed
individually. To support this, loop was added.
Functional changes:

Commands with the same level (check_syntax, check_spelling, ...)
can be processed by the make at the same executing call.
New command port ... (set a port index).
New command sphinx ... (set a command file for Sphinx documentation).
New command lang ... (set a language).
It was added just to be.

TODO:

Help.
Commented part of file.

Main target of this refactoring - support of custom port. This flag should be passed as another one optional argument to the make. But to do this, all flags should be able to be parsed individually. To support this, loop was added. Functional changes: - Commands with the same level (`check_syntax`, `check_spelling`, ...) can be processed by the make at the same executing call. - New command `port ...` (set a port index). - New command `sphinx ...` (set a command file for Sphinx documentation). - New command `lang ...` (set a language). It was added just to be. TODO: - [ ] Help. - [ ] Commented part of file.

Iliya Katushenock added 1 commit 2023-09-01 01:28:29 +02:00

init 0cbd63b34f

Iliya Katushenock added 1 commit 2023-09-01 01:30:40 +02:00

format 0be172545a

Iliya Katushenock added 1 commit 2023-09-01 01:34:25 +02:00

format e1d3742e4d

Iliya Katushenock changed title from ~~Refactoring: Parsing of all a make flags in loop~~ to Parsing of all a make flags in loop

2023-09-01 03:19:27 +02:00

Aaron Carlisle commented

2023-12-02 21:24:21 +01:00

Would it be simpler to be able to set the port through an environment variable?

This is rather advanced for most people so I am not sure it is worth the extra complexity.

Would it be simpler to be able to set the port through an environment variable? This is rather advanced for most people so I am not sure it is worth the extra complexity.

Aaron Carlisle requested review from Aaron Carlisle 2023-12-02 21:24:31 +01:00

Iliya Katushenock commented

2023-12-03 08:45:31 +01:00

Well, not all people need to change it's port, so not sure if that complexity will be affected on many users.
In another hand, to change port, just one optional flag need to be added (that should be just one line to type instead of changing path variables).
To support ports, feature to support any other flags was added too, hope this might simplify much more sides than make more complicated.

Well, not all people need to change it's port, so not sure if that complexity will be affected on many users. In another hand, to change port, just one optional flag need to be added (that should be just one line to type instead of changing path variables). To support ports, feature to support any other flags was added too, hope this might simplify much more sides than make more complicated.

This pull request has changes conflicting with the target branch.

make.bat

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u support_custom_port:mod_moder-support_custom_port

git checkout mod_moder-support_custom_port

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Parsing of all a make flags in loop #104541

Checkout