blender/blender-manual
23
23
Fork 104
Code Issues 75 Pull Requests 7 Projects 1 Releases Wiki Activity

Nodes Rotation Socket Documentation #104584

Merged
Dalai Felinto merged 15 commits from Sam-Aldhaher/blender-manual:blender-v4.0_rotation_nodes into blender-v4.0-release 2023-10-23 12:19:41 +02:00
Conversation 7 Commits 15 Files Changed 17 +223 -1
Sam Aldhaher commented 2023-10-14 16:41:47 +02:00
Contributor
Copy Link

WIP: this PR adds documentation for the rotation socket nodes
addresses issue: blender/blender#113193

WIP: this PR adds documentation for the rotation socket nodes addresses issue: https://projects.blender.org/blender/blender/issues/113193
Sam Aldhaher added 12 commits 2023-10-14 16:41:50 +02:00
Sam Aldhaher requested review from Dalai Felinto 2023-10-14 16:45:54 +02:00
Dalai Felinto commented 2023-10-16 12:30:36 +02:00
Owner
Copy Link

Hi, thanks for the contribution.

At the moment gitea is having an issue with handling patch with images. We are looking at it.

Hi, thanks for the contribution. At the moment gitea is having [an issue](https://github.com/go-gitea/gitea/issues/17715) with handling patch with images. We are looking at it.
Dalai Felinto requested review from Hans Goudey 2023-10-16 12:31:18 +02:00
Dalai Felinto commented 2023-10-16 12:58:13 +02:00
Owner
Copy Link

Nice work, some comments:

Aligh Euler to Vector Node

image

Question for @HooglyBoogly, why is this Rotation input not using the Rotation socket?

Some of the images were captured while the node was active. This leaves an undesirable white border:

image

Nice work, some comments: --- Aligh Euler to Vector Node ![image](/attachments/b88d5db8-fe39-4722-a9ed-e570dd3bf999) Question for @HooglyBoogly, why is this Rotation input not using the Rotation socket? --- Some of the images were captured while the node was active. This leaves an undesirable white border: ![image](/attachments/5de18d05-9ffd-4d3e-a573-30a79dfcefb9)
image.png
16 KiB
image.png
48 KiB
Hans Goudey reviewed 2023-10-16 13:01:48 +02:00
Hans Goudey left a comment
Member
Copy Link

Question for @HooglyBoogly, why is this Rotation input not using the Rotation socket?

blender/blender#104416 gives a better alternative that uses the rotation socket, there was no time to finish it for 4.0 though.

This looks good to me. The basics are all here!

Might be nice to link to the sections in https://docs.blender.org/manual/en/latest/advanced/appendices/rotations.html to give people somewhere to research these things. But not a big deal not to have that now.

>Question for @HooglyBoogly, why is this Rotation input not using the Rotation socket? blender/blender#104416 gives a better alternative that uses the rotation socket, there was no time to finish it for 4.0 though. --- This looks good to me. The basics are all here! Might be nice to link to the sections in https://docs.blender.org/manual/en/latest/advanced/appendices/rotations.html to give people somewhere to research these things. But not a big deal not to have that now.
Aaron Carlisle requested review from Aaron Carlisle 2023-10-16 19:54:16 +02:00
Aaron Carlisle requested changes 2023-10-16 19:54:34 +02:00
Aaron Carlisle left a comment
Member
Copy Link

https://docs.blender.org/manual/en/latest/interface/controls/nodes/parts.html#sockets

Also needs to be updated.

https://docs.blender.org/manual/en/latest/interface/controls/nodes/parts.html#sockets Also needs to be updated.
Sam Aldhaher commented 2023-10-17 01:20:52 +02:00
Author
Contributor
Copy Link

@Blendify do you know how this figure was generated in https://docs.blender.org/manual/en/latest/interface/controls/nodes/parts.html#sockets?
image

@Blendify do you know how this figure was generated in https://docs.blender.org/manual/en/latest/interface/controls/nodes/parts.html#sockets? ![image](/attachments/7d5f7453-810e-4067-89ac-690b8c510a25)
image.png
48 KiB
image.png
21 KiB
image.png
62 KiB
image.png image.png
Sam Aldhaher added 1 commit 2023-10-17 01:21:26 +02:00
Hans Goudey commented 2023-10-17 10:30:29 +02:00
Member
Copy Link

@Blendify do you know how this figure was generated in https://docs.blender.org/manual/en/latest/interface/controls/nodes/parts.html#sockets?

Wow, I have no idea why this ended up in the manual, that was a UI mockup from https://ui.blender.org/nodes AFAIK.

>@Blendify do you know how this figure was generated in https://docs.blender.org/manual/en/latest/interface/controls/nodes/parts.html#sockets? Wow, I have no idea why this ended up in the manual, that was a UI mockup from https://ui.blender.org/nodes AFAIK.
Sam Aldhaher commented 2023-10-17 14:05:09 +02:00
Author
Contributor
Copy Link

@Blendify do you know how this figure was generated in https://docs.blender.org/manual/en/latest/interface/controls/nodes/parts.html#sockets?

Wow, I have no idea why this ended up in the manual, that was a UI mockup from https://ui.blender.org/nodes AFAIK.

ok thanks, I do not have access to make changes to this UI mockup to add the rotation socket.

Another question regarding the "Axis Angle" rotation, Blender uses "Axis Angle" without a hyphen however the text in Axis Angle Mode uses a hyphen. Also, searching on the web shows that the majority of results use a hyphen, such as Wikipedia . I guess we should stick to using "axis angle" without a hyphen because that's what Blender uses?

> >@Blendify do you know how this figure was generated in https://docs.blender.org/manual/en/latest/interface/controls/nodes/parts.html#sockets? > > Wow, I have no idea why this ended up in the manual, that was a UI mockup from https://ui.blender.org/nodes AFAIK. ok thanks, I do not have access to make changes to this UI mockup to add the rotation socket. Another question regarding the "Axis Angle" rotation, Blender uses "Axis Angle" without a hyphen however the text in [Axis Angle Mode](https://docs.blender.org/manual/en/latest/advanced/appendices/rotations.html#axis-angle-mode) uses a hyphen. Also, searching on the web shows that the majority of results use a hyphen, such as [Wikipedia ](https://en.wikipedia.org/wiki/Axis%E2%80%93angle_representation). I guess we should stick to using "axis angle" without a hyphen because that's what Blender uses?
Sam Aldhaher added 2 commits 2023-10-17 14:30:13 +02:00
Hans Goudey approved these changes 2023-10-18 09:52:30 +02:00
Hans Goudey changed title from WIP: Nodes Rotation Socket Documentation to Nodes Rotation Socket Documentation 2023-10-18 09:52:37 +02:00
Hans Goudey commented 2023-10-18 09:53:34 +02:00
Member
Copy Link

"WIP" generally means a PR isn't ready for review or is still unfinished. I'm assuming that's not the case here. It looks good to me, but maybe Aaron will want to have another look.

"WIP" generally means a PR isn't ready for review or is still unfinished. I'm assuming that's not the case here. It looks good to me, but maybe Aaron will want to have another look.
👍 1
Dalai Felinto merged commit c4398a9f65 into blender-v4.0-release 2023-10-23 12:19:41 +02:00
Dalai Felinto commented 2023-10-23 12:20:03 +02:00
Owner
Copy Link

Merged, thanks Sam! I didn't delete your branch, but feel free to do so.

Merged, thanks Sam! I didn't delete your branch, but feel free to do so.
Sam Aldhaher deleted branch blender-v4.0_rotation_nodes 2023-11-10 01:04:05 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Dalai Felinto
Aaron Carlisle
Hans Goudey
Labels
Clear labels   
Meta
Good First Issue

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
Eevee & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds, Tests & Devices

  
Module
Python API

  
Module
Rendering & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
User Interface

  
Module
VFX & Video

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Information from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Meta
Good First Issue
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Eevee & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds, Tests & Devices
Module
Python API
Module
Rendering & Cycles
Module
Sculpt, Paint & Texture
Module
User Interface
Module
VFX & Video
Priority
High
Priority
Low
Priority
Normal
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Information from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-manual#104584
No description provided.
Delete Branch "Sam-Aldhaher/blender-manual:blender-v4.0_rotation_nodes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?