blender
/
blender-manual
13
18
Fork 73
Code Issues 74 Pull Requests 8 Projects 1 Releases Wiki Activity

Small fix for F-Curve Modifiers docs #104586

Merged
Aaron Carlisle merged 1 commits from Andrej730/blender-manual:fcurve-modifiers-fix into main 2023-10-26 23:45:47 +02:00
Conversation 5 Commits 1 Files Changed 1 +2 -2
Andrej commented 2023-10-15 14:23:06 +02:00
Contributor
Copy Link

Fixed some issue with docs introduced in c06d0abbf6

Fixed some issue with docs introduced in https://projects.blender.org/blender/blender-manual/commit/c06d0abbf652a0f01199946cab0644c07b3aec46
Andrej added 1 commit 2023-10-15 14:23:08 +02:00
473681707f Small fix for F-Curve Modifiers docs 
Fixed some issue with docs introduced in c06d0abbf6
Andrej requested review from Aaron Carlisle 2023-10-15 14:23:34 +02:00
Andrej requested review from Brecht Van Lommel 2023-10-15 14:23:50 +02:00
Brecht Van Lommel commented 2023-10-16 18:41:21 +02:00
Owner
Copy Link

I'll leave this one to @Blendify.

I'll leave this one to @Blendify.
Brecht Van Lommel refused to review 2023-10-16 18:41:26 +02:00
Aaron Carlisle commented 2023-10-16 19:59:07 +02:00
Member
Copy Link

The current docs are correct and align with how these properties are presented in the user interface:

image

The current docs are correct and align with how these properties are presented in the user interface: ![image](/attachments/c79ec2fb-129e-4524-ae67-71ce31e6185c)
image.png
9.8 KiB
Aaron Carlisle closed this pull request 2023-10-16 19:59:07 +02:00
Brecht Van Lommel commented 2023-10-16 20:15:33 +02:00
Owner
Copy Link

Shouldn't the second line say Maximum in the docs?

Shouldn't the second line say Maximum in the docs?
Andrej commented 2023-10-16 20:17:54 +02:00
Author
Contributor
Copy Link

The current docs are correct and align with how these properties are presented in the user interface:

They reflect how properties are presented in UI but do not reflect what they do:

  • current docs say "minimum" twice
  • Cuts a curve off at these frames ranges, and sets their minimum value at those points. is referring to min/max by X axis, not "Minimum X, Y"
  • Truncates the curve values to a range. is referring to min/max by Y axis, not "Minimum X, Y"
> The current docs are correct and align with how these properties are presented in the user interface: They reflect how properties are presented in UI but do not reflect what they do: - current docs say "minimum" twice - `Cuts a curve off at these frames ranges, and sets their minimum value at those points.` is referring to min/max by X axis, not "Minimum X, Y" - ` Truncates the curve values to a range.` is referring to min/max by Y axis, not "Minimum X, Y"
Aaron Carlisle commented 2023-10-16 23:29:06 +02:00
Member
Copy Link

Ah, that is indeed my bad, in the future @Andrej730 include the information in your comment above in the description of the pull request to make it easier for reviews to understand why the changes are being made

Ah, that is indeed my bad, in the future @Andrej730 include the information in your comment above in the description of the pull request to make it easier for reviews to understand why the changes are being made
Aaron Carlisle reopened this pull request 2023-10-16 23:29:07 +02:00
Aaron Carlisle approved these changes 2023-10-26 23:44:39 +02:00
Aaron Carlisle changed title from Small fix for F-Curve Modifiers docs to Small fix for F-Curve Modifiers docs 2023-10-26 23:44:58 +02:00
Blendify changed target branch from main to blender-v4.0-release 2023-10-26 23:44:59 +02:00
Aaron Carlisle changed title from Small fix for F-Curve Modifiers docs to Small fix for F-Curve Modifiers docs 2023-10-26 23:45:27 +02:00
Blendify changed target branch from blender-v4.0-release to main 2023-10-26 23:45:28 +02:00
Aaron Carlisle merged commit fbb3b4eb9a into main 2023-10-26 23:45:47 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Aaron Carlisle
Labels
Clear labels   
Meta
Good First Issue

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
Eevee & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds, Tests & Devices

  
Module
Python API

  
Module
Rendering & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
User Interface

  
Module
VFX & Video

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Information from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Meta
Good First Issue
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Eevee & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds, Tests & Devices
Module
Python API
Module
Rendering & Cycles
Module
Sculpt, Paint & Texture
Module
User Interface
Module
VFX & Video
Priority
High
Priority
Low
Priority
Normal
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Information from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-manual#104586
No description provided.
Delete Branch "Andrej730/blender-manual:fcurve-modifiers-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?