blender/blender-manual
23
23
Fork 104
Code Issues 80 Pull Requests 7 Projects 1 Releases Wiki Activity

theme: add missing reduced-motion user preference query #104748

Merged
Aaron Carlisle merged 1 commits from Tobias/blender-manual:axs into main 2024-04-02 06:10:33 +02:00
Conversation 2 Commits 1 Files Changed 2 +7
Tobias Heinke commented 2024-03-24 15:16:46 +01:00
Member
Copy Link
No description provided.
Tobias Heinke added 1 commit 2024-03-24 15:16:48 +01:00
Tobias Heinke requested review from Aaron Carlisle 2024-03-24 15:17:09 +01:00
Aaron Carlisle commented 2024-03-24 18:12:33 +01:00
Member
Copy Link

Could the animation handling in JS be refractored to css? I see there is some dynamics with the timing but the difference is so little, just make it the same.

Also when submitting a PR please include a description of the change and why.

It's not apparent that this PR adds support for prefers-reduced-motion without having to read through code.

Could the animation handling in JS be refractored to css? I see there is some dynamics with the timing but the difference is so little, just make it the same. Also when submitting a PR please include a description of the change and _why_. It's not apparent that this PR adds support for `prefers-reduced-motion` without having to read through code.
Tobias Heinke changed title from theme: reduced motion to theme: add missing reduced-motion user preference 2024-04-02 05:51:42 +02:00
Tobias Heinke changed title from theme: add missing reduced-motion user preference to theme: add missing reduced-motion user preference query 2024-04-02 05:55:44 +02:00
Tobias Heinke commented 2024-04-02 06:06:52 +02:00
Author
Member
Copy Link

Sure, but this should be part of a bigger refactor (no/ less class properties, toggling event handler really needed?).
It probably needs to be interrupted with requestAnimationFrame or setTimeout to be stable.
So not trivial and requires testing.

Sure, but this should be part of a bigger refactor (no/ less class properties, toggling event handler really needed?). It probably needs to be interrupted with `requestAnimationFrame` or `setTimeout` to be stable. So not trivial and requires testing.
Aaron Carlisle approved these changes 2024-04-02 06:10:08 +02:00
Aaron Carlisle merged commit bfd48811db into main 2024-04-02 06:10:33 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Aaron Carlisle
Labels
Clear labels   
Meta
Good First Issue

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
Eevee & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds, Tests & Devices

  
Module
Python API

  
Module
Rendering & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
User Interface

  
Module
VFX & Video

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Information from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Meta
Good First Issue
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Eevee & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds, Tests & Devices
Module
Python API
Module
Rendering & Cycles
Module
Sculpt, Paint & Texture
Module
User Interface
Module
VFX & Video
Priority
High
Priority
Low
Priority
Normal
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Information from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-manual#104748
No description provided.
Delete Branch "Tobias/blender-manual:axs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?