blender/blender-test-data
0
0
Fork 7
Code Pull Requests 12 Activity

Cycles: Add test for overlapping volumes with different anisotropy #17

Open
Alaska wants to merge 2 commits from overlapping-volume-anisotropy into main
pull from: overlapping-volume-anisotropy
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 4 Commits 2 Files Changed 6 +18
Alaska commented 2024-11-19 07:02:59 +01:00
Member
Copy Link

Thank you to Weizhen Huang for the duck model used in this test

Ref: blender/blender#125595
Ref: blender/blender#123012

Thank you to Weizhen Huang for the duck model used in this test Ref: blender/blender#125595 Ref: blender/blender#123012
Alaska added 1 commit 2024-11-19 07:03:01 +01:00 
Ref: blender/blender#125595
Ref: blender/blender#123012
Alaska requested review from Sergey Sharybin 2024-11-19 07:03:14 +01:00
Alaska requested review from Weizhen Huang 2024-11-19 07:03:15 +01:00
Alaska changed title from Cycles: Add tests for overlapping volumes with different anisotropy to Cycles: Add test for overlapping volumes with different anisotropy 2024-11-19 07:04:28 +01:00
Weizhen Huang approved these changes 2024-11-19 11:58:20 +01:00
Weizhen Huang requested review from Clément Foucault 2024-11-19 11:59:11 +01:00
Sergey Sharybin commented 2024-11-20 10:27:23 +01:00
Owner
Copy Link

Would it make sense to use different colors for volumes? Currently it all boils down to shades of gray, which is much better than nothing, but would we gain some extra coverage by adding some color to the volumes/light?

Would it make sense to use different colors for volumes? Currently it all boils down to shades of gray, which is much better than nothing, but would we gain some extra coverage by adding some color to the volumes/light?
Weizhen Huang commented 2024-11-20 11:41:10 +01:00
Member
Copy Link

I think it would be good to add color to the volume. In my PR I was not sure if the weight should consider the color or not, it would be good to test it.

I think it would be good to add color to the volume. In my PR I was not sure if the weight should consider the color or not, it would be good to test it.
Alaska commented 2024-11-20 12:47:07 +01:00
Author
Member
Copy Link

I will update the test with colours and include a "before fix" and "after fix" image in a comment just for comparison

I will update the test with colours and include a "before fix" and "after fix" image in a comment just for comparison
👍 1 ❤️ 1
Alaska added 1 commit 2024-11-20 14:01:59 +01:00 
- Add colour (as requested by Sergey and Weizhen)
  - The colours are orange and blue
- Enabled volumetric shadows in EEVEE Next
- Change the volume shape to make it cuter (Uses a modified duck created by Weizhen)
- Enabled ZSTD compression on the .blend file
Alaska commented 2024-11-20 14:04:09 +01:00
Author
Member
Copy Link

I've updated the test. I used Weizhen's duck to give some cute context to the colours.

I have attached before (4.2) and after (4.3) pictures.

Note: EEVEE Next seems to render the scene a bit weird. It renders fine from the UI, but command line rendering (as used in the test) causes it to render quite washed out. Maybe @fclem wants to look into that?

Note: I used the OpenGL backend for generating the EEVEE next images on a NVIDIA RTX 4090.

I've updated the test. I used Weizhen's duck to give some cute context to the colours. I have attached before (4.2) and after (4.3) pictures. Note: EEVEE Next seems to render the scene a bit weird. It renders fine from the UI, but command line rendering (as used in the test) causes it to render quite washed out. Maybe @fclem wants to look into that? Note: I used the OpenGL backend for generating the EEVEE next images on a NVIDIA RTX 4090.
4.2.jpg
19 KiB
4.3.jpg
19 KiB
4.2.jpg 4.3.jpg
❤️ 1
Merge conflict checking is in progress. Try again in few moments.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin overlapping-volume-anisotropy:overlapping-volume-anisotropy
git checkout overlapping-volume-anisotropy
Sign in to join this conversation.
Reviewers
No reviewers
Sergey Sharybin
Weizhen Huang
Clément Foucault
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-test-data#17
No description provided.
Delete Branch "overlapping-volume-anisotropy"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?