blender/blender-test-data
0
0
Fork 7
Code Pull Requests 11 Activity

Cycles: Add render test for shadow linking on point clouds #19

Open
Alaska wants to merge 1 commits from shadow-linking-point-cloud into main
pull from: shadow-linking-point-cloud
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 3 Commits 1 Files Changed 6 +18
Alaska commented 2024-11-19 11:18:01 +01:00
Member
Copy Link

Having a test like this was found to be useful during
blender/blender!125803

And a test like this will be useful in case of future BVH changes
or refactors.

Ref: blender/blender#123012

Having a test like this was found to be useful during blender/blender!125803 And a test like this will be useful in case of future BVH changes or refactors. Ref: blender/blender#123012
Alaska added 1 commit 2024-11-19 11:18:02 +01:00 
Having a test like this was found to be useful during
blender/blender!125803

And a test like this will be useful in case of refactors or in the case
HIP-RT adds native point cloud support.
Alaska commented 2024-11-19 11:19:11 +01:00
Author
Member
Copy Link

Just for reference, without the fix in blender/blender!125803, everything would cast shadows, no matter the shadow linking settings.

I plan to add a test for shadow linking with curves as well (Another feature that wasn't tested, but needed to be tested during the development of blender/blender!125803), should I create a seperate PR or add the tests to this one?

Just for reference, without the fix in blender/blender!125803, everything would cast shadows, no matter the shadow linking settings. I plan to add a test for shadow linking with curves as well (Another feature that wasn't tested, but needed to be tested during the development of blender/blender!125803), should I create a seperate PR or add the tests to this one?
Alaska requested review from Sergey Sharybin 2024-11-19 11:19:32 +01:00
Alaska requested review from Weizhen Huang 2024-11-19 11:19:32 +01:00
Sergey Sharybin commented 2024-11-19 11:47:42 +01:00
Owner
Copy Link

should I create a separate PR or add the tests to this one?

I don't have strong opinion.
It you think you'd need extra time for curves tests, then landing what you already have I good. And if you feel that it wouldn't take long time and that it's easier for you to manage as a single PR then do it in this PR :)

> should I create a separate PR or add the tests to this one? I don't have strong opinion. It you think you'd need extra time for curves tests, then landing what you already have I good. And if you feel that it wouldn't take long time and that it's easier for you to manage as a single PR then do it in this PR :)
Sergey Sharybin approved these changes 2024-11-19 11:48:36 +01:00
Alaska commented 2024-11-19 13:24:08 +01:00
Author
Member
Copy Link

I will handle curves seperately due to differences between different BVH options, and so will have to do more thorough testing localling on all my computers.

I will handle curves seperately due to differences between different BVH options, and so will have to do more thorough testing localling on all my computers.
Merge conflict checking is in progress. Try again in few moments.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin shadow-linking-point-cloud:shadow-linking-point-cloud
git checkout shadow-linking-point-cloud
Sign in to join this conversation.
Reviewers
No reviewers
Weizhen Huang
Sergey Sharybin
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-test-data#19
No description provided.
Delete Branch "shadow-linking-point-cloud"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?