blender/blender-test-data
0
0
Fork 7
Code Pull Requests 11 Activity

Render: Add tests for shadow linking with curves #21

Open
Alaska wants to merge 1 commits from curve-shadow-linking into main
pull from: curve-shadow-linking
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 1 Commits 1 Files Changed 12 +36
Alaska commented 2024-11-21 09:17:11 +01:00
Member
Copy Link

Having a test like this was found to be useful during
blender/blender!125803

And a test like this will be useful in case of future BVH changes
or refactors.

Ref: blender/blender#123012

Having a test like this was found to be useful during blender/blender!125803 And a test like this will be useful in case of future BVH changes or refactors. Ref: blender/blender#123012
Alaska added 1 commit 2024-11-21 09:17:13 +01:00 
Having a test like this was found to be useful during
blender/blender!125803

And a test like this will be useful in case of future BVH changes
or refactors.

Ref: blender/blender#123012
Alaska requested review from Sergey Sharybin 2024-11-21 09:17:23 +01:00
Alaska requested review from Weizhen Huang 2024-11-21 09:17:23 +01:00
Alaska commented 2024-11-21 09:19:45 +01:00
Author
Member
Copy Link

Testing here with:
CPU, CUDA, OptiX, HIP, HIPRT, oneAPI, oneAPI with Embree, Metal, MetalRT, they all passed.

Most of them were pixel perfect, with the exception of MetalRT which has some unexpected light leaking (see attached image). But it does still pass.

Testing here with: CPU, CUDA, OptiX, HIP, HIPRT, oneAPI, oneAPI with Embree, Metal, MetalRT, they all passed. Most of them were pixel perfect, with the exception of MetalRT which has some unexpected light leaking (see attached image). But it does still pass.
MetalRT curve light leaking.png
247 KiB
MetalRT curve light leaking.png
Sergey Sharybin approved these changes 2024-11-21 11:02:41 +01:00
Sergey Sharybin left a comment
Owner
Copy Link

Looks good!

We can look into quality of the feature on MetalRT separately. No need to block the addition of test with it.

Looks good! We can look into quality of the feature on MetalRT separately. No need to block the addition of test with it.
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin curve-shadow-linking:curve-shadow-linking
git checkout curve-shadow-linking
Sign in to join this conversation.
Reviewers
No reviewers
Weizhen Huang
Sergey Sharybin
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-test-data#21
No description provided.
Delete Branch "curve-shadow-linking"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?