blender/blender-test-data
0
0
Fork 7
Code Pull Requests 11 Activity

Add more transparent shadow bounces render tests #9

Open
Alaska wants to merge 3 commits from Alaska/blender-test-data:add-more-transparent-shadows-test into main
pull from: Alaska/blender-test-data:add-more-transparent-shadows-test
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 3 Commits 3 Files Changed 24 +72
Alaska commented 2024-08-12 08:05:52 +02:00
Member
Copy Link

Test more combinations of rendering transparent shadows with different
bounce limits.

Ref:
blender/blender#123012
blender/blender#125093

Test more combinations of rendering transparent shadows with different bounce limits. Ref: blender/blender#123012 blender/blender#125093
Alaska added 1 commit 2024-08-12 08:05:53 +02:00
Alaska commented 2024-08-12 08:06:09 +02:00
Author
Member
Copy Link

WIP because I need to generate the other reference images (E.g. EEVEE).

~~WIP because I need to generate the other reference images (E.g. EEVEE).~~
Alaska requested review from Sergey Sharybin 2024-08-12 08:06:24 +02:00
Alaska requested review from Weizhen Huang 2024-08-12 08:06:24 +02:00
Alaska changed title from WIP: Add more transparent shadow bounces render tests to Add more transparent shadow bounces render tests 2024-08-12 10:30:03 +02:00
Weizhen Huang commented 2024-08-12 10:30:06 +02:00
Member
Copy Link

Do we need so many tests for transparent shadows?

Do we need so many tests for transparent shadows?
Alaska added 1 commit 2024-08-12 10:30:25 +02:00
Alaska commented 2024-08-12 10:33:25 +02:00
Author
Member
Copy Link

Probably not. But considering the circumstances that cause blender/blender#125093 I wanted to wide range of cases.

If we had to reduce the number of tests, I believe we should go with:
0 transparent bounces
1 transparent bounce
1024 transparent bounces
and one of the inbetween ones (E.g. 400, 700)

What are your thoughts?

Probably not. But considering the circumstances that cause blender/blender#125093 I wanted to wide range of cases. If we had to reduce the number of tests, I believe we should go with: 0 transparent bounces 1 transparent bounce 1024 transparent bounces and one of the inbetween ones (E.g. 400, 700) What are your thoughts?
Alaska added 1 commit 2024-08-12 12:34:49 +02:00
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u add-more-transparent-shadows-test:Alaska-add-more-transparent-shadows-test
git checkout Alaska-add-more-transparent-shadows-test
Sign in to join this conversation.
Reviewers
No reviewers
Sergey Sharybin
Weizhen Huang
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-test-data#9
No description provided.
Delete Branch "Alaska/blender-test-data:add-more-transparent-shadows-test"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?