Geometry Nodes in searching pulls nodes from other node add-ons #101259

New Issue

kursad k · 2022-09-21T20:16:46+02:00

kursad k commented

2022-09-21 20:16:46 +02:00

System Information
Operating system: Windows 11

Blender Version
Broken: 3.4-6f15141f2731
Worked: 3.2, 3.3

Not bisected but I suspect bdb5754147

Short description of error

Searching for a node brings nodes from other node addons.

Exact steps for others to reproduce the error

Install Sverchok nightly: https://github.com/nortikin/sverchok#installation
Install Blender 3.4 nightly
Add an object
Add a geonode modifier
Search for "random" node (see the attached video for the reference)

blender_vh4ZUevmqh.mp4

**System Information** Operating system: Windows 11 **Blender Version** Broken: 3.4-6f15141f2731 Worked: 3.2, 3.3 Not bisected but I suspect bdb5754147 **Short description of error** Searching for a node brings nodes from other node addons. **Exact steps for others to reproduce the error** - Install Sverchok nightly: https://github.com/nortikin/sverchok#installation - Install Blender 3.4 nightly - Add an object - Add a geonode modifier - Search for "random" node (see the attached video for the reference) [blender_vh4ZUevmqh.mp4](https://archive.blender.org/developer/F13546474/blender_vh4ZUevmqh.mp4)

kursad k commented

2022-09-21 20:16:46 +02:00

Added subscriber: @kursadk

blender-admin commented

2022-09-21 20:16:46 +02:00

#101390 was marked as duplicate of this issue

kursad k changed title from ~~Geometry Nodes pulls nodes from other node add-ons~~ to Geometry Nodes in searching pulls nodes from other node add-ons

2022-09-21 20:17:28 +02:00

Pratik Borhade commented

2022-09-22 04:01:38 +02:00

Added subscribers: @HooglyBoogly, @persun, @PratikPB2123

Pratik Borhade commented

2022-09-22 04:01:38 +02:00

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Pratik Borhade commented

2022-09-22 04:01:38 +02:00

HI, thanks for the report. Looks like multiple add-ons has been affected by bdb5754147
@HooglyBoogly , could you take a look?
Another similar report: #101238 (LuxCore nodes are exposed in search menus of other node systems)

HI, thanks for the report. Looks like multiple add-ons has been affected by bdb5754147 @HooglyBoogly , could you take a look? Another similar report: #101238 (LuxCore nodes are exposed in search menus of other node systems)

kursad k commented

2022-09-22 05:42:56 +02:00

According to the diffusion this fix (https://developer.blender.org/rB77dcfac8a38d81b3ed6dd5b6c85f80a31ecc562b) was in the September 22, 04:26:29 20dc839319 build, however my testing shows that this is still broken.

283.62MB

According to the diffusion this fix (https://developer.blender.org/rB77dcfac8a38d81b3ed6dd5b6c85f80a31ecc562b) was in the September 22, 04:26:29 20dc8393192f build, however my testing shows that this is still broken. 283.62MB

Jesse Yurkovich commented

2022-09-27 09:17:27 +02:00

Added subscriber: @genesis2303

Hans Goudey self-assigned this 2022-09-27 15:29:00 +02:00

Hans Goudey commented

2022-09-27 19:22:03 +02:00

I've found the issue with Sverchok nodes showing up in their search is the order of mixins in their node class definitions.
SverchokNode(SverchCustomTreeNode, bpy.types.Node) works, but SverchokNode(bpy.types.Node, SverchCustomTreeNode) doesn't.
I'm assuming bpy.types.Node defines some standard function that just returns true. For the latter order, the Sverchok poll is never found.

Blender didn't really call these poll functions before, now they are used for determining which nodes appear in the search as well.

The polls are incorrect when called from Python as well. A fix in Sverchok is as simple as switching the order in the node class definitions.

I've found the issue with Sverchok nodes showing up in their search is the order of mixins in their node class definitions. `SverchokNode(SverchCustomTreeNode, bpy.types.Node)` works, but `SverchokNode(bpy.types.Node, SverchCustomTreeNode)` doesn't. I'm assuming bpy.types.Node defines some standard function that just returns true. For the latter order, the Sverchok poll is never found. Blender didn't really call these poll functions before, now they are used for determining which nodes appear in the search as well. The polls are incorrect when called from Python as well. A fix in Sverchok is as simple as switching the order in the node class definitions.

Sergey commented

2022-09-27 19:52:38 +02:00

Added subscriber: @randum

Sergey commented

2022-09-27 19:52:38 +02:00

Yes, it's known problem in Sverchok but we didn't prioritize it because custom nodes were not take into in build-in editors before. If custom nodes are allowed in build-in editors we of cause will fix the inheritance problem.

By the way do you know the source of this common mistake?)) It is from Blender templates.

Yes, it's known problem in Sverchok but we didn't prioritize it because custom nodes were not take into in build-in editors before. If custom nodes are allowed in build-in editors we of cause will fix the inheritance problem. By the way do you know the source of this common mistake?)) It is from Blender templates. ![image.png](https://archive.blender.org/developer/F13582831/image.png)

Hans Goudey commented

2022-09-27 20:07:23 +02:00

For what it's worth, a simple find and replace SverchCustomTreeNode, bpy.types.Node -> bpy.types.Node, SverchCustomTreeNode solved the problem for me. I was going to verify it and submit a PR, but I wasn't sure how to make the zipped addon from Sverchok source. The package script ended up creating a 108 GB zip before I killed it :P

We should definitely fix the template!

For what it's worth, a simple find and replace `SverchCustomTreeNode, bpy.types.Node` -> `bpy.types.Node, SverchCustomTreeNode` solved the problem for me. I was going to verify it and submit a PR, but I wasn't sure how to make the zipped addon from Sverchok source. The package script ended up creating a 108 GB zip before I killed it :P We should definitely fix the template!

Sergey commented

2022-09-27 20:29:33 +02:00

It would be nice to have a commit from one of the Blender developers ^_^

As far as I know, on GitHub, you have to fork repository (via Browser), clone it to local machine, commit changes, push them to the fork and after that it will possible to create PR from the fork to main repository. But probably there is another approach.

But if you does not have time I can take care of it, of cause.

It would be nice to have a commit from one of the Blender developers ^_^ As far as I know, on GitHub, you have to fork repository (via Browser), clone it to local machine, commit changes, push them to the fork and after that it will possible to create PR from the fork to main repository. But probably there is another approach. But if you does not have time I can take care of it, of cause.

kursad k commented

2022-09-29 18:43:17 +02:00

Added subscriber: @OmarEmaraDev

kursad k commented

2022-09-29 18:43:17 +02:00

@OmarEmaraDev Animation Nodes litters the GeoNodes search box results as well unfortunately.

Omar Emara commented

2022-09-30 09:16:17 +02:00

@kursadk Will take care of that later today.

kursad k commented

2022-09-30 21:34:31 +02:00

@OmarEmaraDev Thanks for the fix.

Pratik Borhade commented

2022-10-13 05:32:23 +02:00

Changed status from 'Needs Developer To Reproduce' to: 'Confirmed'

Hans Goudey commented

2022-12-20 07:10:56 +01:00

Changed status from 'Confirmed' to: 'Archived'

Hans Goudey closed this issue

2022-12-20 07:10:56 +01:00

Hans Goudey commented

2022-12-20 07:10:56 +01:00

If this is happening with an addon, the node poll functions are most likely incorrect as mentioned above. Since there's nothing to be done internally, I'll close this report.

Christoph Lendenfeld referenced this issue

2023-02-10 11:56:22 +01:00

Blender LTS: Maintenance Task 3.3 #100749

Pratik Borhade referenced this issue

2023-02-16 13:31:32 +01:00

Custom nodes appear in search results for tree types that don't support them #104313

Philipp Oeser referenced this issue

2023-03-27 10:58:59 +02:00

Regression: Search in shader node editor exposes nodes that are not available in the current renderer #106138

Sign in to join this conversation.