Sculpt Mode: Cavity Inverted consistency #102437

Open
opened 2022-11-11 15:52:01 +01:00 by Julien Kaspar · 9 comments
Member

(NOTE) This task is part of the community & sub tasks of the workboard. Anyone is free to pick up this task and contribute. For any questions or needed reviewers, please tag @Sergey @HooglyBoogly and @JulienKaspar.

Issue

The "Cavity" and "Cavity (Inverted)" auto-masking options are presented as toggles, when they are in fact mutually exclusive.
This is not ideal, sicne it breaks consistency with the UI design.

image.png

This was done so the pie menu on Alt-A is more convenient to use.
Whatever the solution, we need to make sure the pie menu stays unaffected in its usability.

image.png

Proposal

In the auto-masking panel we can make the "Cavity (Inverted)" toggle a sub-setting of "Cavity"

For the pie menu we just need to make sure that it remains unchanged.
This could be for example done by making the pie menu execute operators make sure the "Cavity" and "Invert" toggles are set correctly.

(NOTE) This task is part of the community & sub tasks of the workboard. Anyone is free to pick up this task and contribute. For any questions or needed reviewers, please tag @Sergey @HooglyBoogly and @JulienKaspar. # Issue The "Cavity" and "Cavity (Inverted)" auto-masking options are presented as toggles, when they are in fact mutually exclusive. This is not ideal, sicne it breaks consistency with the UI design. ![image.png](https://archive.blender.org/developer/F13891700/image.png) This was done so the pie menu on `Alt-A` is more convenient to use. Whatever the solution, we need to make sure the pie menu stays unaffected in its usability. ![image.png](https://archive.blender.org/developer/F13891734/image.png) # Proposal In the auto-masking panel we can make the "Cavity (Inverted)" toggle a sub-setting of "Cavity" For the pie menu we just need to make sure that it remains unchanged. This could be for example done by making the pie menu execute operators make sure the "Cavity" and "Invert" toggles are set correctly.
Author
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Author
Member

Added subscribers: @JulienKaspar, @JosephEagar

Added subscribers: @JulienKaspar, @JosephEagar
Author
Member

I'm raising the priority since we aim to have this in 3.5.

I'm raising the priority since we aim to have this in 3.5.
Joseph Eagar was assigned by Julien Kaspar 2022-11-17 12:02:05 +01:00
Author
Member

Assigned to @JosephEagar like we mentioned in the recent meeting notes.

Assigned to @JosephEagar like we mentioned in the recent meeting notes.
Author
Member

As discussed in the recent module meeting, the priority will be lowered.
We'll see when this task can be handled but for the major functionality of the feature it's not vital.

As discussed in the recent module meeting, the priority will be lowered. We'll see when this task can be handled but for the major functionality of the feature it's not vital.
Julien Kaspar added this to the Sculpt, Paint & Texture project 2023-02-08 10:48:52 +01:00
Joseph Eagar was unassigned by Julien Kaspar 2023-02-09 16:47:54 +01:00
Author
Member

I removed the assignees as this is not active at the moment.
It's free for anyone to pick up.

I removed the assignees as this is not active at the moment. It's free for anyone to pick up.
Philipp Oeser removed the
Interest
Sculpt, Paint & Texture
label 2023-02-10 09:10:57 +01:00

Hi @JulienKaspar , would it be possible to be assigned to this issue? I'm looking for a first issue to work on.
I've tried looking into the issue, to my understanding, the UI elements are being handled by python scripts, but the backend, including the unticking of the boxes, is being handled by the rna files. Is this correct?
If this is correct, would creating 2 new 'EnumPropertyItem' objects in the rna files for the auto-masking panel be an appropriate solution?
Also, I saw that the code for the menu is present in two files:

  • space_view3d.py and properties_paint_common.py on the scripts side
  • rna_brush.c and rna_sculpt_paint.c on the rna side

Is the code in the second set of files targeting another menu?

Thank you for your time and my apologies if something was mentioned in the docs and I missed it.

Hi @JulienKaspar , would it be possible to be assigned to this issue? I'm looking for a first issue to work on. I've tried looking into the issue, to my understanding, the UI elements are being handled by python scripts, but the backend, including the unticking of the boxes, is being handled by the rna files. Is this correct? If this is correct, would creating 2 new '`EnumPropertyItem`' objects in the rna files for the auto-masking panel be an appropriate solution? Also, I saw that the code for the menu is present in two files: * `space_view3d.py` and `properties_paint_common.py` on the scripts side * `rna_brush.c` and `rna_sculpt_paint.c` on the rna side Is the code in the second set of files targeting another menu? Thank you for your time and my apologies if something was mentioned in the docs and I missed it.

Hi @JulienKaspar first attempt at a PR. Here it is, what do you think? (#105718)

Hi @JulienKaspar first attempt at a PR. Here it is, what do you think? (#105718)
Author
Member

@Rushabh-Shah @ProCrow FYI I'm unavailable for the month of March. Reach out to @JosephEagar for info and help 👍

@Rushabh-Shah @ProCrow FYI I'm unavailable for the month of March. Reach out to @JosephEagar for info and help 👍
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#102437
No description provided.