WIP: Issue Sculpt Mode: Cavity Inverted consistency #102437 #105718

ProCrow · 2023-03-13T13:39:30+01:00

ProCrow commented

2023-03-13 13:39:30 +01:00

First-time contributor

Sculpt Mode: Cavity Inverted consistency #102437

As requested, Cavity (inverted) Is no longer a toggle and is now a sub-setting of Cavity now named Inverted. Adhering to the UI design it functions in the same way Occlusion does under View Normal in the Auto-Masking panel.

The Pie menu has not been changed. Although, if Cavity (Inverted) is selected, both it and Cavity are enabled as it is now a sub-setting and no longer a toggle.

Sculpt Mode: Cavity Inverted consistency #102437 As requested, `Cavity (inverted)` Is no longer a toggle and is now a sub-setting of Cavity now named `Inverted`. Adhering to the UI design it functions in the same way `Occlusion` does under `View Normal` in the Auto-Masking panel. The Pie menu has not been changed. Although, if `Cavity (Inverted)` is selected, both it and `Cavity` are enabled as it is now a sub-setting and no longer a toggle.

Before.png

217 KiB

After.png

192 KiB

Pie.png

91 KiB

🚀 1

ProCrow added 1 commit 2023-03-13 13:39:41 +01:00

a1efc1d688 Issue Sculpt Mode: Cavity Inverted consistency #102437

ProCrow referenced this pull request

2023-03-13 13:43:33 +01:00

Sculpt Mode: Cavity Inverted consistency #102437

Brecht Van Lommel added this to the Sculpt, Paint & Texture project 2023-03-17 12:43:52 +01:00

Brecht Van Lommel requested review from Joseph Eagar 2023-03-17 12:44:07 +01:00

Brecht Van Lommel requested review from Julien Kaspar 2023-03-17 12:44:07 +01:00

Julien Kaspar added the

Module

Sculpt, Paint & Texture

label 2023-03-28 20:06:35 +02:00

Julien Kaspar requested changes 2023-04-07 21:01:40 +02:00

Julien Kaspar left a comment

Thanks for working on the PR! I tested it and it sort of works like expected. But now getting to use it, it reveals some issues with the design:

Having the "Cavity" & "Cavity (inverted)" exposed as a sub-setting AND toggling it like a mutually exclusive setting is very confusing.
Toggling the "Inverted" settings when the "Cavity" toggle is disabled is not ideal
This also leads to additional steps in the pie menu interaction.

I think overall the previous behavior was more intuitive.
So I have two suggestions:

A:
Do not toggle the "Inverted" sub-setting when "Cavity" is toggled.
It's also important that the pie menu items stay mutually exclusive and are not enabled at the same time. This would mean that the pie menu and the panel settings behave fundamentally different, which could be harder to achieve in the code and confusing a bit confusing in the UI.

B:
I also talked with @pablovazquez and agreed on radio buttons, so that the options can remain mutually exclusive both in the panel and pie menu, without breaking UI conventions.
This would also push the button to create a cavity mask further down because of lack of space.
(See mockup below. Note that I used the naming convention of "Ridge" & "Valley" fronm the Cavity Shading. Ridge in this case is the equivilant of Inverted cavity)

Sorry for the wait and for a bit of an unclear design. I hope this answer gives some clearer direction and options if suggestion A doesn't work out.

Thanks for working on the PR! I tested it and it sort of works like expected. But now getting to use it, it reveals some issues with the design: Having the "Cavity" & "Cavity (inverted)" exposed as a sub-setting AND toggling it like a mutually exclusive setting is very confusing. Toggling the "Inverted" settings when the "Cavity" toggle is disabled is not ideal This also leads to additional steps in the pie menu interaction. I think overall the previous behavior was more intuitive. So I have two suggestions: A: Do not toggle the "Inverted" sub-setting when "Cavity" is toggled. It's also important that the pie menu items stay mutually exclusive and are not enabled at the same time. This would mean that the pie menu and the panel settings behave fundamentally different, which could be harder to achieve in the code and confusing a bit confusing in the UI. B: I also talked with @pablovazquez and agreed on radio buttons, so that the options can remain mutually exclusive both in the panel and pie menu, without breaking UI conventions. This would also push the button to create a cavity mask further down because of lack of space. (See mockup below. Note that I used the naming convention of "Ridge" & "Valley" fronm the Cavity Shading. Ridge in this case is the equivilant of Inverted cavity) Sorry for the wait and for a bit of an unclear design. I hope this answer gives some clearer direction and options if suggestion A doesn't work out.

cavity_consistency_test3.jpg

90 KiB

Pablo Vazquez commented

2023-05-24 12:54:57 +02:00

Hey @ProCrow did you get a chance to look into this? Thanks!

Daniel Bystedt changed title from ~~Issue Sculpt Mode: Cavity Inverted consistency #102437~~ to WIP: Issue Sculpt Mode: Cavity Inverted consistency #102437

2024-04-16 16:51:37 +02:00

This pull request has changes conflicting with the target branch.

source/blender/makesrna/intern/rna_sculpt_paint.c

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u my-feature:ProCrow-my-feature

git checkout ProCrow-my-feature

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

WIP: Issue Sculpt Mode: Cavity Inverted consistency #102437 #105718

Checkout