Set Curve Radius is Effecting Bounding Box of Curves #103387

Closed
opened 2022-12-21 21:44:07 +01:00 by Gerstmann Bradley · 18 comments

System Information
Operating system: Windows-10-10.0.17134-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 466.11

Blender Version
Broken: version: 3.5.0 Alpha, branch: master, commit date: 2022-12-21 15:03, hash: 51e2ce7df5
Worked: 3.4 and before

Behaviour changed in e8f4010611

Short description of error
image.png

I assume it's taking "Curve Points" into account, but here I am evaluating Curves not Curves Points. This behavior is not seen before 3.5. Is this a bug or a change implemented?
I don't think it's expected to evaluate Curve Points when I am inputting Curves and trying to get Curve's bounding box.

**System Information** Operating system: Windows-10-10.0.17134-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 970M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 466.11 **Blender Version** Broken: version: 3.5.0 Alpha, branch: master, commit date: 2022-12-21 15:03, hash: `51e2ce7df5` Worked: 3.4 and before Behaviour changed in e8f4010611 **Short description of error** ![image.png](https://archive.blender.org/developer/F14081149/image.png) I assume it's taking "Curve Points" into account, but here I am evaluating Curves not Curves Points. This behavior is not seen before 3.5. Is this a bug or a change implemented? I don't think it's expected to evaluate Curve Points when I am inputting Curves and trying to get Curve's bounding box.

Added subscriber: @Bradley_G

Added subscriber: @Bradley_G

blender/blender-addons#103974 was marked as duplicate of this issue

blender/blender-addons#103974 was marked as duplicate of this issue

#103566 was marked as duplicate of this issue

#103566 was marked as duplicate of this issue

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Added subscribers: @HooglyBoogly, @lichtwerk

Added subscribers: @HooglyBoogly, @lichtwerk
Member

Changed status from 'Confirmed' to: 'Needs Developer To Reproduce'

Changed status from 'Confirmed' to: 'Needs Developer To Reproduce'
Member

Behaviour changed in e8f4010611

But doesnt it make sense to have the bounding box change on curve radius changes?

CC @HooglyBoogly , opinions?

Behaviour changed in e8f4010611 But doesnt it make sense to have the bounding box change on curve radius changes? CC @HooglyBoogly , opinions?

Added subscribers: @baoyu, @PratikPB2123, @mod_moder

Added subscribers: @baoyu, @PratikPB2123, @mod_moder

Found 10 days earlier than duplicate

Found 10 days earlier than duplicate
Member

Thx finding the duplicate @mod_moder !

Lets keep it on High prio then to get an answer quick.

Thx finding the duplicate @mod_moder ! Lets keep it on High prio then to get an answer quick.
Member

I'm not sure what to do here unfortunately. The problem is sort of because of the curves/legacy curves problem, since the new curves are at least intended to be drawn with the radius so the bounds make sense. Since the old curves are just drawn as wires, it doesn't really make sense in cases like this. But I'm not sure if we can vary the behavior depending on the object type.

I wish the bounds could be computed more simply (without evaluating the curves and without including the radius) since that would be much faster, but I think the bounds are used to determine viewport culling so I'm not sure that's possible.

I'm not sure what to do here unfortunately. The problem is sort of because of the curves/legacy curves problem, since the new curves are at least intended to be drawn with the radius so the bounds make sense. Since the old curves are just drawn as wires, it doesn't really make sense in cases like this. But I'm not sure if we can vary the behavior depending on the object type. I wish the bounds could be computed more simply (without evaluating the curves and without including the radius) since that would be *much* faster, but I think the bounds are used to determine viewport culling so I'm not sure that's possible.

Added subscriber: @mano-wii

Added subscriber: @mano-wii

I feel like the draw culling can actually be impaired if the bounds are not calculated based on what is seen.
For new curves it makes sense to use the radius, as the user can see this radius in action,
but for the old ones, this radius is not visible and the bounds is misleading.

I feel like the draw culling can actually be impaired if the bounds are not calculated based on what is seen. For new curves it makes sense to use the radius, as the user can see this radius in action, but for the old ones, this radius is not visible and the bounds is misleading.
Member

We talked about this briefly in the geometry nodes module meeting. The best idea we had was adding an option like "Use Radius" to the node so users could have control of this behavior.

We talked about this briefly in the geometry nodes module meeting. The best idea we had was adding an option like "Use Radius" to the node so users could have control of this behavior.
Member

Added subscriber: @purplemeanie

Added subscriber: @purplemeanie

@HooglyBoogly, thanks for sorting out my duplicate. Apologies, I looked but didn't spot this original task.

@HooglyBoogly, thanks for sorting out my duplicate. Apologies, I looked but didn't spot this original task.
Member

No worries, thanks for the report!

No worries, thanks for the report!

Added subscriber: @renderart

Added subscriber: @renderart
Philipp Oeser removed the
Interest
Nodes & Physics
label 2023-02-10 08:43:17 +01:00
Brecht Van Lommel added this to the 3.5 milestone 2023-02-15 10:26:17 +01:00
Hans Goudey self-assigned this 2023-02-20 23:16:30 +01:00
Hans Goudey added
Status
Confirmed
Type
Bug
and removed
Status
Needs Info from Developers
Type
Report
labels 2023-02-23 21:20:54 +01:00
Blender Bot added
Status
Resolved
and removed
Status
Confirmed
labels 2023-02-27 00:01:16 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
9 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#103387
No description provided.