Remove unnecessary mesh position copying #103789

New Issue

Hans Goudey · 2023-01-10T18:47:02+01:00

Hans Goudey commented

2023-01-10 18:47:02 +01:00

Before mesh positions were a generic attribute, they were often copied into a separate array.
This has a performance cost and can now be removed.

Remove uses of BKE_mesh_vert_coords_alloc
Remove uses of BKE_mesh_vert_coords_get
Remove uses of BKE_mesh_vert_coords_apply_with_mat4
Remove uses of BKE_mesh_vert_coords_apply

Before mesh positions were a generic attribute, they were often copied into a separate array. This has a performance cost and can now be removed. - [ ] Remove uses of `BKE_mesh_vert_coords_alloc` - [x] Remove uses of `BKE_mesh_vert_coords_get` - [ ] Remove uses of `BKE_mesh_vert_coords_apply_with_mat4` - [ ] Remove uses of `BKE_mesh_vert_coords_apply`

Hamza self-assigned this 2023-01-16 20:36:54 +01:00

Hamza commented

2023-01-16 20:36:54 +01:00

I want to work on this as someone new to the blender developer community. If someone can provide some more information about this problem please let me know.

More specifically:
any documentation pages related to this issue
files, classes or packages to be modified.

What I plan on doing is to look in the code for usage of BKE_mesh_vert_coords_* and try to understand the context in which these are used.

I want to work on this as someone new to the blender developer community. If someone can provide some more information about this problem please let me know. More specifically: any documentation pages related to this issue files, classes or packages to be modified. What I plan on doing is to look in the code for usage of BKE_mesh_vert_coords_* and try to understand the context in which these are used.

Iliya Katushenock commented

2023-01-16 20:42:08 +01:00

It seems that you should take into account the work already begun in this area D16971: Mesh: Avoid copying positions in object mode modifier stack .
I mean, there are probably so many places that need to be cleaned up, and if you join the work, there will be more than one person doing it.

It seems that you should take into account the work already begun in this area [D16971: Mesh: Avoid copying positions in object mode modifier stack](https://archive.blender.org/developer/D16971) . I mean, there are probably so many places that need to be cleaned up, and if you join the work, there will be more than one person doing it.

Hamza commented

2023-01-16 20:50:44 +01:00

So are you suggesting that I should look for a different "good first issue" as two people working on this issue might cause trouble? or are you suggesting two people working on this might be better?

Iliya Katushenock commented

2023-01-16 20:52:36 +01:00

Not really, it's just that if several people do the task, I'm not sure who will be the claimer.

And also, you can study the previously done work as an example.

Also, it will be convenient if you have questions, ask them in the chat.

Not really, it's just that if several people do the task, I'm not sure who will be the claimer. And also, you can study the previously done work as an example. Also, it will be convenient if you have questions, ask them in the chat.

Hamza removed their assignment 2023-01-16 20:55:52 +01:00

Hamza commented

2023-01-16 20:55:52 +01:00

I saw no one was the claimer here so I claimed it. I can release and find something else to work on.

Iliya Katushenock commented

2023-01-16 20:57:54 +01:00

I really don't want to scare you away from this task. Also, I will give an example of another task that required a lot of work. Pay attention, several people did it #95965 (Mesh Struct of Arrays Refactor)

Hamza commented

2023-01-16 21:15:57 +01:00

I am new so it will take some time to understand how things work here.

correct me if I am wrong.

https://developer.blender.org/T95965

and

https://developer.blender.org/T103789

are both related to this issue here and are being worked on by @HooglyBoogly with some progress.

I will try to see what work had been done and what still needs to be done and if my contribution is required and then I will create a new task for this issue if required.

I am new so it will take some time to understand how things work here. correct me if I am wrong. https://developer.blender.org/T95965 and https://developer.blender.org/T103789 are both related to this issue here and are being worked on by @HooglyBoogly with some progress. I will try to see what work had been done and what still needs to be done and if my contribution is required and then I will create a new task for this issue if required.

Iliya Katushenock commented

2023-01-16 21:25:49 +01:00

Not really. At the moment, there are many places in blender where mesh processing involves copying positions into an array.
And, in order not to make a commit of several thousand lines, where all places will be affected, there is a task.
It unites all patches in this direction. One of them was the @HooglyBoogly patch. You can study it and look for where else in blender you can do the same job.
Do not do a bunch of things at once, especially for the first time.
Add a patch with the code and select #103789 (Remove unnecessary mesh position copying) as the task. It also seems to be enough to indicate here in the comments if you want to look at a specific area.
Since one person will most likely redo the entire blender with great difficulty.

Not really. At the moment, there are many places in blender where mesh processing involves copying positions into an array. And, in order not to make a commit of several thousand lines, where all places will be affected, there is a task. It unites all patches in this direction. One of them was the @HooglyBoogly patch. You can study it and look for where else in blender you can do the same job. Do not do a bunch of things at once, especially for the first time. Add a patch with the code and select #103789 (Remove unnecessary mesh position copying) as the task. It also seems to be enough to indicate here in the comments if you want to look at a specific area. Since one person will most likely redo the entire blender with great difficulty.

Iliya Katushenock commented

2023-01-16 21:28:16 +01:00

Also, for questions with the code, in the process of execution, you can go to https://blender.chat/channel/blender-coders

blender-admin commented

2023-02-06 20:34:16 +01:00

This issue was referenced by d20f992322

This issue was referenced by d20f9923224d2637374dd4390ae84c5041e3f9d3

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Remove unnecessary mesh position copying #103789