Blender Crashes when trying to create a Pivot Constraint for armature #104657

New Issue

Closed

opened 2023-02-12 17:22:13 +01:00 by Jonathan-Pecany · 9 comments

Jonathan-Pecany commented

2023-02-12 17:22:13 +01:00

System Information
Operating system: Windows 11
Graphics card: NVIDIA GeForce RTX 3050 Laptop GPU

Blender Version
Broken: 3.33, 3.34, 3.35 Beta
Worked: 2.79

Short description of error
When trying to set a bone in the Pivot Constraint for the Armature, it crashes.

Exact steps for others to reproduce the error

Create an armature.
Create a Pivot constraint from "Object Constraint Properties > Add Object Constraint > Relationship > Pivot".
Select the armature in the Target field.
Then select the Bone in the Bone field. (Blender crashes)

**System Information** Operating system: Windows 11 Graphics card: NVIDIA GeForce RTX 3050 Laptop GPU **Blender Version** Broken: 3.33, 3.34, 3.35 Beta Worked: 2.79 **Short description of error** When trying to set a bone in the Pivot Constraint for the Armature, it crashes. **Exact steps for others to reproduce the error** 1. Create an armature. 2. Create a Pivot constraint from "Object Constraint Properties > Add Object Constraint > Relationship > Pivot". 3. Select the armature in the Target field. 4. Then select the Bone in the Bone field. (Blender crashes)

KitchenCounter.blend

854 KiB

Jonathan-Pecany added the

labels 2023-02-12 17:22:14 +01:00

Iliya Katushenock commented

2023-02-12 17:34:46 +01:00

Member

Hello. I can't reproduce this in last 3.4 and 3.5 master. Can you check this in today builds?

Hello. I can't reproduce this in last `3.4` and `3.5` master. Can you check this in today builds?

Philipp Oeser commented

2023-02-13 12:18:56 +01:00

Member

Can confirm.
Can even simplify the repro steps (will update the report description).

Seems DepsgraphRelationBuilder::build_constraints cant handle the empty component_subdata string passed in...

Can confirm. Can even simplify the repro steps (will update the report description). Seems `DepsgraphRelationBuilder::build_constraints` cant handle the empty `component_subdata` string passed in...

Philipp Oeser added

Animation & Rigging

Dependency Graph

and removed

labels 2023-02-13 12:19:54 +01:00

Jonathan-Pecany commented

2023-02-13 18:41:03 +01:00

Author

Can confirm.
Can even simplify the repro steps (will update the report description).

Seems DepsgraphRelationBuilder::build_constraints cant handle the empty component_subdata string passed in...

Thanks for the confirmation. Almost thought it was a local problem where only this happens on my PC for some odd reason.

Is this technically a confirmed bug then? If so, when could it get fix?

I used empties instead of the armatures as a temporarily fix.

> Can confirm. > Can even simplify the repro steps (will update the report description). > > Seems `DepsgraphRelationBuilder::build_constraints` cant handle the empty `component_subdata` string passed in... > > > Thanks for the confirmation. Almost thought it was a local problem where only this happens on my PC for some odd reason. Is this technically a confirmed bug then? If so, when could it get fix? I used empties instead of the armatures as a temporarily fix.

Bastien Montagne added

and removed

labels 2023-02-17 10:45:42 +01:00

Philipp Oeser commented

2023-02-17 16:57:00 +01:00

Member

Is this technically a confirmed bug then? If so, when could it get fix?

It is confirmed as bug, yes. Not sure when a fix will be ready, you'll get notifications about updates though.

> Is this technically a confirmed bug then? If so, when could it get fix? It is confirmed as bug, yes. Not sure when a fix will be ready, you'll get notifications about updates though.

Philipp Oeser commented

2024-02-26 12:23:03 +01:00

Member

@Sergey @dr.sybren : while the usecase is a bit unclear here, will still raise priority (since this is a crasher)

Underlying problem is that we pass a NULL RootPChanMap for object constraints (as opposed to bone constraints where this map is built prior), see

build_constraints(&object->id, NodeType::TRANSFORM, "", &object->constraints, nullptr);

build_constraints(&object->id, NodeType::BONE, pchan->name, &pchan->constraints, &root_map);

So this little thing just bandaids across the crash, however I havent dug deeper if using OperationCode::BONE_DONE as an OperationCode makes a lot of sense here.

diff --git a/source/blender/depsgraph/intern/builder/deg_builder_relations.cc b/source/blender/depsgraph/intern/builder/deg_builder_relations.cc
index 7362646881d..14b2ee73694 100644
--- a/source/blender/depsgraph/intern/builder/deg_builder_relations.cc
+++ b/source/blender/depsgraph/intern/builder/deg_builder_relations.cc
@@ -224,7 +224,7 @@ OperationCode bone_target_opcode(ID *target,
                                  RootPChanMap *root_map)
 {
   /* Same armature. */
-  if (target == id) {
+  if (target == id && root_map != nullptr) {
     /* Using "done" here breaks in-chain deps, while using
      * "ready" here breaks most production rigs instead.
      * So, we do a compromise here, and only do this when an

@Sergey @dr.sybren : while the usecase is a bit unclear here, will still raise priority (since this is a crasher) Underlying problem is that we pass a NULL `RootPChanMap` for object constraints (as opposed to bone constraints where this map is built prior), see `build_constraints(&object->id, NodeType::TRANSFORM, "", &object->constraints, nullptr);` `build_constraints(&object->id, NodeType::BONE, pchan->name, &pchan->constraints, &root_map);` So this little thing just bandaids across the crash, however I havent dug deeper if using `OperationCode::BONE_DONE` as an `OperationCode` makes a lot of sense here. ```diff diff --git a/source/blender/depsgraph/intern/builder/deg_builder_relations.cc b/source/blender/depsgraph/intern/builder/deg_builder_relations.cc index 7362646881d..14b2ee73694 100644 --- a/source/blender/depsgraph/intern/builder/deg_builder_relations.cc +++ b/source/blender/depsgraph/intern/builder/deg_builder_relations.cc @@ -224,7 +224,7 @@ OperationCode bone_target_opcode(ID *target, RootPChanMap *root_map) { /* Same armature. */ - if (target == id) { + if (target == id && root_map != nullptr) { /* Using "done" here breaks in-chain deps, while using * "ready" here breaks most production rigs instead. * So, we do a compromise here, and only do this when an ```

Philipp Oeser added

Animation & Rigging

and removed

labels 2024-02-26 12:23:32 +01:00

Sergey Sharybin commented

2024-02-26 12:33:22 +01:00

Owner

@lichtwerk The patch looks correct. Just add a comment that root_map will be nullptr when building object-level constraints, and in that case we don't need to check for the common chains.

@lichtwerk The patch looks correct. Just add a comment that `root_map` will be nullptr when building object-level constraints, and in that case we don't need to check for the common chains.

Philipp Oeser commented

2024-02-26 12:39:31 +01:00

Member

OKi, will do a quick PR just bureaucratic reasons :)

OKi, will do a quick PR just bureaucratic reasons :)

Sybren A. Stüvel commented

2024-02-29 11:32:19 +01:00

Member

The diff looks correct to me too. I can't reproduce the crash though (I've tried with 3.3.16 release build).

The diff looks correct to me too. I can't reproduce the crash though (I've tried with 3.3.16 release build).

Philipp Oeser commented

2024-02-29 11:51:12 +01:00

Member

Oh, !118745 actually landed ( ae022e515b ).

Not sure why this was not auto-closed, will close now

Oh, !118745 actually landed ( ae022e515b41199aaa704ac0fdb9e43a15a30e72 ). Not sure why this was not auto-closed, will close now

Philipp Oeser closed this issue

2024-02-29 11:51:16 +01:00

Blender Bot added

and removed

labels 2024-02-29 11:51:30 +01:00

Philipp Oeser referenced this issue

2024-03-07 08:48:03 +01:00

Blender LTS: Maintenance Task 3.6 #109399

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

5 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#104657

No description provided.