Blender LTS: Maintenance Task 3.6 #109399
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
19 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#109399
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This task is a management task to track the commits and fixes that will be or are already applied to Blender 3.6 rolling release. The process is documented on https://wiki.blender.org/wiki/User:Jbakker/projects/BlenderLTS/ProcessDescription
NOTE: When changing this task please make sure to stick to the markup. The description is parsed to generate the release notes.
blender-v3.6-release
tomain
:main
:To Be Backported
NOTE: When adding commits please add the repository prefix to it. The release note generator requires the prefix.
NOTE: When adding items, please add them to the bottom of the
To Be Backported
list (not theBlender 3.6.1
list).NOTE: please leave a remark if a particular commit needs library updates in the branch, e.g. #109771
NOTE: commits are checked for having followup-issues (skipped for release in that case), if there are other reasons a commit should not be in a particular release, please also leave a remark (or remove the commit from the list again)
main
e3a02b9b02
3f1674ef52
2549272f02
c275f4219f
4f3e2ee857
, might not be backported30e3caaf82
1b4b90f5f7
, might not be backported, would also neede924f316a7
535d211c94
34b4487844
in LTS as well? >> it was decided against34b448784
in LTS2193bd4b89
ed540b4d3a
as well?2f1b9432be
83dbbf9aec
also followup issue #118550 that needs to be resolved prior)a6060ea8ee
e623d07362
b248295530
[which gives non-trivial conflicts] would cause harm, so reverted93f8b59172
, likely not going to get backported at all then5b3398a673
83dbbf9aec
also followup issue #118550 that needs to be resolved prior), prefer if @JulianEisel backports1f44be97e6
d4d5281d45
d66b42e382
710d168e30
CustomData_ensure_data_is_mutable
, probably not going to get backported751745b2de
d4f5d4a6f6
6de6d7267f
is not in 3.6296d05060d
c13c502624
Blender 3.6.16
main
Blender 3.6.15
main
90e83175eb
99618031b3
163baad17e
c788de853e
3f33b06dde
3c208a171c
Blender 3.6.14
main
696848204c
472243310b
633dbe0292
8c68ded7b9
4477641467
2ae87b8fb0
bc0b86797c
063ac47021
95d11b0d33
5da75183d9
Blender 3.6.13
main
669b15a53d
b11ffad1df
58f5b128c9
246c57cbe2
6256e2a838
59f21ebce0
40e036b63e
7c9d59414a
7a11fad380
60986373bc
ba3fac92af
6846976ffc
9b1d81eec2
9d2a1c14c4
6cccbc8df9
31a98dc847
2736446d65
,c6f0d8daa6
267df240b2
,6807f35a8f
Blender 3.6.12
main
0f721f705d
71b159d158
from 3.6.70bda626ba3
8e0032781b
f72dbc1ef8
7573ee73dd
edfba89d1e
c02b4b27da
7400927ada
263ce1ebb0
24560b6016
2d51478723
aa65bdbebc
d30df88748
b57916463c
02b0cbbf2e
Blender 3.6.11
main
303014bfac
b42f22caf5
1e478cf169
9026131c80
2d49cc597f
6babdb7169
c584597165
2ff46a6974
2886859347
58c4eb8009
5ba581bd0a
4423582c2f
a5c5cf473e
f4e74b0e1a
598819049e
c118e8716b
Blender 3.6.10
main
a99d9ba635
,63613e431e
,9277377f6b
a99d9ba635
,7180164abb
,2b46a1517e
,2362c73560
ea10be4dd6
888c41316f
,9a403ab34f
install_linux_packages.py
to include Git LFSb10507ab63
8508d6992b
1a2edde400
f9ec766165
745d2e18dc
1dc6de7d77
8675fc50dc
c1d6d8d361
a677518cb5
a252833562
d2f8af9b08
a812cbb241
56bfd56735
a370276060
0a173b942b
5fc714999b
659f05ef28
89d8f12730
3e09fbf062
b93d1c481e
e65de74aa5
0ea4ac2ef3
ee98482b44
5aa52624b3
ae022e515b
fc2aab661e
f880cbce93
0924a8208b
959595069d
c577ffab3e
8c3b85d666
ac3e0d024d
021565d867
0c1ce783c3
2191cbf7f5
e7332f5309
a8b9a58608
73f313c119
5d1d447c2b
aa7d7b0fbf
d5fe4c40ed
b347c7e9fe
98343c0c17
d8cca36c78
1e44d811ac
7999e39f35
a060e96103
0fa7356810
af953514e7
23df139aaf
281e45ec30
b54a26ede4
88ba4dfaa3
94554354a3
da101d8cdb
cdb6e15b62
6adf5adb7f
2c4589ca82
main
commitBlender 3.6.9
main
d885933be3
9ad6957574
1bebc27c70
d0359d066d
2b98ca4e54
e904432a1f
4be2fe27ad
4da32e9334
51394779cf
c16b0216fe
9bb002aa4e
a324a19f1b
195b772859
37e89714ff
86f581dc74
0c0885d323
4537ad051f
5e2bad1589
330f3e3c2b
5e2bad1589
330f3e3c2b
1f142b3d44
02b9ea7072
f23da882e6
7356fb105c
990c0ad42c
52248c54a3
0053de6556
bc4b4e8ec3
d38824bc02
1fddbb798e
711e4cdd94
b69d06f648
a3183fb95f
583af2a6e5
401a2397db
bdc6a5419a
d38824bc02
1161455084
,ef80392721
,7df6d9eb52
,9d5164d472
,5aed85dcd7
,3faa5db2e9
b2d628cf27
Blender 3.6.8
main
d2e91fb0d7
888612cb0e
92c9a2d1bc
a4dd4fe220
1149bb216d
1e1a2f5b6d
4c527b095a
27ce1cac80
beacdc3f01
b9ccfec2c6
e503536775
4fe6cae6a6
7346727cfc
f4b335828d
c23b51d614
cb81a52603
b70d387f2a
f3a309130a
0681180413
d229d2bc90
f0fcd553df
f1b5807339
81017772f5
2f10d8bc80
21c8af467d
), resolved in good faith268f93d763
b2c34fa95b
4bec9d0d71
dea7887c7b
f83180370a
ebbcc09149
7981b35064
746b2a89c9
b0d751e830
f83180370a
is already backported)b0d919181d
bcfb2e4a83
ba5a39a7c9
d499710218
Blender 3.6.7
main
ea1de499b3
064a48ad28
391b5ac93c
c3f67cd541
1058fd1b2b
ec6aa0b3fd
270fc860cf
77947af0d6
21a54d5b58
71b159d158
697114c4b6
836063cbd6
49e4923384
94bd19bf1b
4dede4efa8
29cd4eb559
09be0915c3
cd7bc85237
ed556113ce
9089935f43
609ac5e378
431a0844fc
d2e91fb0d7
888612cb0e
Blender 3.6.6
main
97dfbc9
5f56992
97d9bbb
a455eca
0548b2d
9827c1f
1242512ff2
eec6991026
f8d38b65a4
327fa72f8a
40ea1cdb97
fab1e75228
534e7f4470
7f5cec2398
09046e8121
a1e7f2c0de
fa987dc059
c502becd40
4cedbb9cb7
7c8843c279
4d91c50b62
58e7575fb3
e6a0b4404c
efde40cb21
3cb659faa8
4d080c1daf
eed4f950d8
222f382e4a
6f0477bd1d
39f5b84b38
19b112b11c
50c784ecbf
10eb1ac8e4
87c93e7e37
2d7ccae528
d09f7887d1
46c180015a
d17f1194bb
b7b74385cd
fa00609436
8337b3dd3f
98ec3826ac
4e4fc8c276
6e51a2eaea
3e9403bd76
4eca55cc11
3ad21b2169
4b34443c10
46159c131d
) part of PR !114353.51467b0611
601141e01c
ee15925716
06e08069fc
e0492754fe
26346464e0
eff49a865f
39f7411065
00fbe3b112
67445c2353
e939812968
49c3dc9
ade490ddd0
afe297231d
228da669a9
cc6c5cb7f4
e95b6e01c1
9c2164ba7c
9ce76198b6
bb8cb4e56f
4a414cbe66
e7ad3af301
ea2c722688
0a3b44ed64
cf61d16b15
0ca1e70de1
dfba707604
c7afbbc836
09baf6a8bc
0eb279de54
6849168885
5974a4482a
a5fc69c9fc
5cf3654d9d
e76cb15a3f
Blender 3.6.5
main
ed36398
f41ea86
eadc54bb5d
6d466e4b94
,5207c7e117
89b3249c
2af8d24
d4cc0d02cb
086c431
8d26dda
49ef671
c5e10920f9
8a15a61e0f
baeeff9a84
e6b99c15db
a238ab737b
c80b45f646
5ae99270c1
e785101e73
954ae19b2b
andf6082a5042
96458a81ec
and5518a9f43a
057de815ef
6f2ee29674
d102536b1a
9532b6a53d
c29a78d80d
30eb74ca48
7449f0e14c
f43866c729
bf23d0e53c
c0837bf545
2d864846e4
fe013fbc5b
e196f0a874
7135f75541
ebb5643e59
], resolvedbe7e2d01a8
7482137167
b3c7f3c8a9
], resolved2d2c7457cf
6e65911dff
b0706a57ac
e34b424a61
fde8e6ce
not in 3.6], resolved5f7f6b65f3
b2c0e49bf3
4a57a56f87
03ce9278f9
b9124d8a85
8b5d0ba19f
66028c8c97
1f09031dc7
48204b630c
521a68323c
48204b630c
521a68323c
Blender 3.6.4
main
211d631428
fa6261e53a
56781c80b7
59e8be7aa4
8eafc4e1d4
72624f9678
a5c5ec6052
9d92f03536
d9ab0a3ef7
Blender 3.6.3
main
d9831a9a4b
b075c84ba3
5b6106f71a
56659f1510
7fb58a33f0
e2d4403497
main
(conflicts, resolved)2fc04eaf43
36cd1755d2
c5fd621240
3bf2757b47
19a16de5df
a37ff68334
4cf03b28b3
598af45459
481d4fdaa1
dce2368b8c
,931467cbd5
08bff72a0a
,65f38fa010
c4fb34a3f7
c8573cb20a
769fe07668
d9f12d5453
4cefe0ec80
1e4b5e5a3b
391c2ea21c
b051ceb96b
262b67d61d
5b7af751fa
452ec6c93e
e42c70fd31
3234da45a2
b1b8091667
,83047bed26
63cad96833
,f420dabf8e
7f65080ab4
ec1b417263
9e71b84f1d
dd7f974936
8bae4427ed
1aceeac984
e2a35debde
5f2ead7db0
b4c380acb4
557d3d7953
8d9422cfe3
,3da47a6084
b9f78a0fcf
,93cc31ab85
110eb666ca
282038ea03
3f7eceea93
eb77eaa7d8
02406e17a0
c655db6185
8992e7ab2a
8dd151debc
ebd4d1e2d6
c3689c4235
0798aae01c
6d0d07f0d8
cc01bb83f6
af7df55c7d
a0b232c80d
d371c3c09f
c02f2f4947
ed8d18a3fc
439e37466c
b6df32f740
d59c8d195b
580833165c
c8c6f62cf3
a3c045d49d
2a7d6d182c
f77fdbff8a
24484053f5
4cf0e7acfb
f2fffc5390
09df1f4caf
0d557718eb
5b3398a673
2dd5d31946
30114476c7
a786b2981e
8141ee90f4
3542d8ac06
02736d28cd
b8ab67827d
6a301cf07f
6723a62c68
00a36cbf24
e039442f27
bf8d3c157a
8159bd90e5
84b4b90e08
c6998872f0
a370acae0c
9fc217cedf
0b7d8a20bf
, resolved397a0a0e7e
57a58fb2b3
52cfa67f6f
d06c761a9d
564716d5a2
588c793db0
f41dc90925
be2df46afe
3b44fd3655
e2f9c9892e
97d2dbb24e
d2b12579f0
726bd3887f
672c16321b
11b2ac54a6
9464eb1682
e914004678
c010263371
9da88301ef
8c8d1fba6e
42ed81b
ce77d52
281fbf72f0
2e1ab36
048d4638af
101abc6f6c
eba0d481bb
56781c80b7
c106702bcc
Blender 3.6.2
main
fc58d92acb
bc486302fe
75658109be
ea8f8fd50a
0a2d4289c0
0a10b8e82a
d74b984467
4bb2402172
2cb9290012
a30bcc806d
a1a08610b6
273ba74fcb
9ed5177055
8362d4aa3d
4842424220
cb31546c03
5b85248c71
db2d148239
2dfbd653a0
11c57f3016
a05419f18b
8736b6cc83
8a45453a9b
a6df000206
526dc2b58f
30943d710f
684a0b20c3
cc325ad1ba
f63ca4f7a8
67bc7f9477
8c81327b84
bf93fb0f46
4bc512bc9d
30d44548e3
ac24dc4cbb
65e8b21a95
0ac35f42de
b7a119c785
99f1ea5341
308da08221
d47755f3c6
b199f10204
e7e54d6e16
ece704af45
4910653d5c
b08b6984d0
0c4a357746
742ada97e2
ea66623801
126fd4a181
e4d429cfaf
4fe7626c49
dca1dbbc6c
7c3a779bc2
420f2adb2a
0fab1f4f68
771bf05c73
b3223d3f4f
35b913af30
9a150b95c5
c66db95fba
318aaa6d6b
9ca57f266e
70a412d743
c6725b935c
90458c6400
0896cae97c
991fd3baf4
830730e2cc
6f7e819b29
a1d7ec7139
15f6e83319
05243a4206
1b1a9b80ae
aecf6dd1db
6839c1c2ec
a14c747fe8
fbcaf7bf6f
8d4c847052
d121ed4755
c774cc0cc0
acd207794e
55413e0fc6
7180271d56
61ee554e3f
84734cfe94
76817e5951
d5bd58db88
04a07d5e08
ec016f7c1b
5dfd3e3c28
c426d5b084
e1b1b2a8b4
455683c838
09b6eac5c4
c040c59e3f
cd74ba6413
39d7f793f9
babc650779
2f2aecb507
2e246e355e
e8d1afb909
ee96947abc
b20953c2c9
Blender 3.6.1
main
c47074f3bb
eeec5e6822
daf414b48e
,6221410409
ce7cde954e
,596d4ff55f
f8981b6492
7fe112c56d
a60c1e5bb8
6adfd2ae39
09c0c86d83
45bf61f131
0f3b691c22
f825a346fc
258ba398ed
18ae7eb689
128c95438f
d990e01342
e73a9a6a7d
122d380a7c
56e9abf133
5590993f95
f6f3a6a928
cbcbba23d5
dd4f0cebae
c1b2e25c2d
5308abafd8
866d43ae9d
ad4aa692ce
8073325ddc
0aafc49c91
9f6a4d0c06
fb8c9a2a42
7880ae7c78
03fd794130
472e9c37b5
5c37e2123e
2cbf2885dd
1f779f1df2
0f510f3ae9
7538127a58
9889d0ef6f
d2c87c3281
df0d6d0022
6dd51353dd
2ee0c23a82
5283ef4ce5
3195a4cef1
fa2a28e96d
1b84135fb5
59ab70b594
7c4108567b
ab457ae62e
e73bb628ee
a81dccceaf
87b8e2e18d
99d7e9fb55
7e55dfcf27
155e1830bd
751db88748
9383f4d067
7271ceb057
8142195f29
7e24a0a2ec
aef44c2d50
9314f97afd
b831ef579b
18efd11369
be09111784
8a73c36643
906128e9e7
ac708cb33a
d9ae68b9e3
232d763af4
937c72cf89
53e1bae929
1795598c59
a8186e1542
696b1804dd
d3315422ae
41782dfd52
70b05249cb
fba02d14a7
9c9664c823
,791a06061c
9ba5d63ed7
,60b25936fe
ac3f4e959f
86420289e3
300cfecc46
a7221d2993
784d09a87c
,1c0ffa1e18
3d2bae8a5d
b29d2c607d
bab9133412
fc0e110e60
75e0aab868
74772c6920
05f4458f39
6abf253689
fc44305e72
cc1ee96407
a8b82bd89e
111e378366
edc1a09966
@mano-wii : could you create PRs targeting the
blender-v3.6-release
branch for the commits in your repo? Think this would be the easiest to get them merged...@lichtwerk, these are the PR for each:
#109445
#109656
@HooglyBoogly , @mano-wii : could you check on the remaining conflicts ? @mano-wii : think you could also just land your PR yourself.
If in doubt, please consult @ThomasDinges , I'll be back tomorrow
I did and it seems to work fine :) (!109445)
Could you please add it to the list of actual commits in Blender 3.6.1 then?
Done
Hello,
I want to add this commit to the list, but because this task is on blender, and not blender-addons, I don't have any rights to edit the task.
Can someone add it to the list? Thanks
blender/blender-addons@31e3364946
Germano Cavalcante referenced this issue from blender/blender-addons2023-08-11 02:25:24 +02:00
Hello,
Would it be possible to add this issue to the backport list?
#109583
I hope it is ok to ask this here.
It is keeping me from switching to Blender 3.6
@HooglyBoogly ^
Yes, that seems reasonable, thanks for bringing it up.
@HooglyBoogly , @JacquesLucke , @mano-wii : could you check on the "backportability" of
580833165c
,b6df32f740
,c02f2f4947
(had conflicts I wasnt 100% sure how to resolve)b6df32f740
can certainly be backported, I'll create a patch for it.I resolved the conflicts and committed directly to
blender-v3.6-release
(hope it's ok).I edited the comment in the tables but didn't move it to the other table.
c02f2f4947
ed8d18a3fc
a0b232c80d
d371c3c09f
Added a backport PR for
b6df32f740
: #112015.@mano-wii : moved those commits to the
Blender 3.6.3
section now.If we need support the agx for 3.6.3 from 4.0?
Because 3.6 is LTS edition. It will use for long time
@HooglyBoogly : backporting
f41dc90925
had conflicts that I would prefer you handling@brecht / @BrianSavery / @HooglyBoogly / @nrupsis / @filedescriptor : had some commits with conflicts where I would prefer if you could check, create a 3.6 specific PR, or commit directly to the branch (if you do, please update the corresponding list), thx in advance!
@lichtwerk for #112068 the issue is that the
grease_pencil.cc
file doesn't exist in 3.6. But the changes to that file can be safely ignored. The important changes are in the curves files.@lichtwerk I have a backport PR for #9da88301ef: PR: #112347.
@filedescriptor : could you just make a PR for this?
@lichtwerk Sure :)
EDIT: Here you go! #112366
blender/blender-addons@1467d62c79 is a math fix in Rigify that I think is safe and could be backported.
@angavrilov you can just add it to the list.
Can we please add
9ccd934d19
to the list? I don't have any rights on blender core repo, only on blender-addons one, so I can't edit the list@JulienDuroure done, and I also gave you the permissions to edit this issue in the future.
@mod_moder / @HooglyBoogly / @brecht / @JacquesLucke / @Alaska / @Hoshinova : ran into conflicts (or have remarks when) backporting your commits, mind checking on these (see remarks in
To Be Backported
)? Thx in advance!@lichtwerk
92c9a2d1bc
was originally only meant for 4.0, not 3.6 LTS. But I'll also make the necessary changes for it to work in 3.6 LTS.@lichtwerk
61a8d1f7d0
fails because if any of the Cycles tests were saved in a version of Blender prior to 3.5, and get their sampling pattern converted to Sobol Burley with versioning code. Then that commit will convert the sampling pattern to Tabulated Sobol instead. Since the sampling pattern is different between the test image and the new test file, the renders have different noise patterns and thus fail.c8365bb217
fails for a similar reason. If the debug UI is off (which it probably is for tests), then any file that uses the Sobol Burley sampling pattern will use Tabulated Sobol instead. So you get the same issue, the sampling pattern is different between test image and file being rendered, resulting in a noise difference, resulting in a test failure.Running the tests locally, the only issue I found was that the noise was different. There didn't appear to be any artifacts or crashes or things like that.
I should note, one more test fails with
c8365bb217
. This is because61a8d1f7d0
handles files saved prior to 3.5.c8365bb217
handles all files. And the tests do include at least one test saved after 3.5 with Sobol Burley enabled. So it's handled byc8365bb217
but not61a8d1f7d0
.To fix this, the test images just need to be updated. I don't have experience with this, or commit access (I'm just a community member), so I'm not sure how to help.
Committed
e0492754fe
(3.6 branch only commit) and added it to the 3.6.6 table.3f633503d3
because as noted, the bug that introduced is not in 3.6.d4cc0d02cb
since it was already backported.c8365bb217
and61a8d1f7d0
, not critical enough to be worth the effort backporting this debug sampling pattern stuff.@Jeroen-Bakker : backporting
2193bd4b89
has conflicts, also: do we wanted540b4d3a
as well?@lichtwerk @brecht This PR #115015 backports
92c9a2d1bc
to 3.6 LTS correctly.@mano-wii : reg. !116155 : this now has conflicts, could you update again? (
f83180370a
is already backported)Conflicts resolved
34b4487844
fixes #114173 , good to have this commit as well in 3.6 :)While
34b4487844
would be nice, it's less of a nobrainer, because some people were relying on the buggy behavior. See #113621. It's probably safer not to fix this particular thing in 3.6.98343c0c17
plus the relevant library upgrade needs to be back ported to 3.6 on Linux. However I'm not sure how libraries are handled for LTS so I haven't added it to the task.I've added both the library and blender commit to the list now. Backporting libraries should be something like this:
I can do it too if needed.
@brecht : there was this discussion about storing .h files with Git LFS, that is also the case with
e8bd2af257
[which I wanted to backport]. What is the solution to that?@brecht @mont29 had a few conflicting backport commits (see the To Be Backported section) where apparently stuff happened in between 3.6 and now. Sorry if these are obvious, but prefer if you have a second eye, thx in advance.
@lichtwerk I see no issue with the storage of .h files in that commit, it should be fine to backport. Only the binary files have "(Stored with Git LFS)" next to them.
@Sergey : regarding the backport of
598819049e
: would prefer if you have a look (has conflicts)@LukasStockner : Will try backporting
1f44be97e6
/d4d5281d45
tomorrow again [ if you like, you can always do yourself as well though :) -- had trouble getting theb9accb676b
over to the blender-v3.3-release branch (at least via the gitea UI...) ]@lichtwerk Cherry-picked
598819049e
, asc118e8716b
in the branch. Also updated the task itself.@LukasStockner : this still doesnt work, we are trying to figure out why in chat, but wouldnt mind if you would join the efforts.
Not the end of the world if these backports are not included in next weeks LTS releases (would be nice though...)
@LukasStockner : seems like there were changes in main other than
1f44be97e6
/d4d5281d45
that affected the expected outcomepanorama_dicing.png
so that would have to be re-rendered from 3.3 with those commits applied. @Sergey also raised the question if we really want a changed render output in LTS (even if it is a bugfix), because we probably wouldnt want studios to have their movie rendered differently when updating to an LTS. Opinions?@lichtwerk I can't find the relevant thread in the chat, sorry.
As for including the fix or not: Hm, yeah, good question. On the one hand, it does change the output, but on the other hand, the old output was so broken (for bump maps) that I'd consider it unusable.
discussion was in #blender-release
I would say this would have to be decided by the
Render & Cycles
module then.Generally speaking, we are discussing being a bit more restrictive wrt backports in the future atm.
If it's too much trouble to backport, let's just not backport this fix then.
Fine with me, I guess if the bug was open for 4 years it's not such a common use case to begin with...
@HooglyBoogly : backporting
d66b42e382
had conflicts, prefer if you check@weizhen : you might want to look at
95d11b0d33
yourself (thx in advance!)@lichtwerk
95d11b0d33
should be simple enough to backport? It's just one line + update one image, do you have any difficulty?For me it's just that I've never backported anything so not familiar with the procedure, and I would need to compile 3.6 from scratch to update the image, but I can try as well.
@weizhen : if reference/test images change, would prefer to aactually have the dev look at it to make sure the differences are actually the expected ones... (also cant build with CUDA/OPTIX atm. even though that is probably irrelevant, tests are only on CPU by default?)
regarding the procedure: usually I try cherry-picking [which in this case is not possible due to the submodule change] and if there are other conflicts, i try to solve them "by hand" [which in this case could work since it is just that one-liner]. So in this case, the procedure would probably to do it from scratch? Following this and this? Anyhow, like I said before, if tests change, prefer if the dev handles. Again: thx in advance! Let me know if there are other issues with 3.6 that I can possibly help with.
It seems the fix for #109253 wasn't added to the backport list. Is it safe to add?
@Alaska It might be more efficient to talk to developers who made/reviewed/landed the patch. They might not be monitoring the LTS maintenance tasks.
I've talked to Omar, there is no strong opinions about this fix from both of us, but it seems safe to port.