object.override_library.resync(...) -- crashes when view_layer is not specified #118055

New Issue

Closed

opened 2024-02-09 18:56:50 +01:00 by James Tomkinson · 3 comments

James Tomkinson commented

2024-02-09 18:56:50 +01:00

System Information
Operating system: Windows-10-10.0.22631-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 546.33

Blender Version
Broken: version: 4.0.2, branch: blender-v4.0-release, commit date: 2023-12-05 07:41, hash: 9be62e85b727
Worked: Never.

Short description of error
object.override_library.resync(...) -- crashes with EXCEPTION_ACCESS_VIOLATION

Exact steps for others to reproduce the error

Open the attached file "crashes.blend" that links objects from the file "library.blend"
Run the displayed script: as included in Text editor:

import bpy

o= bpy.data.objects['Cube']
o.override_library.resync( bpy.context.scene, do_hierarchy_enforce=True )

Notice the program aborts:

ExceptionCode         : EXCEPTION_ACCESS_VIOLATION
Exception Address     : 0x00007FF7AACB8A06

Stack trace:
blender.exe         :0x00007FF7AACB8A00  BKE_view_layer_synced_ensure
blender.exe         :0x00007FF7AADED860  lib_override_library_resync
blender.exe         :0x00007FF7AADEB820  BKE_lib_override_library_resync
blender.exe         :0x00007FF7AB36AD80  rna_ID_override_library_resync
blender.exe         :0x00007FF7AB3636D0  IDOverrideLibrary_resync_call

**System Information** Operating system: Windows-10-10.0.22631-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2060/PCIe/SSE2 NVIDIA Corporation 4.6.0 NVIDIA 546.33 **Blender Version** Broken: version: 4.0.2, branch: blender-v4.0-release, commit date: 2023-12-05 07:41, hash: `9be62e85b727` Worked: Never. **Short description of error** object.override_library.resync(...) -- crashes with EXCEPTION_ACCESS_VIOLATION **Exact steps for others to reproduce the error** 1. Open the attached file "crashes.blend" that links objects from the file "library.blend" 2. Run the displayed script: as included in Text editor: ```Py import bpy o= bpy.data.objects['Cube'] o.override_library.resync( bpy.context.scene, do_hierarchy_enforce=True ) ``` Notice the program aborts: ``` ExceptionCode : EXCEPTION_ACCESS_VIOLATION Exception Address : 0x00007FF7AACB8A06 Stack trace: blender.exe :0x00007FF7AACB8A00 BKE_view_layer_synced_ensure blender.exe :0x00007FF7AADED860 lib_override_library_resync blender.exe :0x00007FF7AADEB820 BKE_lib_override_library_resync blender.exe :0x00007FF7AB36AD80 rna_ID_override_library_resync blender.exe :0x00007FF7AB3636D0 IDOverrideLibrary_resync_call ```

library.blend

173 KiB

crashes.blend

173 KiB

crashes.crash.txt

42 KiB

James Tomkinson added the

labels 2024-02-09 18:56:50 +01:00

Iliya Katushenock added the

label 2024-02-09 18:58:19 +01:00

Iliya Katushenock added

and removed

labels 2024-02-09 18:59:46 +01:00

Philipp Oeser commented

2024-02-12 13:07:18 +01:00

Member

This happens if the view_layer is not specified (it is optional in the function call).

So this doesnt crash:

import bpy

o= bpy.data.objects['Cube']
o.override_library.resync( bpy.context.scene, do_hierarchy_enforce=True, view_layer=bpy.context.view_layer )

Not quite sure about the param description, which says:

The view layer to operate in (same usage as the scenedata, in case it is not provided the scene's collection will be used instead)

Or the comment for BKE_lib_override_library_resync

 * \param view_layer: the active view layer to search instantiated collections in, can be NULL (in
 *                    which case \a scene's master collection children hierarchy is used instead).

@mont29 : I dont really see code (maybe further down the line, but not on first sight) that handles non-specified view_layers, mind checking?

Raising priority since this is a crasher which is not an absoute corner-case to run into...

This happens if the `view_layer` is not specified (it is optional in the function call). So this doesnt crash: ``` import bpy o= bpy.data.objects['Cube'] o.override_library.resync( bpy.context.scene, do_hierarchy_enforce=True, view_layer=bpy.context.view_layer ) ``` Not quite sure about the param description, which says: `The view layer to operate in (same usage as the `scene` data, in case it is not provided the scene's collection will be used instead) ` Or the comment for `BKE_lib_override_library_resync` ``` * \param view_layer: the active view layer to search instantiated collections in, can be NULL (in * which case \a scene's master collection children hierarchy is used instead). ``` @mont29 : I dont really see code (maybe further down the line, but not on first sight) that handles non-specified view_layers, mind checking? Raising priority since this is a crasher which is not an absoute corner-case to run into...

Philipp Oeser added

and removed

labels 2024-02-12 13:07:37 +01:00

Philipp Oeser changed title from ~~object.override_library.resync(...) -- crashes~~ to object.override_library.resync(...) -- crashes when view_layer is not specified

2024-02-12 13:07:56 +01:00

Bastien Montagne referenced this issue from a commit

2024-02-13 12:57:15 +01:00

Fix #118055: libOverride `resync()` RNA call crashes when view_layer is not specified.

Bastien Montagne closed this issue

2024-02-13 12:58:03 +01:00

Blender Bot added

and removed

labels 2024-02-13 12:59:15 +01:00

Bastien Montagne referenced this issue

2024-02-13 13:02:24 +01:00

Blender LTS: Maintenance Task 3.3 #100749

Bastien Montagne referenced this issue

2024-02-13 13:02:54 +01:00

Blender LTS: Maintenance Task 3.6 #109399

Philipp Oeser referenced this issue from a commit

2024-02-14 15:33:26 +01:00

Fix #118055: libOverride `resync()` RNA call crashes when view_layer is not specified.

James Tomkinson commented

2024-02-14 21:50:12 +01:00

Author

when I used the coding:

bpy.ops.outliner.liboverride_troubleshoot_operation( type='OVERRIDE_LIBRARY_RESYNC_HIERARCHY', view_layer=bpy.context.view_layer, selection_set='SELECTED')

I get the same error:
RuntimeError: Error: Object 'JBUJeans_9015.Shape.001' can't be selected because it is not in View Layer 'View Layer'!

and I'm not sure why the error is shouting at me (!).

when I used the coding: ``` bpy.ops.outliner.liboverride_troubleshoot_operation( type='OVERRIDE_LIBRARY_RESYNC_HIERARCHY', view_layer=bpy.context.view_layer, selection_set='SELECTED') ``` I get the same error: ```RuntimeError: Error: Object 'JBUJeans_9015.Shape.001' can't be selected because it is not in View Layer 'View Layer'!``` and I'm not sure why the error is shouting at me (!).

James Tomkinson commented

2024-02-14 22:15:20 +01:00

Author

UPDATE:
For some reason , it was the set_select that was failing with the view layer error, not the hierarchy.
I am closing this because I no longer get crash and and opening up a new report with new perspective.

UPDATE: For some reason , it was the set_select that was failing with the view layer error, not the hierarchy. I am closing this because I no longer get crash and and opening up a new report with new perspective.

Bastien Montagne referenced a pull request that will close this issue

2024-02-16 10:02:15 +01:00

Fix #118055: libOverride `resync()` RNA call crashes when view_layer is not specified. #118364

Philipp Oeser referenced this issue from a commit

2024-02-16 10:36:46 +01:00

Fix #118055: libOverride `resync()` RNA call crashes when view_layer is not specified.

Philipp Oeser referenced this issue

2024-02-16 10:54:00 +01:00

liboverride_troubleshoot_operation(): fails with context incorrect, even with screen.areas.type == 'OUTLINER' #118299

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#118055

No description provided.