Fix #112068: Crash when loading converted curves #112366

Falk David · 2023-09-14T11:34:40+02:00

Falk David commented

2023-09-14 11:34:40 +02:00

In 2788fa915b the CurvesGeometry::blend_write and CurvesGeometry::blend_read functions were added. Unfortunately, the commit also altered the writing logic and introduced a bug where loading a file with a converted Curves object would crash. See #112068.

This PR fixes the issue by making sure that CustomData_blend_write_prepare is called before BKE_id_blend_write, which is the root cause of the crash that happens on load.

The CurvesGeometry::blend_write function is split into CurvesGeometry::blend_write_prepare and CurvesGeometry::blend_write.

Pull Request: #112280

In https://projects.blender.org/blender/blender/commit/2788fa915be6a7da0a0b0ad63626c095eef1e216 the `CurvesGeometry::blend_write` and `CurvesGeometry::blend_read` functions were added. Unfortunately, the commit also altered the writing logic and introduced a bug where loading a file with a converted `Curves` object would crash. See https://projects.blender.org/blender/blender/issues/112068. This PR fixes the issue by making sure that `CustomData_blend_write_prepare` is called before `BKE_id_blend_write`, which is the root cause of the crash that happens on load. The `CurvesGeometry::blend_write` function is split into `CurvesGeometry::blend_write_prepare` and `CurvesGeometry::blend_write`. Pull Request: https://projects.blender.org/blender/blender/pulls/112280

Falk David added 1 commit 2023-09-14 11:34:50 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

f9d895e6b7 Fix #112068 : Crash when loading converted curves

In 2788fa915b the `CurvesGeometry::blend_write` and `CurvesGeometry::blend_read` functions were added. Unfortunately, the commit also altered the writing logic and introduced a bug where loading a file with a converted `Curves` object would crash. See #112068.

This PR fixes the issue by making sure that `CustomData_blend_write_prepare` is called before `BKE_id_blend_write`, which is the root cause of the crash that happens on load.

The  `CurvesGeometry::blend_write` function is split into  `CurvesGeometry::blend_write_prepare` and `CurvesGeometry::blend_write`.

Pull Request: #112280

Falk David referenced this pull request

2023-09-14 11:35:10 +02:00

Blender LTS: Maintenance Task 3.6 #109399

Philipp Oeser referenced this pull request

2023-09-14 12:10:37 +02:00

Blender LTS: Maintenance Task 3.6 #109399

Philipp Oeser commented

2023-09-14 13:18:25 +02:00

@blender-bot build

Philipp Oeser referenced this issue from a commit

2023-09-14 13:41:24 +02:00

Fix #112068: Crash when loading converted curves