Fix #110161: Crash on dragging a Speaker NLA strip #110605

Merged
Sybren A. Stüvel merged 3 commits from guishe/blender:fix-drag-strip into main 2023-08-03 14:19:57 +02:00
Contributor

NLASTRIP_TYPE_TRANSITION was being used incorrectly as a flag,
having NLASTRIP_TYPE_TRANSITION=1 and NLASTRIP_TYPE_SOUND=3
in the enum eNlaStrip_Type, when evaluating NLASTRIP_TYPE_SOUND & NLASTRIP_TYPE_TRANSITION
gives a invalid truish value.

Also strips that can't be placed were freed, but no removed from the
strips list, this will cause a error if the strip is at begin
or end of the list.

`NLASTRIP_TYPE_TRANSITION` was being used incorrectly as a flag, having `NLASTRIP_TYPE_TRANSITION=1` and `NLASTRIP_TYPE_SOUND=3` in the enum `eNlaStrip_Type`, when evaluating `NLASTRIP_TYPE_SOUND & NLASTRIP_TYPE_TRANSITION` gives a invalid truish value. Also `strips` that can't be placed were freed, but no removed from the `strips list`, this will cause a error if the `strip` is at begin or end of the list.
Guillermo Venegas added 1 commit 2023-07-29 05:30:03 +02:00
Guillermo Venegas changed title from Fix #110161:Regression: Crash on dragging a Speaker NLA strip to Fix #110161: Crash on dragging a Speaker NLA strip 2023-07-29 05:30:14 +02:00
Guillermo Venegas added 1 commit 2023-07-29 05:35:59 +02:00
Guillermo Venegas added 1 commit 2023-07-29 06:04:32 +02:00
Pratik Borhade requested review from Sybren A. Stüvel 2023-07-31 13:58:37 +02:00
Pratik Borhade requested review from Nate Rupsis 2023-07-31 13:58:38 +02:00
Pratik Borhade added this to the Animation & Rigging project 2023-07-31 13:58:45 +02:00
Nathan Vegdahl approved these changes 2023-07-31 17:51:56 +02:00
Nathan Vegdahl left a comment
Member

Looks good to me.

Looks good to me.
Sybren A. Stüvel approved these changes 2023-08-01 11:30:59 +02:00
Sybren A. Stüvel left a comment
Member

NLASTRIP_TYPE_TRANSITION was being used incorrectly as a flag,

Such a good find 🤯

Thanks for the fix, LGTM!

> `NLASTRIP_TYPE_TRANSITION` was being used incorrectly as a flag, Such a good find 🤯 Thanks for the fix, LGTM!
Sybren A. Stüvel merged commit 5b3398a673 into main 2023-08-03 14:19:57 +02:00
Sybren A. Stüvel deleted branch fix-drag-strip 2023-08-03 14:20:01 +02:00
Member

@dr.sybren @ThomasDinges This should be back ported to 3.6/3.3 since they experience the same problem: #111363, #110763

@dr.sybren @ThomasDinges This should be back ported to 3.6/3.3 since they experience the same problem: #111363, #110763

Good idea, I've added the commit to the 3.3 (#100749) and 3.6 (#109399) lists.

Good idea, I've added the commit to the 3.3 (#100749) and 3.6 (#109399) lists.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#110605
No description provided.