Clear and Keep Transformation not working when keyed #97628

New Issue

Julien Kaspar · 2022-04-26T15:33:46+02:00

Julien Kaspar commented

2022-04-26 15:33:46 +02:00

System Information
Operating system: Linux-5.4.0-109-generic-x86_64-with-glibc2.31 64 Bits
Graphics card: Quadro GP100/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 470.103.01

Blender Version
Broken: version: 3.2.0 Alpha, branch: master, commit date: 2022-04-26 06:51, hash: 2492d9852b
Worked: (newest version of Blender that worked as expected)

Short description of error
The issue that occurs here is when you have an object parented to another. If the parent has since then been transformed and the child has has the same transformation keyed, then it's not possible to unparent the child and keep the current transformations.
Instead the transforms will stay the same as the keyed value when unparenting,

My expected behaviour is that it will update the transform values just like when not keyed, but will require the user to key the new value. Otherwise the new value is lost once the current frame is moved.
Maybe this is too simple of a solution, but updating the entire animation would be too complicated.
But there should be an option to keep the transform anyway. Or at least a warning why it doesn't.

Exact steps for others to reproduce the error

Create 2 cubes
Parent one cube to the other (Now refereed to as parent & child)
Move, rotate or scale the parent
Key the same transform of the child
Select the child and press Alt + P and select "Clear and Keep Transformations"

**System Information** Operating system: Linux-5.4.0-109-generic-x86_64-with-glibc2.31 64 Bits Graphics card: Quadro GP100/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 470.103.01 **Blender Version** Broken: version: 3.2.0 Alpha, branch: master, commit date: 2022-04-26 06:51, hash: `2492d9852b` Worked: (newest version of Blender that worked as expected) **Short description of error** The issue that occurs here is when you have an object parented to another. If the parent has since then been transformed and the child has has the same transformation keyed, then it's not possible to unparent the child and keep the current transformations. Instead the transforms will stay the same as the keyed value when unparenting, My expected behaviour is that it will update the transform values just like when not keyed, but will require the user to key the new value. Otherwise the new value is lost once the current frame is moved. Maybe this is too simple of a solution, but updating the entire animation would be too complicated. But there should be an option to keep the transform anyway. Or at least a warning why it doesn't. **Exact steps for others to reproduce the error** - Create 2 cubes - Parent one cube to the other (Now refereed to as parent & child) - Move, rotate or scale the parent - Key the same transform of the child - Select the child and press `Alt + P` and select "Clear and Keep Transformations"

Julien Kaspar commented

2022-04-26 15:33:46 +02:00

Added subscriber: @JulienKaspar

Richard Antalik commented

2022-04-27 06:17:41 +02:00

Added subscriber: @iss

Richard Antalik commented

2022-04-27 06:17:41 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Richard Antalik commented

2022-04-27 06:17:41 +02:00

Other operators like apply/clear transform do actually overwrite keyed values, so I would assume this can be done. So will confirm, even if this may be currently working as designed.

Sybren A. Stüvel commented

2022-05-02 16:49:00 +02:00

Added subscriber: @dr.sybren

Sybren A. Stüvel commented

2022-05-02 16:49:00 +02:00

In #97628#1347260, @iss wrote:
Other operators like apply/clear transform do actually overwrite keyed values

I don't see any calls for this in the OBJECT_OT_transform_apply code.
A test also shows that this doesn't happen:

#97628-apply-transform-when-keyed.blend

Open the file. The teapot starts sitting on top of the cube.
Drag the playhead around, see the teapot is animated.
Press {key Ctrl A} and apply all transforms.
Drag the playhead around, see the teapot is now no longer starting on top of the cube, and also has the wrong scale. This is because the animated scale is stacked on top of the applied scale.

So will confirm, even if this may be currently working as designed.

Please don't do that. Code that works as designed is not a bug.

Updating the animation is not a trivial thing. It a great idea, but when we do this, it should not just be for unparenting (but also for parenting, or even as a general "apply arbitrary transformation to animation data" so we can use it for more mass updates to keyed transforms), and should be worked on in a design task.

> In #97628#1347260, @iss wrote: > Other operators like apply/clear transform do actually overwrite keyed values I don't see any calls for this in the `OBJECT_OT_transform_apply` code. A test also shows that this doesn't happen: [#97628-apply-transform-when-keyed.blend](https://archive.blender.org/developer/F13045961/T97628-apply-transform-when-keyed.blend) - Open the file. The teapot starts sitting on top of the cube. - Drag the playhead around, see the teapot is animated. - Press {key Ctrl A} and apply all transforms. - Drag the playhead around, see the teapot is now no longer starting on top of the cube, and also has the wrong scale. This is because the animated scale is stacked on top of the applied scale. > So will confirm, even if this may be currently working as designed. Please don't do that. Code that works as designed is not a bug. Updating the animation is not a trivial thing. It a great idea, but when we do this, it should not just be for unparenting (but also for parenting, or even as a general "apply arbitrary transformation to animation data" so we can use it for more mass updates to keyed transforms), and should be worked on in a design task.

Sybren A. Stüvel commented

2022-05-03 13:24:03 +02:00

@iss poked me and showed me I misunderstood.

@JulienKaspar tip for bug reports: after the steps to reproduce, include a bit of info about what you'd expect to see and what you're actually seeing. I mean something like this:

Expected final result:	Actual final result:

BTW, I obtained the expected result with the Copy Global Transform operator, by copying before the Clear Parent, and pasting after. I agree that this shouldn't be necessary, and that "Keep Transform" should, in fact, keep the transform all by itself.

@iss poked me and showed me I misunderstood. @JulienKaspar tip for bug reports: after the steps to reproduce, include a bit of info about what you'd *expect* to see and what you're *actually* seeing. I mean something like this: | Expected final result: | Actual final result: | | -- | -- | | ![image.png](https://archive.blender.org/developer/F13048978/image.png) | ![image.png](https://archive.blender.org/developer/F13048975/image.png) | BTW, I obtained the expected result with the Copy Global Transform operator, by copying before the Clear Parent, and pasting after. I agree that this shouldn't be necessary, and that "Keep Transform" should, in fact, keep the transform all by itself.

Julien Kaspar commented

2022-05-03 14:05:35 +02:00

@dr.sybren Sorry I though the explanation in the description of the bug was clear enough. I'll add more visual examples next time (or at least describe what I expect in visual terms as well.)

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Clear and Keep Transformation not working when keyed #97628