Regression: Crash when selecting an object with an orphaned geo node link #111411
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2070 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 531.68
Broken: version: 3.5.0 Alpha, branch: master, commit date: 2022-11-10 21:29, hash:
Worked: version: 3.5.0 Alpha, branch: master, commit date: 2022-11-09 02:25, hash:
Short description of error
In the file that I'll attach, selecting the Cube in the Scene Collection in the View Layer immediately crashes and closes Blender.
Switching to the .blend file display, you can see orphaned node group references to another file.
These are at fault, as the geo node group "Geometry Nodes.002" from Cube used them.
The crash is associated with the geo node editor view. Changing that area to something else before clicking on the Cube doesn't crash Blender. Changing it back to the editor after clicking on the Cube crashes it.
Instead of crashing, the geo node editor should just display orphaned/broken groups.
Exact steps for others to reproduce the error
- Open the .blend file
- Click on the Cube object in the view layer.
- (Blender crashes/closes immediately)
Thanks for your consideration. :)
The socket drawing callback must check the node declarations to add attribute search. But the declaration may not be valid and require its updating. The callback takes a read-only node and socket. Your thoughts @HooglyBoogly (Would this kind of behavior be a safe choice) ?
Hm... caused by
I don't see any relation in the assertion and the only related commit for the entire bisect period...
I think updating the node declarations should be done eagerly rather than lazily, so there shouldn't be the need to do it on a
const node. But I haven't looked into this specific issue of why the update is missing yet.
No due date set.
No dependencies set.
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?