Regression: Crash when selecting an object with an orphaned geo node link #111411

New Issue

Closed

opened 2023-08-23 00:15:52 +02:00 by Mason · 3 comments

Mason commented

2023-08-23 00:15:52 +02:00

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2070 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 531.68

Blender Version
Broken: version: 3.5.0 Alpha, branch: master, commit date: 2022-11-10 21:29, hash: rBca1642cd0c5c
Worked: version: 3.5.0 Alpha, branch: master, commit date: 2022-11-09 02:25, hash: rB756538b4a117

Short description of error
In the file that I'll attach, selecting the Cube in the Scene Collection in the View Layer immediately crashes and closes Blender.
Switching to the .blend file display, you can see orphaned node group references to another file.
These are at fault, as the geo node group "Geometry Nodes.002" from Cube used them.
The crash is associated with the geo node editor view. Changing that area to something else before clicking on the Cube doesn't crash Blender. Changing it back to the editor after clicking on the Cube crashes it.

Expected behavior
Instead of crashing, the geo node editor should just display orphaned/broken groups.

Exact steps for others to reproduce the error

Open the .blend file
Click on the Cube object in the view layer.
(Blender crashes/closes immediately)

Thanks for your consideration. :)

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2070 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 531.68 **Blender Version** Broken: version: 3.5.0 Alpha, branch: master, commit date: 2022-11-10 21:29, hash: `rBca1642cd0c5c` Worked: version: 3.5.0 Alpha, branch: master, commit date: 2022-11-09 02:25, hash: `rB756538b4a117` **Short description of error** In the file that I'll attach, selecting the Cube in the Scene Collection in the View Layer immediately crashes and closes Blender. Switching to the .blend file display, you can see orphaned node group references to another file. These are at fault, as the geo node group "Geometry Nodes.002" from Cube used them. The crash is associated with the geo node editor view. Changing that area to something else before clicking on the Cube doesn't crash Blender. Changing it back to the editor after clicking on the Cube crashes it. **Expected behavior** Instead of crashing, the geo node editor should just display orphaned/broken groups. **Exact steps for others to reproduce the error** 1. Open the .blend file 2. Click on the Cube object in the view layer. 3. (Blender crashes/closes immediately) Thanks for your consideration. :)

crash when selecting geo nodes 2.blend

561 KiB

Mason added the

labels 2023-08-23 00:15:53 +02:00

Iliya Katushenock added

Nodes & Physics

and removed

labels 2023-08-23 00:22:48 +02:00

Iliya Katushenock added this to the 3.6 LTS milestone 2023-08-23 00:25:30 +02:00

Iliya Katushenock added

and removed

labels 2023-08-23 00:25:49 +02:00

Iliya Katushenock commented

2023-08-23 00:28:23 +02:00

Member

The socket drawing callback must check the node declarations to add attribute search. But the declaration may not be valid and require its updating. The callback takes a read-only node and socket. Your thoughts @HooglyBoogly (Would this kind of behavior be a safe choice) ?

The socket drawing callback must check the node declarations to add attribute search. But the declaration may not be valid and require its updating. The callback takes a read-only node and socket. Your thoughts @HooglyBoogly (Would this kind of behavior be a safe choice) ?

Iliya Katushenock changed title from ~~Crash when selecting an object with an orphaned geo node link~~ to Regression: Crash when selecting an object with an orphaned geo node link

2023-08-23 00:29:29 +02:00

Iliya Katushenock commented

2023-08-23 03:49:50 +02:00

Member

Hm... caused by 1efc94bb2f ?
I don't see any relation in the assertion and the only related commit for the entire bisect period...

Hm... caused by 1efc94bb2f7b0321935ce6564b23d5d92ee41594 ? I don't see any relation in the assertion and the only related commit for the entire bisect period...

Hans Goudey commented

2023-08-23 16:30:55 +02:00

Member

I think updating the node declarations should be done eagerly rather than lazily, so there shouldn't be the need to do it on a const node. But I haven't looked into this specific issue of why the update is missing yet.

I think updating the node declarations should be done eagerly rather than lazily, so there shouldn't be the need to do it on a `const` node. But I haven't looked into this specific issue of why the update is missing yet.

Jacques Lucke referenced this issue from a commit

2023-09-14 11:51:18 +02:00

Fix #111411: crash with group node that references linked-but-not-found group

Jacques Lucke closed this issue

2023-09-14 11:51:20 +02:00

Blender Bot added

and removed

labels 2023-09-14 11:51:23 +02:00

Jacques Lucke referenced this issue

2023-09-14 11:51:49 +02:00

Blender LTS: Maintenance Task 3.6 #109399

Philipp Oeser referenced this issue from a commit

2023-09-14 14:10:42 +02:00

Fix #111411: crash with group node that references linked-but-not-found group

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#111411

No description provided.