OSL CheckBox socket not working in NodeGroup #106760

New Issue

Closed

opened 2023-04-10 12:14:15 +02:00 by WinNder · 10 comments

WinNder commented

2023-04-10 12:14:15 +02:00

System Information
Operating system: Windows 10 Home
Graphics card: NVIDIA GeForce MX250

Blender Version
Broken: 3.5.0

Short description of error
OSL CheckBox socket doesn't work if the node is in the NodeGroup

Exact steps for others to reproduce the error

shader test(
int CheckBok = 0
    [[string widget = "checkBox"]],
output float out = 0
){
out = CheckBok;
}

**System Information** Operating system: Windows 10 Home Graphics card: NVIDIA GeForce MX250 **Blender Version** Broken: 3.5.0 **Short description of error** OSL CheckBox socket doesn't work if the node is in the NodeGroup ![image](/attachments/5635d589-9009-4600-81ce-8b5c02a2e331) ![image](/attachments/b22b54f8-41f3-49d8-92f3-81a24fa73d43) **Exact steps for others to reproduce the error** ```osl shader test( int CheckBok = 0 [[string widget = "checkBox"]], output float out = 0 ){ out = CheckBok; } ```

CheckBok.blend

858 KiB

WinNder added the

labels 2023-04-10 12:14:15 +02:00

Iliya Katushenock commented

2023-04-10 14:53:10 +02:00

Member

I'm not sure if the socket boolean type is supposed to work in shaders at all...

I'm not sure if the socket boolean type is supposed to work in shaders at all...

Iliya Katushenock added the

Nodes & Physics

Render & Cycles

labels 2023-04-10 14:53:50 +02:00

WinNder commented

2023-04-10 21:06:08 +02:00

Author

I'm not sure if the socket boolean type is supposed to work in shaders at all...

he is just a translator in 1 and 0, and everything works fantastic !
the only problem is the NodeGroup...

> I'm not sure if the socket boolean type is supposed to work in shaders at all... he is just a translator in 1 and 0, and everything works fantastic ! the only problem is the NodeGroup...

Iliya Katushenock commented

2023-04-10 21:20:51 +02:00

Member

The socket itself is not supported by shaders, and even if it is simply output to the render result, it will be 0 alway. I'm not sure why it is created at all.

The socket itself is not supported by shaders, and even if it is simply output to the render result, it will be 0 alway. I'm not sure why it is created at all.

WinNder commented

2023-04-10 22:04:18 +02:00

Author

The socket itself is not supported by shaders, and even if it is simply output to the render result, it will be 0 alway. I'm not sure why it is created at all.

I don't understand what the problem is if everything works fine !
and, checkbox is always useful...

this socket exists, and it works, which means that if it stops working somewhere, it is a bug !

> The socket itself is not supported by shaders, and even if it is simply output to the render result, it will be 0 alway. I'm not sure why it is created at all. I don't understand what the problem is if everything works fine ! and, checkbox is always useful... this socket exists, and it works, which means that if it stops working somewhere, it is a bug !

Germano Cavalcante added

Needs Info from Developers

Nodes & Physics

and removed

labels 2023-04-12 16:54:12 +02:00

Philipp Oeser commented

2023-04-13 09:07:43 +02:00

Member

I assume this is similar to #106508, so will mark/label the same (TODO)

I assume this is similar to #106508, so will mark/label the same (TODO)

Philipp Oeser added

Render & Cycles

and removed

Nodes & Physics

Render & Cycles

Needs Info from Developers

labels 2023-04-13 09:08:37 +02:00

Iliya Katushenock referenced this issue

2023-07-01 01:43:51 +02:00

Bool node socket checkboxes dont work for shader nodes #109574

Iliya Katushenock commented

2023-07-01 01:47:04 +02:00

Member

Still not sure if it should be TODO. In theory, any type of socket from geometry nodes, if created by some kind of hack in the shader, should not work, or this is a legal TODO.

Still not sure if it should be TODO. In theory, any type of socket from geometry nodes, if created by some kind of hack in the shader, should not work, or this is a legal TODO.

Cici commented

2023-07-01 01:54:07 +02:00

Contributor

Considering int sockets work fine I see no reason bools shouldnt.
Plus set_default_value in cycles/kernel/shader.cpp does actually handle the conversion for bools, so Id assume its an issue with whatever digests the nodetree itself? (my knowledge of blender's source is very rough and limited)

  case SocketType::INT: {
      if (b_sock.type() == BL::NodeSocket::type_BOOLEAN) {
        /* Make sure to call the int overload of set() since this is an integer socket as far as
         * Cycles is concerned. */
        node->set(socket, get_boolean(b_sock.ptr, "default_value") ? 1 : 0);
      }
      else {
        node->set(socket, get_int(b_sock.ptr, "default_value"));
      }
      break;
    }

Considering int sockets work fine I see no reason bools shouldnt. Plus `set_default_value` in `cycles/kernel/shader.cpp` does actually handle the conversion for bools, so Id assume its an issue with whatever digests the nodetree itself? (my knowledge of blender's source is very rough and limited) ```cpp case SocketType::INT: { if (b_sock.type() == BL::NodeSocket::type_BOOLEAN) { /* Make sure to call the int overload of set() since this is an integer socket as far as * Cycles is concerned. */ node->set(socket, get_boolean(b_sock.ptr, "default_value") ? 1 : 0); } else { node->set(socket, get_int(b_sock.ptr, "default_value")); } break; } ```

Iliya Katushenock commented

2023-07-01 01:57:35 +02:00

Member

@WinNder This is just undefined behavior due to cpu can read 4 byte of float as boolean / 1 byte of boolean as float. But this is not expected. And this shouldn't work to make blender more safe i guess...

@WinNder This is just undefined behavior due to cpu can read 4 byte of float as boolean / 1 byte of boolean as float. But this is not expected. And this shouldn't work to make blender more safe i guess...

Cici commented

2023-07-01 03:11:04 +02:00

Contributor

I got it to work with EEVEE. ~~Haven't for Cycles yet, idk how to go about that~~ (EDIT: It was literally one fallthrough case added to convert_socket_type in cycles/blender/shader.cpp), but for EEVEE it was mostly just adding a case for SOCK_BOOLEAN to ntree_shader_expand_socket_default in node_shader_tree.cc, as well as sprinkling in SOCK_BOOLEAN wherever SOCK_INT is.

Idk how to submit code though I'll have to read up on that part, sorry.

I got it to work with EEVEE. ~~Haven't for Cycles yet, idk how to go about that~~ (EDIT: It was literally one fallthrough case added to `convert_socket_type` in `cycles/blender/shader.cpp`), but for EEVEE it was mostly just adding a case for `SOCK_BOOLEAN` to `ntree_shader_expand_socket_default` in `node_shader_tree.cc`, as well as sprinkling in `SOCK_BOOLEAN` wherever `SOCK_INT` is. Idk how to submit code though I'll have to read up on that part, sorry. ![booleeegifffff.gif](/attachments/12de8142-d30c-4bcf-be2e-9aa8eb9bc60b)

booleeegifffff.gif

458 KiB

Cici referenced a pull request that will close this issue

2023-07-01 04:39:41 +02:00

Fix #106760: Bool node socket default value isn't output for shader nodes #109576

WinNder commented

2023-07-12 12:34:41 +02:00

Author

@Consta thank you very much for your attention and work !

@Consta thank you very much for your attention and work !

Brecht Van Lommel referenced this issue from a commit

2023-10-05 21:55:18 +02:00

Fix #106760: Cycles OSL boolean socket not working

Brecht Van Lommel closed this issue

2023-10-05 21:55:21 +02:00

Blender Bot added the

label 2023-10-05 21:55:22 +02:00

Brecht Van Lommel referenced this issue

2023-10-05 21:56:08 +02:00

Blender LTS: Maintenance Task 3.6 #109399

Philipp Oeser referenced this issue from a commit

2023-10-12 13:54:53 +02:00

Fix #106760: Cycles OSL boolean socket not working

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106760

No description provided.